Hi Kumar,
I don't quite see how this gets the "jre" part of a JDK:
! JAVA_JRE_BIN = new File(JAVAHOME, "bin").getAbsolutePath();
!
! File libDir = (isSDK)
! ? new File((new File(JAVAHOME)).getParentFile(), "lib")
! : new File(JAVAHOME, "lib");
!
Hi Stuart,
On 15/11/2013 9:56 AM, Stuart Marks wrote:
On 11/14/13 2:04 AM, David Holmes wrote:
Sorry for the delay (been enroute). Only issue I have remains the
subSequence
change - you can't weaken the post-condition of
CharSequence.subSequence without
breaking subtype substitutability.
Hi
Hello,
Catching up on email, the specification of java.lang.Class does not
explicitly promise that its notion of equality must be identity for all
time. Therefore, while not required for today's implementations, I would
prefer that new code we write in the JDK use equals rather than == when
c
On 11/14/2013 6:54 PM, Kumar Srinivasan wrote:
New full webrev:
http://cr.openjdk.java.net/~ksrini/8023978/webrev.1/index.html
Delta webrev wrt. webrev.0
http://cr.openjdk.java.net/~ksrini/8023978/webrev.1/webrev.delta/index.html
This looks much better. Nit: JAVA_LIB could be interprete
Joel,
If you haven't done so already, please file an rfe to capture Peter's
suggestions.
Thanks,
-Joe
On 11/4/2013 7:29 AM, Joel Borggrén-Franck wrote:
Hi Peter,
As always, thanks for doing this!
On 2 nov 2013, at 22:58, Peter Levart wrote:
Hi,
I propose a set of straightforward optim
Hi Mandy,
Thanks for reviewing this, comments inlined.
Hi Kumar,
On 11/14/2013 2:57 PM, Kumar Srinivasan wrote:
Hello,
Please review fixes to the launcher tests, which allows for missing
server vm variant.
All SE platforms have server vm, however Embedded SE systems do
not contain server,
Changeset: 40d0ccd00f87
Author:xuelei
Date: 2013-11-14 16:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0ccd00f87
8014266: regression test AsyncSSLSocketClose.java time out.
Reviewed-by: xuelei
Contributed-by: Rajan Halade
!
test/sun/security/ssl/com/sun/net/ssl/int
On 11/14/13 2:04 AM, David Holmes wrote:
Sorry for the delay (been enroute). Only issue I have remains the subSequence
change - you can't weaken the post-condition of CharSequence.subSequence without
breaking subtype substitutability.
Hi David,
Yes, in general, what you say about weakening p
Hi Volker,
On 15/11/2013 2:35 AM, Volker Simonis wrote:
Hi,
I wanted to solve "8026964: Building with an IBM J9 boot jdk requires
special settings for BOOT_RTJAR"
(https://bugs.openjdk.java.net/browse/JDK-8026964) and came across the
question what the real semantics of BOOT_RTJAR is?
For the
Hi Kumar,
On 11/14/2013 2:57 PM, Kumar Srinivasan wrote:
Hello,
Please review fixes to the launcher tests, which allows for missing
server vm variant.
All SE platforms have server vm, however Embedded SE systems do
not contain server, most of them have client, thus these
tests needed to be co
Xueming Shen wrote on 11/14/2013 11:20 AM:
> On 11/14/2013 11:12 AM, Bill Shannon wrote:
>> Alan Bateman wrote on 11/14/2013 06:18 AM:
>>> On 13/11/2013 20:28, Xueming Shen wrote:
Yes, the plan is to see what other implementations do.
>>> I think we've run out road on this for JDK 8. Even if w
Hello,
Please review fixes to the launcher tests, which allows for missing
server vm variant.
All SE platforms have server vm, however Embedded SE systems do
not contain server, most of them have client, thus these
tests needed to be compensated for that.
http://cr.openjdk.java.net/~ksrini/802
Changeset: 5ae66d372d57
Author:bpatel
Date: 2013-11-14 13:47 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ae66d372d57
8025524: javadoc does not correctly locate constructors for nested classes
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javadoc/ConstructorDoc
Hi,
please oblige and review the following fix
http://cr.openjdk.java.net/~msheppar/8028215/webrev/
which addresses the issue detailed in
https://bugs.openjdk.java.net/browse/JDK-8028215
This addresses an ORB initialization problem, which has arisen when the
com.sun.corba.se.** packages wer
Hi,
The consensus/conclusion from the discussion [1] regarding the changes we
made earlier for JDK-8025003 [2] is to back out the existing "half-lenient"
change
to leave the door open for a clean "lenient" support for future releases.
Here is the webrev for the undo (keep the mime encoder(...)
Changeset: 59f46f135584
Author:hseigel
Date: 2013-11-14 10:44 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59f46f135584
8023041: The CDS classlist needs to be updated for JDK 8
Summary: Generate new classlists from JDK 8 classes
Reviewed-by: alanb, coleenp, hseigel
Contribu
Changeset: e79d6425f1c4
Author:vromero
Date: 2013-11-14 19:28 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4
8026963: type annotations code crashes for code with erroneous trees
Reviewed-by: jjg, jlahoda
! src/share/classes/com/sun/tools/javac/comp/Attr.ja
On 11/14/2013 11:12 AM, Bill Shannon wrote:
Alan Bateman wrote on 11/14/2013 06:18 AM:
On 13/11/2013 20:28, Xueming Shen wrote:
Yes, the plan is to see what other implementations do.
I think we've run out road on this for JDK 8. Even if we had agreement on
dealing with corrupt input then there
Alan Bateman wrote on 11/14/2013 06:18 AM:
> On 13/11/2013 20:28, Xueming Shen wrote:
>>
>> Yes, the plan is to see what other implementations do.
> I think we've run out road on this for JDK 8. Even if we had agreement on
> dealing with corrupt input then there is little/no time to get feedback an
Changeset: 65f7b83ab477
Author:sla
Date: 2013-11-14 19:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477
8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps
consistent
Reviewed-by: alanb, allwin, sspitsyn, mgronlun
! src/share/classes
Changeset: 24eaf41a3974
Author:emc
Date: 2013-11-14 12:32 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/24eaf41a3974
8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java
Summary: Remove @ignore from test
Reviewed-by: jjg
! test/tools/javac/T70426
Hi Joe,
The new webrev looks good...
-- daniel
On 11/13/13 11:08 PM, huizhe wang wrote:
On 11/13/2013 1:33 PM, Alan Bateman wrote:
On 13/11/2013 20:02, huizhe wang wrote:
Hi,
The issue is that the limits applied to each processing process
rather than each file processing. This applies to n
Hi,
I wanted to solve "8026964: Building with an IBM J9 boot jdk requires
special settings for BOOT_RTJAR"
(https://bugs.openjdk.java.net/browse/JDK-8026964) and came across the
question what the real semantics of BOOT_RTJAR is?
Currently, for OpenJDK/Oracle based boot JDKs BOOT_RTJAR is simply s
You are right that collect() would be a good start, but sadly there is no
DoubleCollector which trucks in doubles. So the concept is right but it
doesn't quite get you all the way there. Looking one level down, you'll find a
nicer answer. I would look at ReduceOps.makeDouble(), which ultimatl
On 11/14/2013 2:51 AM, Alan Bateman wrote:
On 13/11/2013 22:08, huizhe wang wrote:
:
Each parser has its own copy of XMLSecurityManager that maintains the
values of the limits. The parser is reset before it starts to parse a
document. Resetting the values managed by XMLSecurityManager
there
Thanks, Alan. I've looked at this and reviewed it too, so I'll push
it. Thanks Harold for sending it out.
Coleen
On 11/14/2013 10:03 AM, harold seigel wrote:
Hi Alan,
Thank you for the review.
Harold
On 11/13/2013 10:04 AM, Alan Bateman wrote:
On 13/11/2013 14:55, harold seigel wrote:
Thank you Stuart
It took me a little time to correct the code. sorry be late. This is new webrev
for the code change. Please help to review it again.
Description:
1. Convert shell script test to Java program test.
2. Using random server port by reusing Darryl Mocek's
work(TestLibrary.getUnusedRa
Hi Alan,
Thank you for the review.
Harold
On 11/13/2013 10:04 AM, Alan Bateman wrote:
On 13/11/2013 14:55, harold seigel wrote:
Hi,
Please review this fix, submitted by Ekaterina Pavlova, to update the
CDS classlist files for JDK 8.
The classlist files were generated using the process des
On 13/11/2013 20:28, Xueming Shen wrote:
Yes, the plan is to see what other implementations do.
I think we've run out road on this for JDK 8. Even if we had agreement
on dealing with corrupt input then there is little/no time to get
feedback and do any further adjustments. Technically only sho
Changeset: 83c768d6cb93
Author:jfranck
Date: 2013-11-14 12:17 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c768d6cb93
8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with
-Dsun.reflect.noInflation=true
Reviewed-by: briangoetz
! src/share/class
On 13/11/2013 22:08, huizhe wang wrote:
:
Each parser has its own copy of XMLSecurityManager that maintains the
values of the limits. The parser is reset before it starts to parse a
document. Resetting the values managed by XMLSecurityManager therefore
makes sure that the limits are per docum
Changeset: ecf85f4aecf0
Author:alanb
Date: 2013-11-14 10:40 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecf85f4aecf0
8028343: More ProblemList.txt updates (11/2013)
Reviewed-by: chegar
! test/ProblemList.txt
Thanks for doing this Alan, the changes look fine to me.
-Chris.
On 14/11/13 10:24, Alan Bateman wrote:
Lana pulled hs25-b58 into jdk8/tl yesterday and that has the fix to the
math exact intrinsics that required us to temporarily exclude a bunch of
tests (JSR-310 mostly) recently. These tests
Lana pulled hs25-b58 into jdk8/tl yesterday and that has the fix to the
math exact intrinsics that required us to temporarily exclude a bunch of
tests (JSR-310 mostly) recently. These tests can be liberated again. In
addition there are a few other tests that need to be excluded, pending
other
Hello,
Please take an initial look over a fix for
JDK-8006572 DoubleStream.sum() & DoubleSummaryStats implementations
that reduce numerical errors
http://cr.openjdk.java.net/~darcy/8006572.0/
The basic approach is to use compensated summation
http://en.wikipedia.org/wiki/Kahan_su
35 matches
Mail list logo
