RFR for JDK-8030284 TEST_BUG: intermittent StackOverflow in RMI bench/serial test

Hi Everyone Please help to review the fix for JDK-8030284. http://cr.openjdk.java.net/~tyan/JDK-8030284/webrev.00/ This is a one line fix that add -Xss to prevent StackOverflowError. Thank you Tristan

hg: jdk8/tl/langtools: 8016549: jdk7 javadocs are hard to read

Changeset: b8ebde062692 Author:bpatel Date: 2013-12-18 19:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8ebde062692 8016549: jdk7 javadocs are hard to read Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java - src/share/classes

hg: jdk8/tl/jdk: 7093640: Enable client-side TLS 1.2 by default

Changeset: 8d35f0985dd7 Author:xuelei Date: 2013-12-18 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d35f0985dd7 7093640: Enable client-side TLS 1.2 by default Reviewed-by: weijun, mullan, wetmore ! src/share/classes/sun/security/ssl/ProtocolVersion.java ! src/share/

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/18/2013 9:03 AM, Peter Levart wrote: Hi Mandy, Daniel, Here's yet another variant that reduces the doPrivileged code to just Handler's setters. This way no LogManager methods are invoked under elevated privilege: http://cr.openjdk.java.net/~plevart/jdk8-tl/jul.Handler.sealed/webrev.06

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/18/2013 5:55 AM, Peter Levart wrote: On 12/17/2013 06:43 PM, Mandy Chung wrote: Can you check what methods are called by the constructors whose access are denied in the current implementation but granted in the patch? I have to take another look to make sure but I believe they only cal

Re: RFR: 8030192 - [TEST_BUG] java/util/logging/TestLoggerBundleSync.java failed with NPE

On 12/18/2013 7:02 AM, Daniel Fuchs wrote: Hi Please find below a fix for: 8030192 - [TEST_BUG] java/util/logging/TestLoggerBundleSync.java failed with NPE https://bugs.openjdk.java.net/browse/JDK-8030192 http://cr.openjdk.java.net/~dfuchs/webrev_8030192/webrev.00/ The patch loo

Re: RFR: java/util/logging/Logger/setResourceBundle/TestSetResourceBundle.java failing again

On 12/17/2013 3:57 AM, Daniel Fuchs wrote: Hi, Please find below a fix for what I believe is a test bug. I plan to push this in JDK 9 dev. https://bugs.openjdk.java.net/browse/JDK-8030187 This seems to be a very intermittent failure. It looks as if a logger held in a local variable can be arb

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/17/2013 06:43 PM, Mandy Chung wrote: Can you check what methods are called by the constructors whose access are denied in the current implementation but granted in the patch? I have to take another look to make sure but I believe they only calls the methods in the handler classes that ca

Re: RFR: simple javadoc cleanup in java.net

On 18 Dec 2013, at 14:35, roger riggs wrote: > Thanks Alan, > > I corrected the webrev to link both locations that refer to ProxySelector. > http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Looks good. Thanks Roger. -Chris. > > Roger > > On 12/18/2013 6:23 AM, Alan Bateman

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

Hi Sergey, java/util/Vector.java could use the id=xxx idiom instead of In java/util/zip/package.html I would omit the extra tags; the style sheet should be providing the spacing. The rest looks fine: (Not a Reviewer) Roger On 12/18/2013 9:38 AM, Serge wrote: Hi all. Please review the sec

RFR for JDK-8030057: speed up forceLogSnapshot and checkAnnotations

Hi Everyone Please help to review the code change for bug JDK-8030057. http://cr.openjdk.java.net/~tyan/JDK-8030057/webrev.00/ Description: Performance improvement for two RMI tests java/rmi/activation/Activatable/forceLogSnapshot

RFR: 8030192 - [TEST_BUG] java/util/logging/TestLoggerBundleSync.java failed with NPE

Hi Please find below a fix for: 8030192 - [TEST_BUG] java/util/logging/TestLoggerBundleSync.java failed with NPE https://bugs.openjdk.java.net/browse/JDK-8030192 http://cr.openjdk.java.net/~dfuchs/webrev_8030192/webrev.00/ There were two issues in the test: 1. The message that was

Re: RFR for JDK-7168267: TEST_BUG: Cleanup of rmi regression tests (activation and others)

Hi Everyone Please review the code fix for bug JDK-7168267 http://cr.openjdk.java.net/~tyan/JDK-7168267/webrev.01/ This is a cleanup for RMI tests. trying to use real timeout to replace a fixed number of loop. Thank you Tristan O

Re: RFR: simple javadoc cleanup in java.net

On 18/12/2013 14:35, roger riggs wrote: Thanks Alan, I corrected the webrev to link both locations that refer to ProxySelector. http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Looks good. -Alan

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

Hi all. Please review the second fix http://cr.openjdk.java.net/~yan/8029451/webrev.03 for https://bugs.openjdk.java.net/browse/JDK-8029451 As suggest Martin, I replaced "a name=" to "p id=" in java/util/ArrayList.java. In java/util/zip/pac

Re: RFR: simple javadoc cleanup in java.net

Thanks Alan, I corrected the webrev to link both locations that refer to ProxySelector. http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Roger On 12/18/2013 6:23 AM, Alan Bateman wrote: On 17/12/2013 22:35, roger riggs wrote: Please review, an easy one, just 1 less bug on th

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/17/2013 06:43 PM, Mandy Chung wrote: Can you check what methods are called by the constructors whose access are denied in the current implementation but granted in the patch? I have to take another look to make sure but I believe they only calls the methods in the handler classes that ca

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/18/2013 12:05 PM, Daniel Fuchs wrote: But then we have another problem with doPrivileged approach, since it is even more restrictive than 'sealed' field approach. Currently the Handler's subclass that overrides a setter and calls super, works: @Override public void setOutputStream(OutputS

Re: RFR: simple javadoc cleanup in java.net

On 17/12/2013 22:35, roger riggs wrote: Please review, an easy one, just 1 less bug on the queue. Webrev, http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ This looks okay but I think the bug is asking for a link from URLStreamHandler#openConnection. -Alan.

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/18/13 12:55 AM, Peter Levart wrote: On 12/17/2013 11:02 PM, Daniel Fuchs wrote: On 12/17/13 6:02 PM, Peter Levart wrote: On 12/17/2013 05:26 PM, Mandy Chung wrote: This is a good point. The patch for JDK 8 and above uses limited doPrivileged that only grants LoggingPermission("control

Re: RFR (JAXP) 8029955 : AIOB in XMLEntityScanner.scanLiteral upon parsing literals with > 100 LF chars

On 18.12.2013 06:18, huizhe wang wrote: Why didn't you like this very short version? : JAXP currently maintains a code level 1.5 (Apache Xerces at 1.4). While we're getting close to the end of JAXP standalone, we may consider newer/advanced features in JDK9. But we'll get to that discussion

RFR: 8025051: Update resource files for TimeZone display names

Hi, Please help to review a fix [1] for 8025051 bug [2]. The following fix includes: - The translation of time zone generic names were added to all locales. - Time Zone names were updated according to the latest translations. - Added tz names regression test (test/sun/util/resources/TimeZon

hg: jdk8/tl/corba: 8026741: jdk8 l10n resource file translation update 5

Changeset: eb5d3f8ca0ca Author:mfang Date: 2013-12-17 22:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/eb5d3f8ca0ca 8026741: jdk8 l10n resource file translation update 5 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp