Re: RFR (JAXP): 8027359: XML parser returns incorrect parsing results

2014-01-03 Thread Lance @ Oracle
Looks ok joe Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 3, 2014, at 1:07 PM, huizhe wang wrote: > Hi, > > This is an issue with the XML 1.1 scanner. Any

hg: jdk8/tl/jdk: 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"

2014-01-03 Thread joe . darcy
Changeset: 68de5492a06d Author:darcy Date: 2014-01-03 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity" Reviewed-by: mduigou, psandoz ! src/share/classes/java/ut

Re: JDK 9 RFR of 8030814: Long.parseUnsignedLong should throw exception on too large input

2014-01-03 Thread Joe Darcy
Hi Brian, I think more explanation of how the new code works needs to be included in the code (and the commented out code should be deleted). For the test, I would expect something with a bit simpler structure, but perhaps I don't fully understand the boundary cases of the new code. -Joe O

JDK 9 RFR of 8030814: Long.parseUnsignedLong should throw exception on too large input

2014-01-03 Thread Brian Burkhalter
Issue: https://bugs.openjdk.java.net/browse/JDK-8030814 webrev: http://cr.openjdk.java.net/~bpb/8030814/webrev.2/ This review request follows from the discussion of last month in this thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December/024031.html The contributed patch be

Re: JDK 9 RFR of JDK-8029561: Optimization in Integer to string conversion

2014-01-03 Thread Joe Darcy
On 01/02/2014 11:44 AM, Brian Burkhalter wrote: Following up from this thread of last week http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December/024162.html with respect to https://bugs.openjdk.java.net/browse/JDK-8029561. The change being suggested in this review request is merel

RFR (JAXP): 8027359: XML parser returns incorrect parsing results

2014-01-03 Thread huizhe wang
Hi, This is an issue with the XML 1.1 scanner. Any reference to the data buffer needs to be removed, that is, the content copied, when the buffer is reloaded with new data. The fix is to duplicate the solution from the XML 1.0 scanner. webrev: http://cr.openjdk.java.net/~joehw/jdk9/8027359/

Re: Update on 8014320

2014-01-03 Thread Tim Buktu
> On Dec 23, 2013, at 11:37 AM, Tim Buktu wrote: >> * Compact storage of DFT vectors. At the moment, they are stored as >> numbers modulo 2^2^(n+1) when (2^2^n)+1 would suffice. This will save >> memory and may speed up the DFT and IDFT steps. It did indeed improve performance. The latest patched

hg: jdk8/tl/jdk: 2 new changesets

2014-01-03 Thread sean . coffey
Changeset: 46c727d6ecc2 Author:aefimov Date: 2013-12-30 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2 8025051: Update resource files for TimeZone display names Reviewed-by: okutsu, mfang ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! sr

Re: (reflect) Accessing members of inner annotations types

2014-01-03 Thread Peter Levart
On 01/03/2014 03:52 PM, Peter Levart wrote: This is would be all right until such proxy class (com.sun.proxy.$Proxy1 in our example) has to access some package-private types in some specific package. This happens in your Named.List annotation implementation class. It implements a member metho

Re: (reflect) Accessing members of inner annotations types

2014-01-03 Thread Peter Levart
I think the problem is as follows... Annotations are implemented as Java dynamic Proxy classes. The generated proxy class for a package-private interface is created in the same package as the interface so that it has access to the interface. The top level interface can be package private, but n

(reflect) Accessing members of inner annotations types

2014-01-03 Thread Gunnar Morling
Hi, In the course of running the Bean Validation TCK on JDK 8, I'm investigating an issue around reflectively accessing members of annotations which are declared as inner type of another, package-private annotation type. The following shows an example: @Retention( RetentionPolicy.RUNTIME )

Re: JDK 9 RFR of JDK-8027595: Enable BigInteger overflow tests in JTREG

2014-01-03 Thread Alan Bateman
On 02/01/2014 20:47, Brian Burkhalter wrote: Would adding @run main/othervm -Xmx1200M BitLengthOverflow and similarly to the other three tests be acceptable? Brian This could potentially be problematic on Windows 32-bit but it would help if you add -Xshare:off so that you don't have the share