Hi Stuart
Should variable initialized be volatile here? Otherwise looks good.
Thank you
Tristan
On Jan 29, 2014, at 2:51 PM, Stuart Marks wrote:
> Hi all,
>
> Please review this fix to a race condition in rmid initialization. Briefly,
> rmid subclasses the RMI registry implementation and provi
Hi Tristan,
I don't want to put the workaround into ActivationLibrary.rmidRunning() for a
null return from the lookup, because this is only a workaround for an actual bug
in rmid initialization. See the review I just posted for JDK-8023541.
Adding JavaVM.waitFor(timeout) is something that wou
Hi all,
Please review this fix to a race condition in rmid initialization. Briefly, rmid
subclasses the RMI registry implementation and provides special handling for its
own stub. Unfortunately the registry is exported in the super() call, making
remote calls possible before rmid's stub initia
Changeset: e385bd6f7338
Author:rfield
Date: 2014-01-28 17:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e385bd6f7338
8032697: Issues with Lambda
Reviewed-by: ahgross, briangoetz, dlsmith, rfield
Contributed-by: daniel.sm...@oracle.com
! src/share/classes/java/lang/invoke
Changeset: 4f590c2cec75
Author:jeff
Date: 2014-01-28 20:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/4f590c2cec75
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: c8d9cdc6445c
Author:rfield
Date: 2014-01-28 13:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8d9cdc6445c
8032711: Issue with Lambda in handling
8032704: Issues with lib perm in Lambda
Reviewed-by: jrose, ahgross, briangoetz
! src/share/classes/java/lang/invok
Changeset: d3b293a4d554
Author:jeff
Date: 2014-01-28 20:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d3b293a4d554
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: afa91c54ff00
Author:jeff
Date: 2014-01-28 20:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/afa91c54ff00
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: 72d0cc723560
Author:jeff
Date: 2014-01-28 20:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72d0cc723560
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: 2b44c111e153
Author:jeff
Date: 2014-01-28 20:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2b44c111e153
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: 60c2c003fa11
Author:jeff
Date: 2014-01-28 20:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/60c2c003fa11
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: ce0320cdb075
Author:jeff
Date: 2014-01-28 20:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce0320cdb075
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
Changeset: 6d40c0d49c7a
Author:jeff
Date: 2014-01-28 20:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6d40c0d49c7a
8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
! THIRD_PARTY_README
On 1/28/14 4:06 AM, Paul Sandoz wrote:
Hi Mike,
Your patch is slightly out of sync with 9:
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c8c4f441fc76
This was the changeset I pushed yesterday causing this and removed
"sun.lang.ClassLoader.allowArraySyntax". Sorry for the timing.
htt
On 28/01/2014 08:44, Peter Levart wrote:
Yes, I tried that too and it results in even more unsafe casts.
It's odd yes, since the compile-time error is not present when
building via OpenJDK build system make files (using "make images" in
top directory for example) but only if I compile the cla
On 27/01/2014 20:17, Mike Duigou wrote:
Hello all;
This is a bit of cleanup I did back during Java 8 that got deferred due to it's
late arrival during the development cycle. I've updated it for Java 9.
http://cr.openjdk.java.net/~mduigou/JDK-8022854/0/webrev/
This change improves the implemen
Changeset: 56d05f260123
Author:vlivanov
Date: 2014-01-28 13:46 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d05f260123
8032585: JSR292: IllegalAccessError when attempting to invoke protected method
from different package
Reviewed-by: twisti, jrose
! src/share/classes/su
Hi Mike,
Your patch is slightly out of sync with 9:
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c8c4f441fc76
http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/src/share/classes/sun/misc/VM.java
--
Generally looks OK.
Bikeshed-wise i prefer something like getPublicSavedProperties rather th
Chris, John, thank you for reviewing the fix.
I'll proceed with choice #1 then. Filed a bug [1] to track cleanup
activities.
Best regards,
Vladimir Ivanov
[1] https://bugs.openjdk.java.net/browse/JDK-8032881
On 1/28/14 4:50 AM, John Rose wrote:
This is safe as a point fix, since (a) Lookup.
On 01/28/2014 03:17 AM, David Holmes wrote:
On 27/01/2014 5:07 AM, Peter Levart wrote:
On 01/25/2014 05:35 AM, srikalyan chandrashekar wrote:
Hi Peter, if you are a committer would you like to take this further
(OR) perhaps david could sponsor this change.
Hi,
Here's new webrev that takes i
20 matches
Mail list logo
