Re: RFR [8038333] java/lang/ref/EarlyTimeout.java failed

On 3/26/2014 3:57 PM, David Holmes wrote: Ivan, I think the problem is that the EarlyTimeout threads can complete their remove(TIMEOUT) before the main thread has started them all, cleared the reference and called System.gc(). Depending on exactly what is being tested, the EarlyTimeout threa

Re: RFR: JDK-8036818: DateTimeFormatter withResolverFields() fails to accept null

Stephen, public DateTimeFormatter withResolverFields(TemporalField... resolverFields) { - Objects.requireNonNull(resolverFields, "resolverFields"); - Set fields = new HashSet<>(Arrays.asList(resolverFields)); + Set fields = null; + if (resolverFields != null) { + fields = Collections.unmodifiable

Re: RFR [8038333] java/lang/ref/EarlyTimeout.java failed

Ivan, I think the problem is that the EarlyTimeout threads can complete their remove(TIMEOUT) before the main thread has started them all, cleared the reference and called System.gc(). Depending on exactly what is being tested, the EarlyTimeout threads may need to wait on another latch that

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

The link to the JBS bug is incorrect in original review request. This one is a correct one: https://bugs.openjdk.java.net/browse/JDK-8035437. Sorry for the confusion, Aleksej On 26.03.2014 20:44, Aleksej Efimov wrote: Lance, The document implementation (DocumentImpl) returned by 'builder.newD

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

Hi Chris, This is very nice. Are there plans to do this for the other existing tests as well? sure, but we didn't have enough time to do it in 8u20 timeframe. So I'd like to push these changes 1st, since we need this to cover 'Speedup catch exceptions'. Other tests will be rewrite later. I h

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

On Mar 24, 2014, at 1:33 PM, Igor Ignatyev wrote: > Hi all, > > Please review the patch: > > Problems: > - MethodHandlesTest::testCatchException() doesn't provide enough testing of > j.l.i.MethodHandles::catchException(). > - MethodHandlesTest contains more than 3k lines, an auxiliary code to

Re: RFR [8038333] java/lang/ref/EarlyTimeout.java failed

Thank you Mandy! Are you able to reproduce the test failure? Yes, I could easily reproduce the failure when I reduced the timeout to 10 ms. With the timeout reduced, the test fails every third time on my machine. I think the test verifies that only one thread gets the reference is a good t

Re: ProcessReaper: single thread reaper

On 03/26/2014 07:09 PM, Martin Buchholz wrote: On Wed, Mar 26, 2014 at 11:01 AM, Roger Riggswrote: Hi Martin, My solution to that is to export a public API that can be used by other subsystems that fork processes. Some peaceful cooperation is required. Roger, I don't think cooperation i

Re: ProcessReaper: single thread reaper

Hi Martin, My solution to that is to export a public API that can be used by other subsystems that fork processes. Some peaceful cooperation is required. Roger On 3/26/14 10:54 AM, Martin Buchholz wrote: Peter and Roger, please stop going down this road until you have a solution for my sh

Re: ProcessReaper: single thread reaper

Hi Roger, Your current implementation works for the demostrated use case in UNIXProcess, where a single call-back is registered for a pid. If you wanted to register another, the waitList and exitList might have already removed the pid from them as a result of the 1st call-back already been se

Re: Improve timezone mapping for AIX platform

Hi Jonathan, thanks for doing this change. Please find some comments below: 1. please update the copyright year to 2014 in every file you touch 2. in CopyFiles.gmk you can simplify the change by joining the windows and aix cases because on Windows OPENJDK_TARGET_OS is the same like OPENJDK_TARGE

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

Lance, The document implementation (DocumentImpl) returned by 'builder.newDocument()' should implement org.w3c.dom.Node and org.w3c.dom.Document interfaces, but shouldn't have the 'getXmlVersion' method (in Node, Document and DocumentImpl) - it's a main item required by Apache bug. So it means

Re: RFR [8038333] java/lang/ref/EarlyTimeout.java failed

Hi Ivan, On 3/26/2014 6:15 AM, Ivan Gerasimov wrote: Hello! The test java/lang/ref/EarlyTimeout.java, which has been recently added to the repository with the fix for 6853696 has failed. The error message of the failure "more than one references were removed from queue" seems to be misguiding

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

Any reason not to use StringBuilder in place of StringBuffer in XMLEntityManager.java other than the above and my question on the need of using run.sh, it is OK On Mar 26, 2014, at 12:54 PM, Lance Andersen wrote: > Hi Aleksej, > > Do you really need to use run.sh? If possible it would be bet

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

Hi Aleksej, Do you really need to use run.sh? If possible it would be better to try and avoid providing a script and use the jtreg keywords. Best Lance On Mar 26, 2014, at 12:39 PM, Aleksej Efimov wrote: > Hello, > > Can I ask for a review for the update of DOMSerializerImpl class [1] to th

RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

Hello, Can I ask for a review for the update of DOMSerializerImpl class [1] to the latest Apache Xerces implementation. The following changes were made: 1. The DOMSerializerImpl update: The Xerces class was used as a base [2]; the 476047 and 473125 revisions from Xerces was excluded (they wi

Re: Implicit 'this' return for void methods

It would be nice to make this language change. In the past years, it's pretty clear many JSR EE spec leads have gone on to make their APIs return the same object because they strongly prefer to see object chaining in code. I sympathize with those designers, but I don't agree; I wouldn't affect my A

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd & UNIXProcess.java.linux (& .solaris & .aix)

On 26/03/2014 15:19, Peter Levart wrote: I couldn't find any official document about possible os.name values for different supported OSes. Does anyone have a pointer? I don't know if there is a definite list but I assume we don't need to be concerned with anything beyond the 4 that we have in Op

Re: Implicit 'this' return for void methods

On Mar 26, 2014, at 4:17 AM, Ulf Zibis wrote: > See also: > . . . > http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001180.html This last one has a specific proposal, which is simple and quite nice. The important idea is that we don’t actually make any change to the code of void me

RFR: 8000975: (process) Merge UNIXProcess.java.bsd & UNIXProcess.java.linux (& .solaris & .aix)

Hi, This is a preview of the effort to merge all 4 variants of UNIXProcess class into one source. Here's the bug: https://bugs.openjdk.java.net/browse/JDK-8000975 And here's the webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/UNIXProcess/webrev.02/ Per Alan's suggestion I have made

Re: RFR (L) 8037210: Get rid of char-based descriptions 'J' of basic types

Here's a version with the new naming scheme: http://cr.openjdk.java.net/~vlivanov/8037210/webrev.03.naming I like existing naming scheme and OBJECT/VOID/LONG/etc names are quite popular(e.g. Wrapper & ASM (Opcodes) use them). So, I'm in favor of leaving it as is. Best regards, Vladimir Ivanov

RFR [8038333] java/lang/ref/EarlyTimeout.java failed

Hello! The test java/lang/ref/EarlyTimeout.java, which has been recently added to the repository with the fix for 6853696 has failed. The error message of the failure "more than one references were removed from queue" seems to be misguiding. I suspect that the real cause of the failure could

Re: Improve timezone mapping for AIX platform

Hi Jonathan, The AIX specific code looks OK to me. But I'd suggest the code be moved to getPlatformTimeZoneID() for AIX, which just returns NULL currently. Also there's a function for producing a fallback ID in "GMT±hh:mm", getGMTOffsetID() which can be called in tzerr. Thanks, Masayoshi On

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

On Mar 26, 2014, at 5:21 AM, David Holmes wrote: > Mike, > > On 26/03/2014 6:37 AM, Mike Duigou wrote: >> Hello all; >> >> Recently HotSpot gained additional support for transactional memory, >> . This patch is a >> libraries followon to that

Re: Implicit 'this' return for void methods

See also: http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-April/001512.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-April/001365.html http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001180.html -Ulf Am 25.03.2014 21:19, schrieb Victor Polischuk: Good day,

Re: Implicit 'this' return for void methods

See: https://bugs.openjdk.java.net/browse/JDK-6472931 https://bugs.openjdk.java.net/browse/JDK-6373386 https://bugs.openjdk.java.net/browse/JDK-6479372 https://bugs.openjdk.java.net/browse/JDK-4774077 https://bugs.openjdk.java.net/browse/JDK-6451131 https://bugs.openjdk.java.net/browse/JDK-5082736

Re: Improve timezone mapping for AIX platform

Adding i18n-dev to the thread as i18n-dev is where the TZ code is maintained. On 26/03/2014 06:47, Jonathan Lu wrote: Hi ppc-aix-port-dev, core-libs-dev, Here's a patch for JDK-8034220, http://cr.openjdk.java.net/~luchsh/JDK-8034220/ It is trying to add the a more complete timezone mapping