On Mar 28, 2014, at 10:52 AM, Marek Kozieł wrote:
> Hi,
> I really do not know why some proposals are restored back from the
> grave, without answering for questions that was already made:
> http://mail.openjdk.java.net/pipermail/jdk8-dev/2011-December/000382.html
>
> Problem lay on interfaces
On 3/24/14 3:11 PM, Anthony Petrov wrote:
How does IS_JNI_TRUE sound?
It looks good. If nobody objects, the final version will be:
#define IS_NULL(obj) ((obj) == NULL)
#define JNU_IsNull(env,obj) ((obj) == NULL)
+#define IS_JNI_TRUE(obj) ((obj) ? JNI_TRUE : JNI_FALSE)
without additional cast.
Hi Alan,
thanks for the review.
On Thu, Mar 27, 2014 at 7:31 PM, Alan Bateman wrote:
> On 27/03/2014 18:08, Volker Simonis wrote:
>>
>> Hi,
>>
>> a security audit for the PPC64/AIX port revealed an unsecure useage of
>> 'strcpy' in Java_sun_tools_attach_AixVirtualMachine_connect(). Because
>> th
Hi,
I really do not know why some proposals are restored back from the
grave, without answering for questions that was already made:
http://mail.openjdk.java.net/pipermail/jdk8-dev/2011-December/000382.html
2014-03-28 12:37 GMT+01:00 Ulf Zibis :
>
> Am 28.03.2014 11:05, schrieb Florian Weimer:
>>>
This looks good to me also. Thanks Pavel.
I can sponsor this change for you.
-Chris.
On 28/03/14 11:35, Pavel Rappo wrote:
Hi everyone,
could you please review my change for JDK-8037781:
http://cr.openjdk.java.net/~chegar/8037781/webrev.00/
After JDK-8035158 was fixed we freed our hands to
Hi Chris,
I regenerated webrev against current hg tip - the copyright changes
should be ok now.
patch file is attached, the new webrev is uploading just now:
http://cr.openjdk.java.net/~mkos/8036030/jaxws.01/
JBS: https://bugs.openjdk.java.net/browse/JDK-8036030
Let me know if it is ok now.
Th
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that
I'll
remove TestCase.assertEQ and enhance Asserts.assertEquals for arrays
add the test cases from TestCatchException to 'MANDATORY_TEST_CASES' in
CatchExceptionTest and remove TestCatchException
in JDK9 TF.
upd
Looks good to me.
Best regards,
Vladimir Ivanov
On 3/28/14 8:04 PM, Igor Ignatyev wrote:
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that
I'll
remove TestCase.assertEQ and enhance Asserts.assertEquals for arrays
add the test cases from TestCatchException to 'M
Hi Dimitry,
sorry, but I already pushed the change.
However I don't think this is a big problem because:
- if the file does not exist, connect will fail with "No such file or directory"
- if the file exists by chance (but is not a socket) connect will fail
with "Connection refused"
- if the file
Volker,
I think we should check the length of passed filename and
throw an exception if filename is too long.
Otherwise we can end up opening wrong file with possibly not expected
permissions.
-Dmitry
On 2014-03-27 22:08, Volker Simonis wrote:
> Hi,
>
> a security audit for the PPC64/AIX port
On 28/03/2014 11:35, Pavel Rappo wrote:
Hi everyone,
could you please review my change for JDK-8037781:
http://cr.openjdk.java.net/~chegar/8037781/webrev.00/
After JDK-8035158 was fixed we freed our hands to remove these 4 classes:
1. sun.misc.RegexpPool,
2. sun.misc.RegexpTar
Am 28.03.2014 11:05, schrieb Florian Weimer:
String mySub = myVeryLongNamedString.substring(.indexOf("C"),.indexOf("Q"));
You can already write
String mySub = apply(myVeryLongNamedString,
(s) -> s.substring(s.indexOf("C"), s.indexOf("Q")))
with a helper function like this:
Hi everyone,
could you please review my change for JDK-8037781:
http://cr.openjdk.java.net/~chegar/8037781/webrev.00/
After JDK-8035158 was fixed we freed our hands to remove these 4 classes:
1. sun.misc.RegexpPool,
2. sun.misc.RegexpTarget,
3. sun.misc.Regexp,
With the change to stringbuilder I am ok with it
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Mar 26, 2014, at 1:44 PM, Aleksej Efimov wrote:
> Lanc
Vladimir, thanks for review, please my comments inline.
On 03/28/2014 01:29 PM, Vladimir Ivanov wrote:
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You ca
On 28/03/14 11:16, Lance @ Oracle wrote:
Looks fine
Looks good to me too.
-Chris.
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Mar 28, 2014, at 6:58 AM, alex
Looks fine
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Mar 28, 2014, at 6:58 AM, alexander stepanov
wrote:
> Hello,
>
> Could you please review the fix for t
Hello,
Could you please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8038493
Webrev corresponding:
http://cr.openjdk.java.net/~yan/8038493/webrev.00/
Just a minor cleanup of javadoc to avoid tidy warnings; no other code
affected.
Thanks.
Regards,
Alexander
On 03/28/2014 05:57 AM, Victor Polischuk wrote:
Ulf,
I think that point leading style is something which can be easily mistreat. If
we complicate the example:
String mySub = myVeryLongNamedString.substring(.indexOf("C"),.indexOf("Q"));
to something like:
String mySub =
myVeryLongNam
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You can convert TestCase & TestFactory to inner classes and move
ThrowMode into TestCase since it's usage is co
Hi Miran,
I have skimmed the webrev, and it looks ok to me.
You seem to have some files with changes for 8029237, which is already
integrated into jdk9/dev. Can you remove this, then I will sponsor the
change for you.
-Chris.
On 07/03/14 16:21, Miroslav Kos wrote:
Hi,
there is a bulk updat
On Fri, Mar 28, 2014 at 5:57 AM, Victor Polischuk wrote:
> Ulf,
>
> I think that point leading style is something which can be easily
> mistreat. If we complicate the example:
>
>String mySub =
> myVeryLongNamedString.substring(.indexOf("C"),.indexOf("Q"));
>
> to something like:
>
>Strin
22 matches
Mail list logo
