Re: UUID.compareTo broken?

2014-04-11 Thread Peter Levart
On 04/10/2014 08:21 PM, Steven Schlansker wrote: On Apr 9, 2014, at 2:21 AM, Paul Sandoz paul.san...@oracle.com wrote: On Apr 8, 2014, at 9:15 PM, Mike Duigou mike.dui...@oracle.com wrote: That seems a terribly broken usage of UUID for 128 bit numbers or a pair of signed 64 bit numbers :-)

Re: JDK 9 RFR of 8035427: Math.random() JavaDoc: missing maximum returned value

2014-04-11 Thread Paul Sandoz
On Apr 11, 2014, at 1:24 AM, Brian Burkhalter brian.burkhal...@oracle.com wrote: Hello, This is a minor amplification of information already contained in the javadoc. Issue:https://bugs.openjdk.java.net/browse/JDK-8035427 Patch:

RFR: [8039396] NPE when writing a class descriptor object to a custom ObjectOutputStream

2014-04-11 Thread Ivan Gerasimov
Hello everybody! ObjectStreamClass#forClass() function is allowed to return null, if the local VM does not have the corresponding local class. Because of that, NPE can be encountered during serialization through a subclass of ObjectOutputStream. Would you please help review the fix? BUGURL:

Re: UUID.compareTo broken?

2014-04-11 Thread Paul Sandoz
On Apr 11, 2014, at 8:54 AM, Peter Levart peter.lev...@gmail.com wrote: Hi, Code that relies on UUIDs to have a natural order, say chronological, is relying on being given the particular type of UUIDs that have the time built-in. When given mixed-type or non-time-based UUIDs, such code

Re: ProcessReaper: single thread reaper

2014-04-11 Thread Peter Levart
On 04/09/2014 03:20 PM, roger riggs wrote: Hi Peter, On a related topic, the request to be able to destroy a Process and all of its children might also want to used the group pid to be able to identify all of the children. Hi Roger, This would require each child spawned by Process API to

Re: i18n dev Improve timezone mapping for AIX platform

2014-04-11 Thread Volker Simonis
Hi Jonathan, thank you for fixing all the remaining issues. From my point of view this change looks good now. @Masayoshi: can I please get a final approval from you for pushing the change? I also want to downport this to 8u-dev but I don't think that's a big deal as this only touches AX code.

Re: ProcessReaper: single thread reaper

2014-04-11 Thread roger riggs
Hi Peter, Understood, but didn't want ignore another requested feature. Iterating over children is workable but I'm not clear whether if an intermediate child dies/is killed that its children are reparented up the tree. If for one reason or another a grandchild is reparented to pid 1 then it

Re: ProcessReaper: single thread reaper

2014-04-11 Thread Peter Levart
On 04/09/2014 07:02 PM, Martin Buchholz wrote: On Tue, Apr 8, 2014 at 11:08 PM, Peter Levart peter.lev...@gmail.com mailto:peter.lev...@gmail.com wrote: Hi Martin, As you might have seen in my later reply to Roger, there's still hope on that front: setpgid() + wait(-pgid, ...)

Re: JDK 9 RFR of 8035427: Math.random() JavaDoc: missing maximum returned value

2014-04-11 Thread Brian Burkhalter
On Apr 11, 2014, at 12:30 AM, Paul Sandoz paul.san...@oracle.com wrote: Does such a non-normative change require a CCC? I think the changes could be placed under an @apiNote tag. Personally I would think not but was prepared to submit one. It's a shame that java.util.Random is explicitly

Re: JDK 9 RFR of 8035427: Math.random() JavaDoc: missing maximum returned value

2014-04-11 Thread Paul Sandoz
On Apr 11, 2014, at 4:56 PM, Brian Burkhalter brian.burkhal...@oracle.com wrote: On Apr 11, 2014, at 12:30 AM, Paul Sandoz paul.san...@oracle.com wrote: Does such a non-normative change require a CCC? I think the changes could be placed under an @apiNote tag. Personally I would think

Re: ProcessReaper: single thread reaper

2014-04-11 Thread Peter Levart
On 04/11/2014 04:45 PM, roger riggs wrote: Hi Peter, Understood, but didn't want ignore another requested feature. Iterating over children is workable but I'm not clear whether if an intermediate child dies/is killed that its children are reparented up the tree. If a parent dies, all it's

Re: ProcessReaper: single thread reaper

2014-04-11 Thread roger riggs
Hi Peter, We do know the PIDs of the processes that we care about but are unwilling to pay the cost of waiting for them individually. For the escapees, Process could resort to an individual thread invoking waitpid(n). Thanks, Roger On 4/11/2014 10:52 AM, Peter Levart wrote: On 04/09/2014

RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
Hello all; This is a simple cleanup changeset that removes redundant initialization of fields to null from a number of collection classes. These field initializations may seem cheap but they do have a cost: - For volatile fields there is a measurable cost on some benchmarks for these extra

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

2014-04-11 Thread Lance @ Oracle
Overall it looks ok. I think you will get some unchecked warnings from com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java Any reason not to address this for your HashMap and ArrayList? Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Lance @ Oracle
Looks fine mike Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 11, 2014, at 3:22 PM, Mike Duigou mike.dui...@oracle.com wrote: Hello all; This is a simple

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Aleksey Shipilev
On 04/11/2014 11:22 PM, Mike Duigou wrote: https://bugs.openjdk.java.net/browse/JDK-8035284 http://cr.openjdk.java.net/~mduigou/JDK-8035284/0/webrev/ This! Thumbs up. Redundant null initializations in other components/packages will be handled in separate issues. I also remember seeing

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
Apparently javac did at elide the extraneous null initialization at one point and it was deemed to have been contrary to point #4 of the procedure in JLS 12.5 (http://docs.oracle.com/javase/specs/jls/se7/html/jls-12.html#jls-12.5-220-D) Mike On Apr 11 2014, at 12:57 , Martin Buchholz

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Chris Hegarty
This look good to me. I'm really happy to see these do away. I'll help clean up other areas too. -Chris On 11 Apr 2014, at 20:22, Mike Duigou mike.dui...@oracle.com wrote: Hello all; This is a simple cleanup changeset that removes redundant initialization of fields to null from a

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Chris Hegarty
On 11 Apr 2014, at 21:04, Mike Duigou mike.dui...@oracle.com wrote: Apparently javac did at elide the extraneous null initialization at one point and it was deemed to have been contrary to point #4 of the procedure in JLS 12.5

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
I and others have tried to track down the compiler issue in which this change was made. If anyone can point us in the right direction it would be nice to reference that issue. Mike On Apr 11 2014, at 13:09 , Chris Hegarty chris.hega...@oracle.com wrote: On 11 Apr 2014, at 21:04, Mike

Re: JDK 9 RFR of 8035427: Math.random() JavaDoc: missing maximum returned value

2014-04-11 Thread Brian Burkhalter
On Apr 11, 2014, at 8:09 AM, Paul Sandoz paul.san...@oracle.com wrote: On Apr 11, 2014, at 4:56 PM, Brian Burkhalter brian.burkhal...@oracle.com wrote: On Apr 11, 2014, at 12:30 AM, Paul Sandoz paul.san...@oracle.com wrote: Does such a non-normative change require a CCC? I think the

RFR: JDK-8038500: (zipfs) Upgrade ZIP provider to be a supported provider

2014-04-11 Thread Xueming Shen
Hi, Please help review this changeset to upgrade the zip filesystem provider implementation from demo to a supported provider. Back in JDK7 we created a demo file system provider for zip/jar files. It is shipped in two forms, one as a binary under lib/ext that works out of the box to support

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

2014-04-11 Thread David Li
Hi Lance, Good catch. I have uploaded a fixed review. I had forgotten about this since Xerces is at JDK 1.4, while we had agreed to move to JDK 1.7. It's good to get these lint warnings fixed now since we are planning to do a large scale fix later on. I also made a similar fix in

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

2014-04-11 Thread Lance Andersen
Hi David, Looks better. You should be able to clean this up further by using the diamond operator. Once you do this, you are good to go. Best Lance On Apr 11, 2014, at 7:09 PM, David Li david.x...@oracle.com wrote: Hi Lance, Good catch. I have uploaded a fixed review. I had forgotten

Re: RFR: JDK-8038500: (zipfs) Upgrade ZIP provider to be a supported provider

2014-04-11 Thread Mandy Chung
On 4/11/2014 3:42 PM, Xueming Shen wrote: webrev: http://cr.openjdk.java.net/~sherman/8038500/webrev It's good to see the source of the zip provider moved to the jdk repo. You have made some public classes to package-private which is good. I wonder whether a few remaining public classes

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

2014-04-11 Thread David Li
Got it, updated. Same place: http://cr.openjdk.java.net/~dli/8037259/webrev/ Thanks, David On 4/11/2014 4:21 PM, Lance Andersen wrote: Hi David, Looks better. You should be able to clean this up further by using the diamond operator. Once you do this, you are good to go. Best Lance On

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

2014-04-11 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 11, 2014, at 7:48 PM, David Li david.x...@oracle.com wrote: Got it, updated. Same place: