On May 12, 2014, at 1:00 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
src/share/classes/sun/misc/UUDecoder.java
126 StringBuilder x = new StringBuilder();
Is only filled, but doesn't seem to be used anyhow.
Maybe just delete it?
Thanks, i will take a look at this and your
On May 12, 2014, at 4:07 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi Paul,
I looked at -management and the changes there look good.
There is just some two spaces vs four space formatting in
On 12/05/2014 11:55, Paul Sandoz wrote:
On May 12, 2014, at 12:42 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to aid
reviewing. When commenting please including core-libs.
The
On 12/05/2014 20:22, huizhe wang wrote:
Would you think the wordings in the javadoc of Properties could be
stronger in terms of encoding, e.g. instead of:
The |loadFromXML(InputStream)|
http://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#loadFromXML-java.io.InputStream-and
On May 13, 2014, at 11:34 AM, Seán Coffey sean.cof...@oracle.com wrote:
thanks for the comments. I hit a build issue when introducing some lambda
syntax to the corba repo : https://bugs.openjdk.java.net/browse/JDK-8042932
That's fixed now and I can continue with the corba push. I've
Hi,
Can I have a review for 8032901 bug [1] fix [2]. There is a possible
case when 'WaitForMultipleObjects' function can return the
WAIT_ABANDONED_0 [3] error value.
In such case it's better to release the mutex and return error value.
This will prevent other threads to be blocked on
On 05/12/2014 05:43 PM, Sandipan Razzaque wrote:
Hi Remi -
Thank you for the fast response, I have indeed signed the OCA.
I shall work on the bug you suggested (JDK-8037343
https://bugs.openjdk.java.net/browse/JDK-8037343) over the week and
submit a patch. Note that my work on OpenJDK is
This is debugger's shared memory transport so cc'ing serviceability-dev
as that is there this code is maintained.
Is there a test case or any outline of the conditions that cause this? I
think that would be useful to understand the issue further.
-Alan
On 13/05/2014 11:46, Aleksej Efimov
Hi, Paul.
adding 2d-dev@
media: sound/awt/swing part looks fine.
Note that this part of the fix should be pushed to client forest.
On 5/12/14 2:03 PM, Paul Sandoz wrote:
Hi,
This is a request for review of Otavio's patch replacing StringBuffer
with StringBuilder within OpenJDK. (I also need
Alan,
There is no test case for this issue and also the attempt to outline the
conditions ended with no result. The report is based only on
'WaitForMultipleObjects' code analysis and this fix is an attempt to
make the code looks a little more correct.
-Aleksej
On 05/13/2014 02:57 PM, Alan
I don't understand this one at all. What is an abandoned mutex? For
that matter why does the code wait on a mutex and an event? Do we
already own the mutex? If so what does it mean to wait on it? If not
then how can we release it?
???
Thanks,
David
On 13/05/2014 8:57 PM, Alan Bateman
David,
The Windows has a different terminology for mutex objects (much differs
from the POSIX one). This one link gave me some understanding of it [1].
Here is the MSDN [1] description of what abandoned mutex is:
If a thread terminates without releasing its ownership of a mutex
object, the
On May 13, 2014, at 1:10 PM, Sergey Bylokhov sergey.bylok...@oracle.com wrote:
Hi, Paul.
adding 2d-dev@
media: sound/awt/swing part looks fine.
Thanks.
Note that this part of the fix should be pushed to client forest.
Which classes exactly from here:
On 5/13/2014 1:50 AM, Alan Bateman wrote:
On 12/05/2014 20:22, huizhe wang wrote:
Would you think the wordings in the javadoc of Properties could be
stronger in terms of encoding, e.g. instead of:
The |loadFromXML(InputStream)|
That's some nice code reduction Paul. Thanks.
http://cr.openjdk.java.net/~coffeys/webrev.8042906.v3/webrev/
I'll push these changes later unless I hear to the contrary.
regards,
Sean.
On 13/05/2014 11:22, Paul Sandoz wrote:
On May 13, 2014, at 11:34 AM, Seán Coffey sean.cof...@oracle.com
On 13 May 2014, at 19:53, Seán Coffey sean.cof...@oracle.com wrote:
That's some nice code reduction Paul. Thanks.
http://cr.openjdk.java.net/~coffeys/webrev.8042906.v3/webrev/
I'll push these changes later unless I hear to the contrary.
Push it quick!
-Chris.
regards,
Sean.
On
Paul,
I don't see why you changed the variable names in some cases.
See here where one change is only one line since you left it alone and
the other is 6 lines since you changed it
Hi Aleksej,
Thanks for the doc references regarding abandonment.
Let me rephrase my question. What is this logic trying to achieve by
waiting on both a mutex and an event? Do we already own the mutex when
this function is called?
David
On 13/05/2014 11:19 PM, Aleksej Efimov wrote:
David,
In windows, you acquire a mutex by waiting on it using one of the wait
functions, one of them employed in the code in question. If
WaitForMultipleObjects succeeds and returns the index of the mutex, current
thread has ownership now.
It's also common to use multi wait functions where the event is
19 matches
Mail list logo
