On 19/05/2014 07:53, Paul Sandoz wrote:
If i don't have permission to push to the client repo (which might be likely) i
will need to hand over the patch to yourself or Sergey to commit. And i presume
this will have to be a separate issue.
If you do decide to split this then it will require crea
Hi,
this is review request for:
8039210: Fix type error in DefaultResourceInjector
JBS: https://bugs.openjdk.java.net/browse/JDK-8039210
WEBREV: http://cr.openjdk.java.net/~mkos/8039210/jaxws.00/
It is simple one-line fix; it's blocker for another issue.
Thanks
Miran
Hi,
this is review request for:
8043129: JAF initialisation in SAAJ clashing with the one in javax.mail
JBS: https://bugs.openjdk.java.net/browse/JDK-8043129
WEBREV:
http://cr.openjdk.java.net/~mkos/8043129/jaxws.00/
http://cr.openjdk.java.net/~mkos/8043129/jdk.00/ (test)
This solves conflict b
This looks ok to me Miran.
-Chris.
On 19/05/14 14:33, Miroslav Kos wrote:
Hi,
this is review request for:
8039210: Fix type error in DefaultResourceInjector
JBS: https://bugs.openjdk.java.net/browse/JDK-8039210
WEBREV: http://cr.openjdk.java.net/~mkos/8039210/jaxws.00/
It is simple one-line
On 5/19/2014 12:50 AM, Alan Bateman wrote:
On 19/05/2014 07:53, Paul Sandoz wrote:
If i don't have permission to push to the client repo (which might be
likely) i will need to hand over the patch to yourself or Sergey to
commit. And i presume this will have to be a separate issue.
If you do dec
Miran,
The source change looks ok to me. Have you commented out the line adding
the handler because it may be reinstated, or as a reminder that it was
deliberately omitted?
The test, at the very minimum, will need a suitable copyright header. I
also wonder if there is any other way of testin
Hi,
I've not got any feedback so far, so I assume it's good:-)
Anyway, I'm going a little further to throw in a TarInputStream so now we just
build the
tzdb data directly on the tzdata201xy.tar.gz from iana site. I'm not sure if
it is OK to
check in the original .tar.gz file into the jdk repo
On May 16, 2014, at 4:56 AM, Tobias Hartmann wrote:
> Is it sufficient then to use synchronized (lambdaForms) { ... } in
> setCachedLambdaForm(..) and a normal read in cachedLambdaForm(..)?
Yes, that is how I see it. The fast path is a racy non-volatile read of a
safely-published structure.
Chris Hegarty wrote on 05/19/14 10:27:
> Miran,
>
> The source change looks ok to me. Have you commented out the line adding the
> handler because it may be reinstated, or as a reminder that it was
> deliberately
> omitted?
Either way, the code could probably use a comment to explain why it's
co
On May 19, 2014, at 6:18 PM, Phil Race wrote:
> On 5/19/2014 12:50 AM, Alan Bateman wrote:
>> On 19/05/2014 07:53, Paul Sandoz wrote:
>>> If i don't have permission to push to the client repo (which might be
>>> likely) i will need to hand over the patch to yourself or Sergey to commit.
>>> An
10 matches
Mail list logo