RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

2014-05-30 Thread Eric Wang
Hi, Please help to review the fix for bug https://bugs.openjdk.java.net/browse/JDK-8004807 as below: http://cr.openjdk.java.net/~ewang/JDK-8004807/webrev.00/ The root cause of the failure is if Timer.cancel() is not called in time, the recurring timer task keeps running which cause the the a

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-30 Thread Bruno Medeiros
Indeed, I gave it a try with 7u60 and I couldn't replicated it. Seems like it was a dup of that one. On Thu, May 29, 2014 at 3:38 PM, Alan Bateman wrote: > On 29/05/2014 14:32, roger riggs wrote: > >> Hi Bruno, >> >> Create an issue: >> JDK-8044321

Re: Please review: 8044046: [asm] refresh internal ASM version to v5.0.3

2014-05-30 Thread Paul Sandoz
On May 28, 2014, at 1:20 AM, Kumar Srinivasan wrote: > Hello, > > Please review the following webrev which updates internal ASM to v5.0.3, the > individual bug fixes are > listed in the JBS issue for reference, > > https://bugs.openjdk.java.net/browse/JDK-8044046#comment-13501358 > > All co

Re: Please review: 8044046: [asm] refresh internal ASM version to v5.0.3

2014-05-30 Thread A. Sundararajan
Looks good to me. -Sundar On Friday 30 May 2014 08:23 PM, Paul Sandoz wrote: On May 28, 2014, at 1:20 AM, Kumar Srinivasan wrote: Hello, Please review the following webrev which updates internal ASM to v5.0.3, the individual bug fixes are listed in the JBS issue for reference, https://bu

RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread roger riggs
A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the jdk9-dev repo (except client packages). webrev: http://cr.openjdk.ja

Re: RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread Lance Andersen
Looks fine On May 30, 2014, at 2:30 PM, roger riggs wrote: > A quick sanity check please for these cleanup changes to remove uses of > new Boolean and using chars instead of single character strings contributed > by Otávio Gonçalves de Santana. > > These changes update multiple classes in th

Re: inefficient indexof when String has one length

2014-05-30 Thread Tom Schindl
On the same topic but still a bit different shouldn't indexOf(String) check for the size and call indexOf(char) when the length is 1, same for indexOf(String,int)? Tom On 26.04.14 11:56, Otávio Gonçalves de Santana wrote: > When a String has length just one, could be replaced by equivalent > char

Re: RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread Alan Bateman
On 30/05/2014 19:30, roger riggs wrote: A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the jdk9-dev repo (except clien

JDK 9 RFR of fallthrough fix in ASM

2014-05-30 Thread Joe Darcy
Hello, Please review this change to suppress a fall-through warning recently sync'ed into ASM: --- a/src/share/classes/jdk/internal/org/objectweb/asm/Item.java Fri May 30 13:37:35 2014 -0700 +++ b/src/share/classes/jdk/internal/org/objectweb/asm/Item.java Fri May 30 16:19:12 2014 -0700 @@ -

Re: JDK 9 RFR of fallthrough fix in ASM

2014-05-30 Thread Lance Andersen
+1 On May 30, 2014, at 7:28 PM, Joe Darcy wrote: > Hello, > > Please review this change to suppress a fall-through warning recently sync'ed > into ASM: > > --- a/src/share/classes/jdk/internal/org/objectweb/asm/Item.java Fri May 30 > 13:37:35 2014 -0700 > +++ b/src/share/classes/jdk/internal/