On 5/06/2014 5:25 AM, Martin Buchholz wrote:
Tests for Timer are inherently timing (!) dependent.
It's reasonable for tests to assume that:
- reasonable events like creating a thread and executing a simple task
should complete in less than, say 2500ms.
Not necessarily with the wrong combination
Reviewed.
This is not a requirement, but I would prefer (in general) to see less test
logic in ASM-generated bytecode and more in Java. I am guessing that the
invokeExact call could have been replaced by a simple weakly-typed invoke call
in the framing code, and likewise with most of the other
Thanks for review, Paul.
Looks ok.
The behaviour of MethodHandles.Lookup.findSpecial got me confused for a while
:-)
Minor point: is it also worth exposing a T3.lookup() method and on the returned Lookup
calling findSpecial(T1.class, "m", MethodType.methodType(int.class),
T3.class).invokeE
Hi,
any update?
Best regards,
Andrej Golovnin
On 29.05.2014, at 09:35, Joel Borggrén-Franck wrote:
> Hi,
>
> We need you send in the patches via the mailing list. Please reply to your
> mail with the diffs attached directly (not zipped for example).
>
> I’ll might have time to look at this
On 05/06/2014 11:37, Jonathan Lu wrote:
If getsockopt(SO_ERROR) failed, I did not find any explicit docs
about the behavior.
but as I tested with some C code snippet, the value of sockopt_arg
would not be changed if getsockopt(SO_ERROR) failed.
So I prefer to keep the current approach, does
I was expecting it to go to 9-client ..
-phil.
On 6/5/2014 10:16 AM, Henry Jen wrote:
Thanks Sergey and Phil for reviewing. I assume this can go into
jdk9/dev although in JBS the category is client-libs?
Cheers,
Henry
On 06/05/2014 02:40 AM, sergey malenkov wrote:
The fix looks good for me.
Thanks Sergey and Phil for reviewing. I assume this can go into jdk9/dev
although in JBS the category is client-libs?
Cheers,
Henry
On 06/05/2014 02:40 AM, sergey malenkov wrote:
The fix looks good for me.
Thanks,
SAM
On 05.06.2014 2:14, Henry Jen wrote:
Hi,
Please review a trivial webrev
Hi Alan,
On Wed, Jun 4, 2014 at 9:16 PM, Alan Bateman
wrote:
> On 04/06/2014 07:31, Jonathan Lu wrote:
>
>> Hi Volker,
>>
>> Thanks for your comment! an updated webrev was made at
>> http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/
>>
>> Would it make sense to set errno to sockopt_arg for the
On Jun 4, 2014, at 5:25 PM, Vladimir Ivanov
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8032400
> http://cr.openjdk.java.net/~vlivanov/8032400/webrev.00/
>
> Consider the following hierarchy:
> class T1{int m() { return 1; }}
> class T2 extends T1 { static int m() {
