Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-15 Thread Remi Forax
On 06/15/2014 12:36 AM, Claes Redestad wrote: Hi, please review this patch to add offset based variants of Integer.parseInt/parseUnsignedInt, Long.parseLong/parseUnsignedLong and expose them through JavaLangAccess along with formatUnsignedInt/-Long. This is proposed to enable a number of

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-15 Thread Claes Redestad
On 2014-06-15 13:48, Remi Forax wrote: On 06/15/2014 12:36 AM, Claes Redestad wrote: Hi, please review this patch to add offset based variants of Integer.parseInt/parseUnsignedInt, Long.parseLong/parseUnsignedLong and expose them through JavaLangAccess along with formatUnsignedInt/-Long.

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-15 Thread Claes Redestad
I've updated the patch to use CharSequence in favor of String for all new methods, as well as ensuring all new methods are package private (for now): http://cr.openjdk.java.net/~redestad/8041972/webrev.2/ Reviews appreciated! /Claes On 2014-06-15 14:29, Claes Redestad wrote: On 2014-06-15

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-15 Thread Remi Forax
On 06/16/2014 12:22 AM, Claes Redestad wrote: I've updated the patch to use CharSequence in favor of String for all new methods, as well as ensuring all new methods are package private (for now): http://cr.openjdk.java.net/~redestad/8041972/webrev.2/ Reviews appreciated! /Claes Thanks,

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-15 Thread Remi Forax
On 06/15/2014 02:29 PM, Claes Redestad wrote: On 2014-06-15 13:48, Remi Forax wrote: On 06/15/2014 12:36 AM, Claes Redestad wrote: Hi, please review this patch to add offset based variants of Integer.parseInt/parseUnsignedInt, Long.parseLong/parseUnsignedLong and expose them through