Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: > > On 6/30/14, 3:50 PM, Christian Thalinger wrote: >> private Class(ClassLoader loader) { >> // Initialize final field for classLoader. The initialization >> value of non-null >> // prevents future JIT optimization

Re: RFR 8048840: File.createTempFile has uninformative failure message

Hello, Do you think this fixes the complaints? I can imagine that "" or "~" is used, and including this in the exception does not really help. "Prefix string too short, must be 3 characters" would be my choice, but I wonder if the restriction is very usefull anyway? Bernd Am 01.07.2014 03:17 sch

Re: RFR 8048840: File.createTempFile has uninformative failure message

Oops - forgot to run jtreg. Make that: diff --git a/src/share/classes/java/io/File.java b/src/share/classes/java/io/File.java --- a/src/share/classes/java/io/File.java +++ b/src/share/classes/java/io/File.java @@ -1998,7 +1998,8 @@ throws IOException { if (prefix.length() <

Re: RFR: 8023276: Java SE should include the full DOM API from JAXP

Thanks Mandy, Lance. The changeset is pushed. -Joe On 6/30/2014 5:02 PM, Mandy Chung wrote: On 6/30/14 2:32 PM, huizhe wang wrote: Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We add

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = lo

Re: RFR: 8023276: Java SE should include the full DOM API from JAXP

On 6/30/14 2:32 PM, huizhe wang wrote: Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We added org.w3c.dom.views in JAXP 1.6 and fixed JDK-8006843. But since we were too close to the dead

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On Jun 30, 2014, at 1:06 PM, Coleen Phillimore wrote: > > On 6/30/14, 3:50 PM, Christian Thalinger wrote: >> private Class(ClassLoader loader) { >> // Initialize final field for classLoader. The initialization >> value of non-null >> // prevents future JIT optimization

Re: RFR: 8023276: Java SE should include the full DOM API from JAXP

+1 On Jun 30, 2014, at 5:32 PM, huizhe wang wrote: > Hi, > > Three packages are missing from the DOM API documentation in JAXP: >org.w3c.dom.views >org.w3c.dom.ranges >org.w3c.dom.traversal > > We added org.w3c.dom.views in JAXP 1.6 and fixed JDK-8006843. But since we >

RFR: 8023276: Java SE should include the full DOM API from JAXP

Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We added org.w3c.dom.views in JAXP 1.6 and fixed JDK-8006843. But since we were too close to the deadline for JAXP 1.6 MR, we left the other

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

On 6/30/2014 1:16 PM, Lance @ Oracle wrote: Hi joe, Should be a comma at the end of line 8 before the and on line 9 comma added. Looks ok otherwise I committed the change. Thanks again Lance and Henry! -Joe Best Lance Lance

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

Hi joe, Should be a comma at the end of line 8 before the and on line 9 Looks ok otherwise Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 30, 20

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

That makes sense. I changed @since back to 1.4 and added L2 in the description: http://cr.openjdk.java.net/~joehw/jdk9/8037948/webrev/ Thanks, Joe On 6/30/2014 12:35 PM, Henry Jen wrote: On 06/30/2014 12:26 PM, Lance Andersen wrote: On Jun 30, 2014, at 3:22 PM, huizhe wang wrote: On 6/3

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = lo

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = loader; +componentType = null; } Are we wor

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

On 06/30/2014 12:26 PM, Lance Andersen wrote: On Jun 30, 2014, at 3:22 PM, huizhe wang wrote: On 6/30/2014 12:20 PM, Lance Andersen wrote: Looks OK Joe, noticed the @since changed as well? Thanks for review. Yes. The support for DOM L3 was since JDK 1.5. Previously this package file men

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

On Jun 30, 2014, at 3:22 PM, huizhe wang wrote: > > On 6/30/2014 12:20 PM, Lance Andersen wrote: >> Looks OK Joe, noticed the @since changed as well? > > Thanks for review. > > Yes. The support for DOM L3 was since JDK 1.5. Previously this package file > mentioned only DOM L2. OK, thank y

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

On 6/30/2014 12:20 PM, Lance Andersen wrote: Looks OK Joe, noticed the @since changed as well? Thanks for review. Yes. The support for DOM L3 was since JDK 1.5. Previously this package file mentioned only DOM L2. -Joe Best Lance On Jun 30, 2014, at 3:17 PM, huizhe wang

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

Looks OK Joe, noticed the @since changed as well? Best Lance On Jun 30, 2014, at 3:17 PM, huizhe wang wrote: > Hi, > > This is a quick fix for a broken link in org.w3c.dom package. Also included > is removal of unnecessary (and bad) link to jaxp api in a catalog class. > Please review. > >

RFR: 8037948: Improve documentation for org.w3c.dom package

Hi, This is a quick fix for a broken link in org.w3c.dom package. Also included is removal of unnecessary (and bad) link to jaxp api in a catalog class. Please review. http://cr.openjdk.java.net/~joehw/jdk9/8037948/webrev/ Thanks, Joe

RFR: 8044656: Update JAX-WS RI integration to latest version

Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8044656/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8044656 Could I ask for a review/approval? Thanks Miran

Re: RFR: 8047722: @since tag cleanup in corba

On 06/30/2014 12:18 AM, Alan Bateman wrote: On 30/06/2014 02:30, Henry Jen wrote: Ping. : On 06/20/2014 02:28 PM, Henry Jen wrote: Hi, Please review a trivial webrev for jdk9/corba that do the same @since tag normalization as in jdk9/jdk. http://cr.openjdk.java.net/~henryjen/jdk9/8047722/

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

Thank you, Fred, and thanks for correcting the link below. Coleen On 6/30/14, 10:27 AM, Frederic Parain wrote: On 30/06/2014 14:42, Coleen Phillimore wrote: On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong lin

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On 30/06/2014 14:42, Coleen Phillimore wrote: On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong links. They are: http://cr.openjdk.java.net/~coleenp/8047737_jdk/ http://cr.openjdk.java.net/~coleenp/8047737_hotsp

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong links. They are: http://cr.openjdk.java.net/~coleenp/8047737_jdk/ http://cr.openjdk.java.net/~coleenp/8047737_hotspot/ and the full version http://cr.openjdk.java

Re: Long valueOf instead of new Long

If a test run finishes fine, I'll push this version (no Unsafe*LongFieldFieldAccessorImpl.java files included): http://cr.openjdk.java.net/~prappo/8048267/webrev.04/ -Pavel On 30 Jun 2014, at 11:31, Andrej Golovnin wrote: > Hi Pavel, > > http://cr.openjdk.java.net/~prappo/8048267/webrev.03/s

Re: Long valueOf instead of new Long

Hi Pavel, http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeLongFieldAccessorImpl.java.sdiff.html > > http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeQualifiedLongFieldAccessorImpl.java.sdiff.html > > http://cr.openjdk

Re: Long valueOf instead of new Long

I've updated the webrev. It includes all the changes we've discussed so far plus these: http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/macosx/classes/sun/font/CStrike.java.sdiff.html http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/com/sun/tools/example/debug/tty/B

Re: Streams and Spliterator characteristics confusion

On Jun 28, 2014, at 5:40 PM, Kasper Nielsen wrote: > > > s.distinct().spliterator() -> Spliterator.DISTINCT = true > > but limiting the number of distinct elements makes the stream non distinct > > s.distinct().limit(10).spliterator() -> Spliterator.DISTINCT = false > > I don't observe that (se

Re: Long valueOf instead of new Long

Hi Otávio, About Andrej, is it not possible add two people in "Contributed-by:" tag? > Thanks! But it's not needed. It's your contribution. I just help to review the changes. Best regards, Andrej Golovnin

Re: RFR: 8047722: @since tag cleanup in corba

On 30/06/2014 02:30, Henry Jen wrote: Ping. : On 06/20/2014 02:28 PM, Henry Jen wrote: Hi, Please review a trivial webrev for jdk9/corba that do the same @since tag normalization as in jdk9/jdk. http://cr.openjdk.java.net/~henryjen/jdk9/8047722/0/webrev/ There are bunch of @since JDK 1.0 and

Re: RFR: 8047724: @since tag cleanup in jaxws

On 30/06/2014 02:30, Henry Jen wrote: Ping. Cheers, Henry Henry - the code in the jaxws repository is maintained upstream. If you change it in the jaxws repository then the changes will likely get overridden at the next sync-up. I'd suggest working with Miroslav (cc'ed) to get the changes pus