Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

2014-07-13 Thread David Holmes
On 12/07/2014 3:56 AM, Remi Forax wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the very same code as MethodHandleStatics.uncaughException several times an

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-13 Thread Jeff Hain
>Can you post the benchmark source? Before the source, here are the time ranges runs were stabilizing in for lucky executions (using 1.7 for compiler compliance level, and win7 / core i7) : | original | peter7   | peter7   | peter8   | peter8   | |  |  | no loo

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-13 Thread Peter Levart
On 07/13/2014 12:41 AM, Peter Levart wrote: On 07/12/2014 10:46 PM, Ivan Gerasimov wrote: Peter, seems you need to fix capacity(): int capacity = Integer.highestOneBit(expectedMaxSize + (expectedMaxSize << 1)); does not necessarily produces a negative number in the case of overflow. Good cat

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-13 Thread Peter Levart
On 07/13/2014 01:24 PM, Jeff Hain wrote: On 07/08/2014 10:07 PM, Martin Buchholz wrote: I updated my webrev and it is again "feature-complete". http://cr.openjdk.java.net/~martin/webrevs/openjdk9/IdentityHashMap-capacity/

Serializable lambda and bytecode rewriters

2014-07-13 Thread Remi Forax
Hi guys, there is, i think, a serious issue in the way the deserialization of lambda is done by javac (or ecj which uses the same scheme), exactly in the code of the generated method $deserializeLambda$. Bytecode rewriting tools like jarjar or proguard works by rewriting all reference to types

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-13 Thread Jeff Hain
On 07/08/2014 10:07 PM, Martin Buchholz wrote: > I updated my webrev and it is again "feature-complete". > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/IdentityHashMap-capacity/ > > (old webrev at > http://cr