Re: new StringBuilder(char)

2014-08-15 Thread Jeremy Manson
No love from core-libs-dev? It's backwards-incompatible, but in a way that would unbreak existing broken code. Might be a worthwhile cleanup. Jeremy On Fri, Aug 8, 2014 at 1:53 PM, Eddie Aftandilian wrote: > Hi all, > > We recently realized that calling new StringBuilder(char) does not do wh

Re: RFR: 8052403 java/util/logging/CheckZombieLockTest.java fails with NoSuchFileException

2014-08-15 Thread Mandy Chung
Looks good. Nit: adding a space between catch and ( would be good. Mandy On 8/13/2014 5:43 AM, Daniel Fuchs wrote: Please find below a fix for 8052403: java/util/logging/CheckZombieLockTest.java fails with NoSuchFileException https://bugs.openjdk.java.net/browse/JDK-8052403 The issu

About JDK-8042694

2014-08-15 Thread Harshad RJ
Hi, I hit this bug in my own application today: https://bugs.openjdk.java.net/browse/JDK-8042694 My app uses the h2 database which installs a shutdown hook. Works fine, but while running with JNLP, the shutdown hook thrown an exception, probably because the JAR gets closed too early. I can't fin

Re: RFR (XL) 8046070 - Class Data Sharing clean up and refactoring, round #2

2014-08-15 Thread Kim Barrett
On Aug 3, 2014, at 2:59 AM, Ioi Lam wrote: > > David, thanks for the comments. I will fix the code as you suggested. > >> 225 int index = 0; // Defined here for portability! Do not move >> >> ??? Do we have a C compiler that can't declare loop variables? > I probably had two loops using the "

Re: [8u40] RFR(M): 8050114, 8041972, 8006627

2014-08-15 Thread Claes Redestad
Hi, I want to request backports of 8050114 [1], 8041972 [2] and 8006627 [3] to 8u-dev. The three patches are modified to make the API changes of 8041972 non-public, but apply cleanly if pushed in the specified order. [1] Expose Integer/Long formatUnsigned methods internally https://bugs.openj

[7u-dev] Request for Approval and Review: 8017212: File.createTempFile requires unnecessary "read" permission

2014-08-15 Thread Ivan Gerasimov
Hello! I'd like to ask an approval to backport 8017212 into 7u-dev. The patch does not apply cleanly, however the required modifications are quite small. Nevertheless, I will need a peer review for this. The webrev for jdk7: http://cr.openjdk.java.net/~igerasim/8017212/0/webrev/ The differen

Re: Lightweight finalization for the JDK without any drawbacks was: Why is finalize wrong?

2014-08-15 Thread Doug Lea
Sorry for not answering this before you filed JDK-8055183. On 08/13/2014 07:12 AM, Jaroslav Tulach wrote: As far as I understand Andrew's inquiry, the problem is not (that much) related to finalizers, rather to question whether following method can ever finish or not: private void gcThis

Re: Summary of Lightweight finalization for the JDK without any drawbacks

2014-08-15 Thread Peter Levart
Hi Jaroslav, FWIW, I have experimented with adapting sun.misc.Cleaner for external use. For example, it could be used as a NetBeans provided API. The thread management is based on tracking of Cleaner (PhantomReference) objects. When 1st Cleaner object is added to a doubly-linked list, the thr

Re: Replace concat String to append in StringBuilder parameters

2014-08-15 Thread Otávio Gonçalves de Santana
Could anyone help me as sponsor, please? On Tue, Aug 12, 2014 at 8:01 PM, Otávio Gonçalves de Santana < otavioj...@java.net> wrote: > Thank you Roger. > Done > > https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_6.zip > > > On Tue, Aug 12, 2014 at 10:15 AM, roger riggs

Summary of Lightweight finalization for the JDK without any drawbacks

2014-08-15 Thread Jaroslav Tulach
Hi. I'd like to thank everyone in participating in our discussion about lightweight finalization and shaping and sharping my understanding of the problem. I believe the discussion has now slowed down and it is time for another summary. I have added one into the issue (while also changing its s