Re: RFR: 8049343: (tz) Support tzdata2014f

I think the long names of the Australia time zones should be revisited to be consistent with the abbreviation changes. The new abbreviations follow the S[tandard] and D[aylight saving] convention rather than the S[tandard] and S[ummer time] one. The long names, such as "Eastern Summer Time (Que

Re: RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

On 8/20/2014 6:39 PM, Amy Lu wrote: On 8/21/14, 8:54 AM, Mandy Chung wrote: On 8/20/2014 6:26 AM, Amy Lu wrote: Patch updated: http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.02/ test/java/lang/Double/ParseHexFloatingPoint.java No dependency on the new DoubleConsts. Previous de

Re: RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

On 8/21/14, 8:54 AM, Mandy Chung wrote: On 8/20/2014 6:26 AM, Amy Lu wrote: Patch updated: http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.02/ test/java/lang/Double/ParseHexFloatingPoint.java No dependency on the new DoubleConsts. Previous dependency on sun.misc.DoubleConsts have

Re: RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

On 8/20/2014 6:26 AM, Amy Lu wrote: Patch updated: http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.02/ test/java/lang/Double/ParseHexFloatingPoint.java test/java/lang/Double/ToHexString.java - they don't depend on DoubleConsts, do they? Otherwise, looks good. Mandy

Re: ByteBuffer.wrap(array).getInt(offset)

On 08/20/2014 04:10 PM, Florian Weimer wrote: > Is there already a way to compute the expression in the subject without > the ByteBuffer allocation? I saw quite a few equivalent formulations in > the OpenJDK sources, and perhaps it's time to add a standardized > solution. Isn't this really cal

Re: JDK 9 RFR of 8054720: Modifications of I/O methods for instrumentation purposes

Hi Brian, Looks fine, thanks for the cleanup. Roger On 8/20/2014 11:08 AM, Brian Burkhalter wrote: JDK 9 reviewers: I would like to reprise this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028181.html with an updated patch Issue: https://bugs.openjdk.java.net/

Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles

On 8/20/2014 2:03 AM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ Looks okay t

ByteBuffer.wrap(array).getInt(offset)

Is there already a way to compute the expression in the subject without the ByteBuffer allocation? I saw quite a few equivalent formulations in the OpenJDK sources, and perhaps it's time to add a standardized solution. Should this go into DataInputStream, or java.lang.Integer and friends? -

JDK 9 RFR of 8054720: Modifications of I/O methods for instrumentation purposes

JDK 9 reviewers: I would like to reprise this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028181.html with an updated patch Issue: https://bugs.openjdk.java.net/browse/JDK-8054720 Patch: http://cr.openjdk.java.net/~bpb/8054720/webrev.01/ This changes builds on all

RFR: 8049343: (tz) Support tzdata2014f

Hi, Please, review the tzdata2014f integration (with tzdata2014e related changes included too) [1] fix to JDK9: http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.01/ The tzdata2014f changes are extensive and relates mostly to timezone short names changes + "Asia/Srednekolymsk" time zone w

Re: RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

On 8/20/14, 1:51 AM, Joe Darcy wrote: On 08/19/2014 06:50 AM, Amy Lu wrote: On 8/19/14, 3:09 AM, Mandy Chung wrote: On 8/18/14 12:49 AM, Amy Lu wrote: There are jdk tests that have dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts. This fix is to remove above internal API dependenc

Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles

Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ Thanks, Jane On 19.08.2014 17:03, Evgeniya Stepanova wrote: Re-a

RFR 8u: JDK-8044629: (reflect) Constructor.getAnnotatedReceiverType() returns wrong value

Hi, On 17 jun 2014, at 18:52, Joel Borggrén-Franck wrote: > Hi, > > Can I get a review for this fix and javadoc clarification for > https://bugs.openjdk.java.net/browse/JDK-8044629 > > The problem is with potentially annotated receiver parameters, they only > exist for inner class constructo