Re: RFR: 8049343: (tz) Support tzdata2014g

2014-09-01 Thread Masayoshi Okutsu
Aleksej, I don't see the America/Grand_Turk change in webrev.04. I wonder if the webrev wasn't updated correctly. Thanks, Masayoshi On 9/1/2014 11:10 PM, Aleksej Efimov wrote: Masayoshi, I have addressed all your comments with proposed resolution. Thank you for such thorough analysis of th

Re: RFR: JDK-8056934: ZipInputStream does not correctly handle local header data descriptors with the optional signature missing

2014-09-01 Thread Xueming Shen
On 9/1/14 9:05 AM, Alan Bateman wrote: On 29/08/2014 20:12, Martin Buchholz wrote: Hi Xueming and Alan, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8056934 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/zip-DataDescriptorSignatureMissing/

Re: RFR: JDK-8056934: ZipInputStream does not correctly handle local header data descriptors with the optional signature missing

2014-09-01 Thread Xueming Shen
On 8/29/14 12:12 PM, Martin Buchholz wrote: Hi Xueming and Alan, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8056934 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/zip-DataDescriptorSignatureMissing/

Re: RFR: JDK-8056934: ZipInputStream does not correctly handle local header data descriptors with the optional signature missing

2014-09-01 Thread Alan Bateman
On 29/08/2014 20:12, Martin Buchholz wrote: Hi Xueming and Alan, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8056934 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/zip-DataDescriptorSignatureMissing/

RFR: 8049343: (tz) Support tzdata2014g

2014-09-01 Thread Aleksej Efimov
Masayoshi, I have addressed all your comments with proposed resolution. Thank you for such thorough analysis of this changes. Also the new tzdata is out (2014g) - I have updated the JBS bug by adding 2014g related change notes and renamed this bug appropriately + I'm renaming this thread. T

Re: [9] RFR (S): 8056926: Improve caching of GuardWithTest combinator

2014-09-01 Thread Vladimir Ivanov
FTR, selectAlternative intrinsic is there from the very beginning. Recent changes improved how intrinsics are represented on LF level + added a bunch of new intrinsics. Best regards, Vladimir Ivanov On 9/1/14, 2:49 PM, Paul Sandoz wrote: On Sep 1, 2014, at 12:29 PM, Vladimir Ivanov wrote:

Re: Process API Updates (JEP 102)

2014-09-01 Thread Ron Pressler
If the second process is indeed a JVM, is that any different from spawning a Java process with a shell-script exec (something that’s quite commonly done, I assume)? On Thursday, August 28, 2014 at 7:58 PM, roger riggs wrote: > Hi Ron, > > I have not looked at that idea closely but I would be

Re: [9] RFR (S): 8056926: Improve caching of GuardWithTest combinator

2014-09-01 Thread Paul Sandoz
On Sep 1, 2014, at 12:29 PM, Vladimir Ivanov wrote: > Thanks, Paul. > > There's no need to add @ForceInline on selectAlternative. > It is used only during LF interpretation. There's an intrinsic for GWT > combinator, which encodes it as a branch (see > InvokerBytecodeGenerator.emitSelectAlte

Re: [9] RFR (S): 8056926: Improve caching of GuardWithTest combinator

2014-09-01 Thread Vladimir Ivanov
Thanks, Paul. There's no need to add @ForceInline on selectAlternative. It is used only during LF interpretation. There's an intrinsic for GWT combinator, which encodes it as a branch (see InvokerBytecodeGenerator.emitSelectAlternative). Best regards, Vladimir Ivanov On 9/1/14, 1:48 PM, Paul

Re: [9] RFR (S): 8056926: Improve caching of GuardWithTest combinator

2014-09-01 Thread Paul Sandoz
On Aug 29, 2014, at 7:20 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8056926/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8056926 > > Cache GuardWithTest per erased to basic types signature. > > GWT shape is made friendly to sharing: > * GWT MH is implemented a

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-09-01 Thread Paul Sandoz
On Aug 29, 2014, at 5:56 PM, Martin Buchholz wrote: > Looks fine. Thanks Martin & Chris. > Instead of using Contributed-by: for Doug's work, you should make him the hg > "user", as is done in previous changesets. E.g. hg import has a --user flag. > Ok, i will do that. Paul.