The fix looks OK to me.
Thanks,
Masayoshi
On 9/2/2014 10:41 PM, Aleksej Efimov wrote:
Masayoshi,
Sorry for the confusion - for some reason (most probably this change
was added after webrev generation) I forgot to include it. Now it's in
place: http://cr.openjdk.java.net/~aefimov/8049343/9/web
Hi Roger
On Sep 3, 2014, at 3:20 PM, roger riggs wrote:
> Hi Lance,
>
> Looks fine.
>
Thank you.
> The commented out printlns in the BaseTest classes could be removed; looks
> like left over debugging info.
I can remove it it, I had left it there as a minor time saver in case I wanted
to use
Hi Lance,
Looks fine.
The commented out printlns in the BaseTest classes could be removed;
looks like left over debugging info.
Roger
On 9/3/2014 3:04 PM, Lance Andersen wrote:
HI,
Still looking for a reviewer for the testNG tests
Best,
Lance
On Aug 21, 2014, at 2:48 PM, Lance Andersen w
HI,
Still looking for a reviewer for the testNG tests
Best,
Lance
On Aug 21, 2014, at 2:48 PM, Lance Andersen wrote:
> Hi all,
>
> This is a request for review for
>
> This adds tests which exercise SQLPermissions for DriverManager and
> SyncFactory.
>
> The webrev can be found at
> http:/
2014/9/3 2:58 -0700, a...@redhat.com:
> ...
>
> As Jarolsav put it, "I don't think this is explainable to regular Java
> developers." As David Lloyd put it, "If you still think that finalize
> is a good idea, given that it's basically defective *and* there is
> almost always a better solution, th
>
>
>>> I meant cleaning up rather than managing per se. To make it clear:
>>>
>> finalization is no substitute for proper lifecycle - anything that has
>> open() should have a following up close(), otherwise it's a bug.
>> Finalization still helps as safenet vs leaving native resources totally
>>
Hi,
On 09/03/2014 12:48 PM, Stanimir Simeonoff wrote:
> Hi Andrew,
>
> On Wed, Sep 3, 2014 at 12:58 PM, Andrew Haley wrote:
>
>> On 03/09/14 01:15, Stanimir Simeonoff wrote:
>>
>>> Like David Lloyd mentioned finalize() can be invoked concurrently to
>>> some methods (if there is no reachability
On 03/09/2014 13:41, Peter Levart wrote:
DirectByteBuffers rely on Cleaner(s), which are PhanthomReferences and
are managed (invoked) by the ReferenceHandler thread directly.
Finalizers are just enqueued by ReferenceHandler thread, but they are
invoked by the special FinalizerThread. That's b
Peter,
Yes, it's a known problem [1].
There are other caches (in MethodTypeForm, for example), which shouldn't
retain their elements.
Best regards,
Vladimir Ivanov
[1] https://bugs.openjdk.java.net/browse/JDK-8057020
On 9/3/14, 3:43 PM, Peter Levart wrote:
Hi Vladimir,
I'm sure you and Joh
Peter,
Thanks for the feedback.
> In LambdaFormEditor, where Transform[] is promoted into
ConcurrentHashMap:
339 ConcurrentHashMap m =
new ConcurrentHashMap<>(MAX_CACHE_ARRAY_SIZE * 2);
340 for (Transform k : ta) {
341 if (k
On 09/03/2014 02:56 PM, David M. Lloyd wrote:
On 09/03/2014 06:48 AM, Stanimir Simeonoff wrote:
Hi Andrew,
On Wed, Sep 3, 2014 at 12:58 PM, Andrew Haley wrote:
On 03/09/14 01:15, Stanimir Simeonoff wrote:
Like David Lloyd mentioned finalize() can be invoked concurrently to
some methods (i
On 09/03/2014 06:48 AM, Stanimir Simeonoff wrote:
Hi Andrew,
On Wed, Sep 3, 2014 at 12:58 PM, Andrew Haley wrote:
On 03/09/14 01:15, Stanimir Simeonoff wrote:
Like David Lloyd mentioned finalize() can be invoked concurrently to
some methods (if there is no reachability to 'this'). OTOH I s
Hi Stanimir, Andrew,
On 09/03/2014 01:48 PM, Stanimir Simeonoff wrote:
Hi Andrew,
On Wed, Sep 3, 2014 at 12:58 PM, Andrew Haley wrote:
On 03/09/14 01:15, Stanimir Simeonoff wrote:
Like David Lloyd mentioned finalize() can be invoked concurrently to
some methods (if there is no reachabilit
Hi Andrew,
On Wed, Sep 3, 2014 at 12:58 PM, Andrew Haley wrote:
> On 03/09/14 01:15, Stanimir Simeonoff wrote:
>
> > Like David Lloyd mentioned finalize() can be invoked concurrently to
> > some methods (if there is no reachability to 'this'). OTOH I see
> > finalize useful for managing native
Hi Vladimir,
I'm sure you and John have thought about it through, but I'll ask
anyway. Are cached LambdaForms going to stay around forever? What about
using a WeakReference (LambdaFormEditor.Transform could
extend WeakReference). This way unused LambdaForms would get GCed.
Regards, Peter
On
On 09/02/2014 03:59 PM, Vladimir Ivanov wrote:
Webrev: http://cr.openjdk.java.net/~vlivanov/8057042/webrev.00
Best regards,
Vladimir Ivanov
Hi Vladimir,
In LambdaFormEditor, where Transform[] is promoted into
ConcurrentHashMap:
339 ConcurrentHashMap m = new
Concurrent
I'd like to port the zlib v1.2.8 libraries to JDK 7u. Currently, 7u uses
zlib v1.2.3 libraries. 8u20 was recently upgraded to 1.2.8. zlib fixes
since 1.2.3 can be found at
http://cr.openjdk.java.net/~coffeys/webrev.8044725.7u/webrev/raw_files/new/src/share/native/java/util/zip/zlib-1.2.8/ChangeL
On 03/09/14 01:15, Stanimir Simeonoff wrote:
> Like David Lloyd mentioned finalize() can be invoked concurrently to
> some methods (if there is no reachability to 'this'). OTOH I see
> finalize useful for managing native resources mostly and possibly
> stopping (signaling) threads left unmanaged.
18 matches
Mail list logo
