RFR 8057793 BigDecimal is no longer effectively immutable

Hi there, I came across a case in BigDecimal division where the dividend ends up getting mutated, which is rather strange for a seemingly immutable class! (It's a subset of the cases where the Burnikel-Ziegler algorithm is used, I haven't done the analysis to find out under which exact condi

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

Hi Andrej, Can you resend the latest patch attached to a mail to this list? cheers /Joel On 2014-08-29, Andrej Golovnin wrote: > Hi Joel, > > >> I have changed the test TestMethodReflectValueOf as you suggested and I > >> have changed the summary of both tests too. You will find the changes in

Re: [9] RFR (S) 8057656: Improve MethodType.isCastableTo() & MethodType.isConvertibleTo() checks

On Sep 5, 2014, at 6:42 PM, Vladimir Ivanov wrote: > >> http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057656 >>> >> >> 854 if (!canConvert(returnType(), newType.returnType())) >> 855 return false; >> 856 Clas

Re: [9] RFR (S) 8057656: Improve MethodType.isCastableTo() & MethodType.isConvertibleTo() checks

Thank you, Paul. Best regards, Vladimir Ivanov On 9/9/14, 2:05 PM, Paul Sandoz wrote: On Sep 5, 2014, at 6:42 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8057656 854 if (!canConvert(returnType(), new

Re: Optimization 2.0 for composing strings - Was: Replace concat String to append in StringBuilder parameters

Am 08.09.2014 um 20:53 schrieb Jonathan Gibbons: For example, in the first few lines of the patch, I found this: Do you see any semantics change here? diff -r dde9f5cfde5f src/share/classes/sun/tools/jconsole/inspector/XArrayDataViewer.java --- a/src/share/classes/sun/tools/jconsole/inspector

[9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8057922 Introduce more sharing on LambdaForm level by rewriting most of the MH combinators using LambdaFormEditor. The new code is guarded by USE_LAMBDA_FORM_EDITOR flag and turned off by default b

Re: Optimization 2.0 for composing strings - Was: Replace concat String to append in StringBuilder parameters

On 08.09.2014 22:53, Jonathan Gibbons wrote: Sergey, Many of the suggestions in the webrev change the semantics of the code, and so would not be appropriate for javac to perform automagically. It is changed but I guess it is safe otherwise this ccan be a problem in the fix, but the fix still u

Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

On Sep 5, 2014, at 12:12 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8057657 > - BoundMethodHandle 57 assert(speciesData() == speciesData(form)); I am missing some context here as to how that asser

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

On Sep 9, 2014, at 12:51 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 > https://bugs.openjdk.java.net/browse/JDK-8057922 > > Introduce more sharing on LambdaForm level by rewriting most of the MH > combinators using LambdaFormEditor. > > The new code is

Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8057657 - BoundMethodHandle 57 assert(speciesData() == speciesData(form)); I am missing some context here as to how that assert would pass for anything other than Species_L, namely for

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

Paul, thanks for review! Updated webrev in place. http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8057922 Introduce more sharing on LambdaForm level by rewriting most of the MH combinators using LambdaFormEditor. The new code is guarded by USE_

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

On Sep 9, 2014, at 3:39 PM, Vladimir Ivanov wrote: > Paul, thanks for review! > +1 Paul. > Updated webrev in place. > >>> http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 >>> https://bugs.openjdk.java.net/browse/JDK-8057922 >>> >>> Introduce more sharing on LambdaForm level by rewr

Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

+1 to both. On Sep 9, 2014, at 3:22 PM, Vladimir Ivanov wrote: >>> http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057657 >>> >> >> - BoundMethodHandle >> >> 57 assert(speciesData() == speciesData(form)); >> >> I am missing som

Re: RFR : 8044725 :Bug in zlib 1.2.5 prevents inflation of some gzipped files (zlib 1.2.8 port)

Thanks for review Sherman. I'll go ahead and push current changes. Not sure what to do with the zlib launcher reference. Most likely not needed but we can rip that code out under a new bug ID if necessary. regards, Sean. On 08/09/2014 18:34, Xueming Shen wrote: On 09/03/2014 03:05 AM, Seán Co

[9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Please review this fix in for wrong rounding-mode mode behavior of NumberFormat.format(double) in HALF_UP case. https://bugs.openjdk.java.net/browse/JDK-8039915 webrev: http://cr.openjdk.java.net/~olagneau/8039915/webrev.00 Bug came