Hi Fred,
Looks okay to me too. But I wouldn't be surprised if there is some test
somewhere that checks for things when PrintJVMWarnings is set :)
David
On 7/10/2014 12:32 AM, Frederic Parain wrote:
Thank you very much for catching the JVM_O_DELETE issue.
I moved the O_DELETE support into the
On 10/6/2014 4:35 AM, Ivan Gerasimov wrote:
Hello!
This is a 7u-only fix.
Some users complain about the ProxyGenerator not creating the
intermediate directories when asked to keep the generated files.
It throws an IO exception instead
The fix is essentially a part of JDK-8004260.
That was a
Thanks for tackling this difficult area!
Alan is the most qualified to review, but I'll throw in some comments.
The title of the bug in jira doesn't match the one in the webrev - they
should be the same.
I'm not sure, but it looks like getAppend is called even on non-Windows
platforms, but there
FWIW, I've verified the same byte codes on Oracle Java 7 and 8 on Windows 7
(all 64 bit).
Gary
On Mon, Sep 29, 2014 at 1:58 PM, Paul Benedict wrote:
> Bytecode output courtesy of Mikael Ståldal:
>
> With standard loop:
>
> private static boolean contains(org.apache.logging.log4j.Marker,
> org
It's important to note that our experiments show that the byte codes are
different.
Gary
On Mon, Sep 29, 2014 at 10:29 AM, Paul Benedict
wrote:
> Open JDKers, I am forwarding an email to get some clarification. It's been
> a common understanding that foreach should perform no differently than t
Thank you very much for catching the JVM_O_DELETE issue.
I moved the O_DELETE support into the ZipFile.c file
(code was the same for all non-Windows platforms) and
cleaned up the original code in HotSpot.
The new webrevs:
http://cr.openjdk.java.net/~fparain/805/jdk_v03/
http://cr.openjdk.jav
Hi,
On 19/08/14 16:00, Jason Mehrens wrote:
Stanimir,
Looks like the int overflow on the metered stream is an issue that hasn't been
tracked. The other issues have been reported under
https://bugs.openjdk.java.net/browse/JDK-6433253
and https://bugs.openjdk.java.net/browse/JDK-8028786
Ap
Hello!
This is a 7u-only fix.
Some users complain about the ProxyGenerator not creating the
intermediate directories when asked to keep the generated files.
It throws an IO exception instead
The fix is essentially a part of JDK-8004260.
That was a relatively big update, which required CCC, so
Hello everybody!
The append mode is emulated on Windows, therefore we have to keep a flag
indicating that.
With the current implementation, the FileDescriptor does not know if the
file were opened with O_APPEND, and the flag is maintained at the upper
level.
This can cause inconsistency, whe
