Thank you Mandy!
Seems like I managed to skip the mailing lists when sending the 3rd
version of the review.
Sorry about that.
Sincerely yours,
Ivan
On 09.10.2014 9:56, Mandy Chung wrote:
http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/
I reviewed v3 version. Looks good.
Mandy
http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/
I reviewed v3 version. Looks good.
Mandy
On 10/9/14, 1:23 PM, David Holmes wrote:
Hi Amy,
On 9/10/2014 3:15 PM, Amy Lu wrote:
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug:https://bugs.openjdk.java.net/b
Hi Amy,
On 9/10/2014 3:15 PM, Amy Lu wrote:
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug:https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjd
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug:https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
T
Thanks Mandy!
Nit: I suggest to remove the directory "a" at the beginning rather
than throwing a RuntimeException so that you can run the test multiple
times manually.
Yes, makes sense.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8059563/2/webrev/
Sincerely yours,
Ivan
On 10/7/2014 1:47 AM, Ivan Gerasimov wrote:
Thank you Mandy!
I've updated the webrev based on your suggestions.
The test is moved to test/sun/misc/ProxyGenerator/ directory.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8059563/1/webrev/
Thanks for updating the test. Nit:
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
On 10/8/2014 7:38 AM, Konstantin Shefov wrote:
Daniel,
Thanks for your comment
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
On 08.10.2014 20:47, Martin Buchholz wrote:
Seems OK to me, but I leave it to Alan.
Thank you Martin!
Seems OK to me, but I leave it to Alan.
On Tue, Oct 7, 2014 at 1:08 AM, Ivan Gerasimov
wrote:
> Thanks Martin for the comments!
>
> On 06.10.2014 21:22, Martin Buchholz wrote:
>
> Thanks for tackling this difficult area!
>
> Alan is the most qualified to review, but I'll throw in some comment
Hi Joe,
Thanks for the relevant feedback.
I am going to provide all these changes in a new webrev within a few hours.
Thanks,
Olivier.
On 07/10/2014 18:25, Joe Darcy wrote:
Hi Olivier,
Some rewording suggestions:
445 * @param alreadyRounded Boolean indicating if rounding up
already h
Hello,
Please review a fix for the issue:
8059753 [TEST_BUG] Test
java/security/Security/ClassLoaderDeadlock/Deadlock2.sh fails with exit
code 1
Test bug fix.
https://bugs.openjdk.java.net/browse/JDK-8059753
The webrev is: http://cr.openjdk.java.net/~kshefov/8059753/webrev.00/
Thanks
Pooja
Hi William,
On 07/10/2014 18:33, William Price wrote:
Please review this 2nd version of the fix taking into account your feedback.
I'm not recognized here as a reviewer, but the code looked OK to me and
it passed my patch test suite.
Thanks for letting me know. That provides additional confiden
Daniel,
Thanks for your comment
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
On 08.10.2014 17:25, Daniel Fuchs wrote:
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
but I believe you can do:
HotSpotDiagnosticMXBea
I have run the test with the latest JDK 9 nightly build from Jenkins
http://scaaa114.us.oracle.com:8080/job/jdk9-dev-test/ws/build/linux-x86_64-normal-server-release
I have tried with different -XX:ReservedCodeCacheSize values. I have
noticed that code cache consumption almost linearly depends
Konstantin,
What kind of testing have you done to verify the fix?
Best regards,
Vladimir Ivanov
On 10/8/14, 5:15 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
but I believe you can do:
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatform
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
On 08/10/14 08:26, Ivan Gerasimov wrote:
Hi Daniel!
Would it make sense to make the old constructor FileHandler(String,
*int*, int, boolean) call the new one, casting the limit to long?
Hi Ivan,
I was about to reply 'no' out of consistency with the other
constructors - which don't call each o
Hello,
Please, review the fix [1] for the 8046817 [2].
Problem: schemagen tool doesn't generate schema file for the enum types [3].
SchemaGenerator class gets a list of annotated elements and filters out
only the class variables, but annotation parser (AnnotationParser.java)
filters out the Cla
On 07/10/14 21:50, Jason Mehrens wrote:
Hi Daniel,
The only thing I noticed is a missing @since tag on the FileHandler.
Oops, thanks for catching that Jason.
-- daniel
Jason
Date: Tue, 7 Oct 2014 15:13:13 +0200
From: daniel.fu...@oracle.com
To:
21 matches
Mail list logo
