[7u-dev ONLY] RFR: [8057530] (process) Runtime.exec throws garbled message in jp locale

Hello everybody! This is a request for review of a fix which is applicable to 7u only. The issue has already been addressed in 8 and later releases. The fix is a combined backport of https://bugs.openjdk.java.net/browse/JDK-8016579 , which addresses the problem with the encoding in windows cons

Re: Precision for JDK-8060012 Class.isAnonymousClass() returns false when class major number is 48.

Hello, I don't know if IBM's implementation uses any VM hooks not found in OpenJDK. If their JDK only uses common reflection machinery, a patch for this functionality for OpenJDK would be welcome for evaluation. Cheers, -Joe On 10/14/2014 4:17 AM, Alexandre Bartel wrote: Hi, Regarding iss

Re: [PATCH] Return -1 after throwing internal error

Hi Xiaoguang, On 10/20/2014 6:31 PM, Xiaoguang Sun wrote: Hi All, I recently discovered some inconsistency in UnixOperatingSystem_md.c that do now return -1 after throwing internal error. It usually shouldn't be a problem, but making it more consistent to other code within the same file shouldn

[PATCH] Return -1 after throwing internal error

Hi All, I recently discovered some inconsistency in UnixOperatingSystem_md.c that do now return -1 after throwing internal error. It usually shouldn't be a problem, but making it more consistent to other code within the same file shouldn't be a bad idea. Xiaoguang exporting patch: # HG changeset

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Am 21.10.2014 um 01:02 schrieb Otávio Gonçalves de Santana: BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055723 WEBREV: http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ WEBREV: http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ I did not look through all sources. In

Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055723 WEBREV: http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ WEBREV: http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ -- Otávio Gonçalves de Santana blog: http://otaviosantana.blogspot.com.br/ twitter: http://twitt

Re: RFR JDK-6321472: Add CRC-32C API

Hi David, The intrinsic that can be implemented for CRC32C will probably be even faster as it can make use of the specific crc32c instruction instead of using carry less multiplication. It might not hurt to mock up a quick benchmark using the CRC32C instruction against jdk8’s java.util.zip.CR

Re: RFR 8023173: FileOutputStream(FileDescriptor) does not respect append flag on Windows

Looks fine. Thanks, Roger On 10/20/2014 4:25 PM, Ivan Gerasimov wrote: Thank you Roger! Yes, you're right. Please find the updated webrev here: http://cr.openjdk.java.net/~igerasim/8023173/2/webrev/ Sincerely yours, Ivan On 20.10.2014 17:20, roger riggs wrote: Hi Ivan, This webrev appear

Re: RFR 8023173: FileOutputStream(FileDescriptor) does not respect append flag on Windows

Thank you Roger! Yes, you're right. Please find the updated webrev here: http://cr.openjdk.java.net/~igerasim/8023173/2/webrev/ Sincerely yours, Ivan On 20.10.2014 17:20, roger riggs wrote: Hi Ivan, This webrev appears removes the ability to interpose on various method using byte-code inject

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

On 20/10/2014 20:11, roger riggs wrote: Hi, Updated with recommendations to make the code more readable and to use the more appropriate Integer.parseInt instead of valueOf. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376/ Issue: https://bugs.openjdk.java.net/browse/JDK-

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Hi, Updated with recommendations to make the code more readable and to use the more appropriate Integer.parseInt instead of valueOf. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376/ Issue: https://bugs.openjdk.java.net/browse/JDK-8048124 Roger On 10/20/2014 2:53 PM, A

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

On 20/10/2014 19:17, roger riggs wrote: Hi, Updated with recommendations. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376/ Issue: https://bugs.openjdk.java.net/browse/JDK-8048124 "<>" seems excessive when I think you only need ${java.home}/- but still better than all.

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Hi, A minor issue: there are quite a few instances of parsing integers via Integer.valueOf(String) instead just Integer.parseInt(String): HijrahChronology.java: 864 int year = Integer.valueOf(key); 972 months[i] = Integer.valueOf(numbers[i]); Those sh

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Hi, Updated with recommendations. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376/ Issue: https://bugs.openjdk.java.net/browse/JDK-8048124 Thanks, Roger On 10/20/2014 11:25 AM, Alan Bateman wrote: On 20/10/2014 16:11, roger riggs wrote: What permission would be needed

Precision for JDK-8060012 Class.isAnonymousClass() returns false when class major number is 48.

Hi, Regarding issue JDK-8060012 https://bugs.openjdk.java.net/browse/JDK-8060012 I have tried to run the code using the following IBM JVM: java version "1.7.0" Java(TM) SE Runtime Environment (build pxa6470_27-20131115_04) IBM J9 VM (build 2.7, JRE 1.7.0 Linux amd64-64 Compressed References 2013

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

On 20/10/2014 16:11, roger riggs wrote: What permission would be needed to read the resource? The limited doPrivileged should include the minimum permission. The resources will be be resources.jar so I think read access to that should be sufficient. If you run a small test with -Djava.security.

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Hi Alan, Thanks for the review... On 10/20/2014 11:07 AM, Alan Bateman wrote: On 20/10/2014 15:53, roger riggs wrote: Please review for JDK 9 only. To aid the modularization effort, the configuration of the Hijrah calendar should move the Hijrah calendar data to a resource. At this point,

Re: RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

On 20/10/2014 15:53, roger riggs wrote: Please review for JDK 9 only. To aid the modularization effort, the configuration of the Hijrah calendar should move the Hijrah calendar data to a resource. At this point, it does not look like there will be other Hijrah calendar variants; the function

RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Please review for JDK 9 only. To aid the modularization effort, the configuration of the Hijrah calendar should move the Hijrah calendar data to a resource. At this point, it does not look like there will be other Hijrah calendar variants; the function of calendar.properties to configure variant

Re: RFR 8023173: FileOutputStream(FileDescriptor) does not respect append flag on Windows

Hi Ivan, This webrev appears removes the ability to interpose on various method using byte-code injection. For example, FileOutputStream.write(byte). Do *not *replace delete the Java method calls that call native. It looks like an optimization but disables some functions that allow monitoring

Re: RFR 8023173: FileOutputStream(FileDescriptor) does not respect append flag on Windows

Thank you Alan for the review! On 17.10.2014 13:00, Alan Bateman wrote: On 06/10/2014 11:41, Ivan Gerasimov wrote: Hello everybody! The append mode is emulated on Windows, therefore we have to keep a flag indicating that. With the current implementation, the FileDescriptor does not know if

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Gently reminder On 17.10.2014 13:38, Konstantin Shefov wrote: Hi, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/ -Konstantin 16.10.2014 17:24, Igor Ignatyev пишет: Konstantin, I haven't looked at code religiously, so I wouldn't say that I have reviewed

Re: Lower overhead String encoding/decoding

On 19/10/2014 23:13, Richard Warburton wrote: Hi, Hi Richard, couple comments after a quick scan. Thanks for your comments - only just had a post Javaone chance to look at this stuff. I've pushed an update to: *http://cr.openjdk.java.net/~rwarburton/string-patch-webrev-7