RFR 8047962: XML test colocation: AuctionPortal test for bid.com

2014-10-31 Thread Tristan Yan
Hi Joe, Alan and all others Would you please help reviewing these tests? The intent is moving some JAXP tests from closed to open. The associated bug number is https://bugs.openjdk.java.net/browse/JDK-8047962 . These tests have been ran with and

Review request for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type

2014-10-31 Thread Eric McCorkle
Hello, Please review this patch which fixes issues that arise with getGenericParameterTypes() and getAnnotatedParameterTypes() when there are generic signatures and synthetic parameters. Please note that a complete fix is not possible for all cases. See discussion on https://bugs.openjdk.java.ne

Re: Review request: JDK-8062556: Add jdk tests for JDK-8058322 and JDK-8058313

2014-10-31 Thread Eric McCorkle
I went through and added comments in the binary data indicating where the MethodParameters attributes are, and a breakdown of their contents. I went ahead and did this for all the bad class files, not just the new ones. There is a larger picture here: there's an outstanding task I filed around th

Re: Losing features of JVM_Open, e.g. CLOEXEC

2014-10-31 Thread frederic parain
On 30/10/2014 19:42, Martin Buchholz wrote: Either the file descriptor leak issue is specific to the zip package and can be fixed locally. Or the issue impacts more native code and adding an infrastructure to libjava should be discussed. Quickly grepping the code, I found many naked calls to open

Re: RFR: 8061950: Class.getMethods() exhibits quadratic time complexity

2014-10-31 Thread Stanimir Simeonoff
Hi, Personally I have no objections to the latest webrev. > It looks like you are creating a more sophisticated data structure > with more garbage, which won't show up as much on our small-memory > benchmarks. Which is why I was expecting to have to write an adaptive > data structure that swit

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

2014-10-31 Thread Konstantin Shefov
Please, review a test bug fix. http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/ -Konstantin On 27.10.2014 13:16, Konstantin Shefov wrote: > Kindly reminder > > On 23.10.2014 19:04, Paul Sandoz wrote: >> On Oct 23, 2014, at 1:25 PM, Konstantin Shefov >> wrote: >>> Gently reminder >>> >>> O