Re: RFR: 8067377: My hobby: caning, then then canning, the the can-can

wow, looks like "the the"'s quite popular. I found 37 in jaxp as well :-) Joe On 12/12/2014 4:26 PM, Lance Andersen wrote: looks good Martin... On Dec 12, 2014, at 4:34 PM, Martin Buchholz wrote: Hi Joe, Lance, Roger, Fix ALL the stutters! https://bugs.openjdk.java.net/browse/JDK-8067377 h

Re: RFR: 8067377: My hobby: caning, then then canning, the the can-can

looks good Martin... On Dec 12, 2014, at 4:34 PM, Martin Buchholz wrote: > Hi Joe, Lance, Roger, > > Fix ALL the stutters! > > https://bugs.openjdk.java.net/browse/JDK-8067377 > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/double-trouble/ Lance Andersen| Principal Member of Technical

Re: RFR: 8067377: My hobby: caning, then then canning, the the can-can

On 12/12/14 1:34 PM, Martin Buchholz wrote: Hi Joe, Lance, Roger, Fix ALL the stutters! https://bugs.openjdk.java.net/browse/JDK-8067377 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/double-trouble/ Looks fine with me. My eyes were getting very tired half way through spotting the "doub

Re: RFR: 8067377: My hobby: caning, then then canning, the the can-can

Hi Martin, Thanks for the sharp eyes and speech lesson. Looks fine to me. Roger On 12/12/2014 4:34 PM, Martin Buchholz wrote: Hi Joe, Lance, Roger, Fix ALL the stutters! https://bugs.openjdk.java.net/browse/JDK-8067377 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/double-trouble/

RFR: 8067377: My hobby: caning, then then canning, the the can-can

Hi Joe, Lance, Roger, Fix ALL the stutters! https://bugs.openjdk.java.net/browse/JDK-8067377 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/double-trouble/

Re: RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

Hi, Not sure, but it used to be ok to refer to a method without the (). Now the name on the html target has a '--' suffix so a bare link reference does not work. Roger On 12/12/2014 4:07 PM, Martin Buchholz wrote: +1 (how did this not get fixed in previous cleanups!?) On Fri, Dec 12, 2014 a

Re: RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

Oh I think I know. #redirectErrorStream is ambiguous, because the method name is overloaded. In the distant past, it would choose one of the methods to target, probably the first, but now you need to be explicit? It might be very slightly better to refer to the setter * If the {@link #redirectE

Re: RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

+1 (how did this not get fixed in previous cleanups!?) On Fri, Dec 12, 2014 at 11:53 AM, roger riggs wrote: > Please review this fix for bad link in javadoc: > > jdk/src/java.base/share/classes/java/lang/ProcessBuilder.java > @@ -748,11 +748,11 @@ > * Process#getErrorStream()}. > * If

RFR: 8042418: Remove JVM_FindClassFromClassLoader

Summary: The function has been replaced so is no longer used. This function was replaced with a better FindClassFromCaller function. The compatibility request (CCC) was approved. open webrev at http://cr.openjdk.java.net/~coleenp/8042418_jdk/ open webrev at http://cr.openjdk.java.net/~coleen

RFR(s): 8035117: TEST_BUG: java/rmi/server/RemoteObject/notExtending/NotExtending.java can fail with timeout

Hi all, Please review this small fix and cleanup to this test. The old version would force garbage collection of an unreferenced RMI object by allocating lots and lots of memory until OOME is received, which takes a long time and could cause a timeout. The better approach is simply to unexport

Re: RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

looks ok Roger On Dec 12, 2014, at 2:53 PM, roger riggs wrote: > Please review this fix for bad link in javadoc: > > jdk/src/java.base/share/classes/java/lang/ProcessBuilder.java > @@ -748,11 +748,11 @@ > * Process#getErrorStream()}. > * If the destination is set to any other value, th

RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

Please review this fix for bad link in javadoc: jdk/src/java.base/share/classes/java/lang/ProcessBuilder.java @@ -748,11 +748,11 @@ * Process#getErrorStream()}. * If the destination is set to any other value, then * {@link Process#getErrorStream()} will return a * null inp

Review request: JDK-8067360: verify-modules target was dropped in jdk9 b41

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8067360/webrev.00/ This patch adds back the verify-modules target to the dependences of the images target that got dropped in the merge and hides a bug in jdeps -Xverify:access. Erik - I notice make/Javadoc.gmk that sets -bootclasspath

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

Thanks Joe answering this. Updated webrev by changing jaxp_test to jaxp_all, Also correct “Jaxp" as “JAXP”. http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.01/ http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.02/

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

On 12/12/2014 2:45 AM, Alan Bateman wrote: On 11/12/2014 21:10, Tristan Yan wrote: Thanks Alan and Joe I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit. http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

> On 12 Dec 2014, at 15:51, Alan Bateman wrote: > >> On 12/12/2014 15:40, Pavel Rappo wrote: >> Hi everyone, >> >> Could you please review my change for JDK-8066642? >> >> http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ >> >> -Pavel > This looks okay but I just wonder if we have any tes

RFR 9: 8044841 java/lang/Runtime/exec/SleepyCat.java Exception: Read from closed pipe hangs

Please review this addition of diagnostic output to an intermittently failing Runtime.exec test. The Solaris implementation of ProcessBuilder.start uses posix_spawn and a trampoline technique that invokes a small spawnhelper executable which in turn forks the new executable. The test has been

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

On 12/12/14 15:40, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ The first change, to remove SocketSecurityException seems benign. SocketSecurityException is a subclass of ExportException, so Communic

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

On 12/12/2014 15:40, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ -Pavel This looks okay but I just wonder if we have any tests that check the for specific NamingExceptions that would help tell us if

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

+1 On Dec 12, 2014, at 10:40 AM, Pavel Rappo wrote: > Hi everyone, > > Could you please review my change for JDK-8066642? > > http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ > > -Pavel > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1

RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ -Pavel

Re: RFR 8061442: Update jdk/tools tests to remove check for the "jre" directory

On 12/12/2014 06:12, FELIX YANG wrote: Hi all, please review the fix for jdk/test/tools. It cleans up checking for 'jre' directory, which has been removed during Jigsaw M2. Bug: https://bugs.openjdk.java.net/browse/JDK-8061442 Webrev: http://cr.openjdk.java.net/~xiaofeya/8061442/w

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

On 11/12/2014 21:10, Tristan Yan wrote: Thanks Alan and Joe I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit. http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/ http://cr.ope

Re: RFR 8066085: Need a sanity test for rmic -iiop

On 12/11/14 8:41 PM, FELIX YANG wrote: Hi all, please review the fix to add a sanity checking for rmic -iiop compiling. Bug: https://bugs.openjdk.java.net/browse/JDK-8066085 Webrev: http://cr.openjdk.java.net/~xiaofeya/8066085/webrev.00/ Hi Felix, Thanks for picking up t