Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

I'm agreeing with what you say here, but t0 and t1 are symmetrical, so still cannot understand why you want to switch them in the javadoc. On Fri, Jan 23, 2015 at 4:27 PM, Brian Burkhalter < [email protected]> wrote: > > On Jan 23, 2015, at 2:16 PM, Martin Buchholz wrote: > > I don't g

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

On Jan 23, 2015, at 2:16 PM, Martin Buchholz wrote: > I don't get it. t0 and t1 are supposed to be symmetrical (perhaps obtained > in different threads). > Switching them around doesn't change anything. And correctness in the face > of two's complement numerical overflow is the whole point o

RFR 9: 8068578: test/java/io/Serializable/subclassGC/SubclassGC.java assumes app class loader is a URLClassLoader

Hi, Please review this test case update. Bug: https://bugs.openjdk.java.net/browse/JDK-8068578 Webrev: http://cr.openjdk.java.net/~bchristi/8068578/webrev.0/ The test relies on creating a new URLClassLoader and using it to load a subclass of ObjectOutputStream. The system classloader is cast

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

On Fri, Jan 23, 2015 at 1:20 PM, Brian Burkhalter < [email protected]> wrote: > On Jan 23, 2015, at 1:10 PM, Martin Buchholz wrote: > > --- > > I don't see why switching t0 and t1 makes things more readable. > > > It’s about accuracy. The previous version is incorrect in the overflow >

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

[+javadoc-dev] On Fri, Jan 23, 2015 at 1:20 PM, Brian Burkhalter < [email protected]> wrote: > On Jan 23, 2015, at 1:10 PM, Martin Buchholz wrote: > > We have struggled for years with formatting for code samples. If you want > to change it, get authoritative statement on how to do it

Re: RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

On 01/23/2015 12:51 PM, Paul Sandoz wrote: No, because a supplier of a spliterator is used (as is the case for the CharSequence implementations): return StreamSupport.intStream( () -> new String.IntCharArraySpliterator(value, 0, count, 0), Spliterator.ORDERED | Spliterator.S

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

On Jan 23, 2015, at 1:10 PM, Martin Buchholz wrote: > We have struggled for years with formatting for code samples. If you want to > change it, get authoritative statement on how to do it with latest javadoc, > publish it somewhere, and change it everywhere. Putting the } on a > line by itse

Re: RFR: 8046817: JDK 8 schemagen tool does not generate xsd files for enum types

Looks good, Aleksej. Thanks, Joe On 1/19/2015 8:48 AM, Aleksej Efimov wrote: Hi, Returning back to this issue: The fix will be integrated soon to standalone JAXB project. Local build of standalone JAXB succeeded. No issues with jaxb tests were observed with applied fix. Can I ask reviewers t

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

We have struggled for years with formatting for code samples. If you want to change it, get authoritative statement on how to do it with latest javadoc, publish it somewhere, and change it everywhere. Putting the } on a line by itself did not produce the most readable output IIRC. --- I don't s

[9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8069269 Patch: http://cr.openjdk.java.net/~bpb/8069269/webrev.00/ The effective change is line 391 -> 393; the remainder is reformatting. Consider these hypothetical nanoTime values: long t0 = Long.MAX_

Re: RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

On Jan 23, 2015, at 8:26 PM, Xueming Shen wrote: > The webrev looks good. > Thanks. > However I have a question regarding the spec of > CharsSequence.chars/codePoints(). It says > * > * If the sequence is mutated while the stream is being read, the > * result is undefined. > >

Re: RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

The webrev looks good. However I have a question regarding the spec of CharsSequence.chars/codePoints(). It says * * If the sequence is mutated while the stream is being read, the * result is undefined. But it looks like ABS.chars/codePoints() "predefine/fix" the size of the res

Re: RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

Hi Chris, I considered updating BigFork but would have had to update the stacktrace lines numbers, etc. And I think it will be recognized that it is a dated reference. Roger On 1/23/2015 2:03 PM, Chris Hegarty wrote: On 23 Jan 2015, at 18:57, Roger Riggs wrote: Hi Peter, Chris, Thanks fo

Re: RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

On Jan 23, 2015, at 6:22 PM, Xueming Shen wrote: > On 01/23/2015 09:00 AM, Paul Sandoz wrote: >> Hi, >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071477-String-spliterators/webrev/ >> >> This patch implements better spliterators for >> String/Buffer/Builder.chars/codePoints than those

Re: [9] RFR of 6880737: (fs) FileLock constructors don't throw NPE if the channel argument is null

On Jan 16, 2015, at 11:33 PM, Alan Bateman wrote: > The change to the javadoc isn't strictly required as there is a general > statement in the package description that NPE be thrown when methods or > constructors are called with null. Thanks, I missed that. > So the implementation should thro

Re: RFR (JAXP): 8054196: XPath: support any type

Looks good Joe, ship it :-) On Jan 22, 2015, at 6:04 PM, huizhe wang wrote: > Thanks Lance. > > On 1/22/2015 9:11 AM, Lance Andersen wrote: >> Hi Joe, >> >> I just looked at the changes below, >> >> I looked at the changes below… see minor comments >> On Jan 22, 2015, at 12:18 AM, huizhe wan

Re: RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

On 23 Jan 2015, at 18:57, Roger Riggs wrote: > Hi Peter, Chris, > > Thanks for the reviews. > > I found one more reference to UNIXProcess in a comment in childproc.h Ah, good find. Another reference in comments in BigFork.java, but probably doesn’t make sense to change at this point. -Chri

Re: RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

Hi Peter, Chris, Thanks for the reviews. I found one more reference to UNIXProcess in a comment in childproc.h and will wait for a jprt run to finish. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-unixprocess-rename-8071481/ Thanks, Roger On 1/23/2015 12:53 PM, Chris Hegarty wrote: On 2

Re: RFR: 8062923: XSL: Run-time internal error in 'substring()'

Hi Aleksej, Looks good. There is a minor format issue at line 299. Note that, for JDK 9, we now have functional/unit tests under jaxp/test. This test would fix in javax/xml/jaxp/unittest/javax/xml/transform. For test format, please take a look at a functional test (javax/xml/jaxp/functional)

Re: RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

On 01/23/2015 09:00 AM, Paul Sandoz wrote: Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071477-String-spliterators/webrev/ This patch implements better spliterators for String/Buffer/Builder.chars/codePoints than those provided by the default methods on CharSequence. The test java/lang/

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

On Jan 23, 2015, at 8:00 AM, Vladimir Ivanov wrote: > > Good idea, Peter! +1 > Updated version: > http://cr.openjdk.java.net/~vlivanov/8069591/webrev.02/ > Yes, that's good, and you can count me as a reviewer. — John P.S. One could

Re: RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

On 23 Jan 2015, at 17:18, Peter Levart wrote: > Hi Roger, > > Nice move/rename/merge. > > I compared old UNIXProcess.java with new ProcessImpl.java using KDiff3 and > they match perfectly as well as including the old ProcessImpl.java code. Nice. I did the same just to see it for myself. The

Re: RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

Hi Roger, Nice move/rename/merge. I compared old UNIXProcess.java with new ProcessImpl.java using KDiff3 and they match perfectly as well as including the old ProcessImpl.java code. Regards, Peter On 01/23/2015 05:11 PM, Roger Riggs wrote: Please review this merge of UNIXProcess.java with P

RFR 8071477: Better Spliterator implementations for String.chars() and String.codePoints()

Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071477-String-spliterators/webrev/ This patch implements better spliterators for String/Buffer/Builder.chars/codePoints than those provided by the default methods on CharSequence. The test java/lang/CharSequence/DefaultTest.java is removed as i

RFR 9: 8071481: (Process) Merge UNIXProcess.java into ProcessImpl.java

Please review this merge of UNIXProcess.java with ProcessImpl.java. For Unix variants of Process, the implementation is split between src/java.base/unix/classes/java/lang/ProcessImpl.java and UNIXProcess.java. ProcessImpl.java contains only static methods and delegates to UNIXProcess.java. Merg

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

Good idea, Peter! Updated version: http://cr.openjdk.java.net/~vlivanov/8069591/webrev.02/ Best regards, Vladimir Ivanov On 1/23/15 5:38 PM, Peter Levart wrote: On 01/23/2015 12:30 AM, John Rose wrote: On Jan 22, 2015, at 9:56 AM, Vladimir Ivanov wrote: Remi, John, thanks for review! Updat

Re: RFR: JDK-8055190: Cleanup include and exclude of core-libs native libraries after source code restructure

On 2015-01-23 15:41, Alan Bateman wrote: On 23/01/2015 14:35, Erik Joelsson wrote: Hello, Please review this build patch, cleaning up some in the native compilation of some core libraries. After the source code restructure into modules, the need for explicit exclude and include of source fil

Re: RFR: JDK-8055190: Cleanup include and exclude of core-libs native libraries after source code restructure

On 23/01/2015 14:35, Erik Joelsson wrote: Hello, Please review this build patch, cleaning up some in the native compilation of some core libraries. After the source code restructure into modules, the need for explicit exclude and include of source files was reduced. This patch moves some OS s

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

On 01/23/2015 12:30 AM, John Rose wrote: On Jan 22, 2015, at 9:56 AM, Vladimir Ivanov wrote: Remi, John, thanks for review! Updated webrev: http://cr.openjdk.java.net/~vlivanov/8069591/webrev.01/ This time I did additional testing (COMPILE_THRESHOLD > 0) and spotted a problem with MethodHan

Re: Explicit Serialization API and Security

I have attempted to capture some of the ideas that we have discussed so far. https://bugs.openjdk.java.net/browse/JDK-8071471 -Chris. On 21/01/15 21:43, David M. Lloyd wrote: At some point, the responsibility *must* fall on the author of the serializable class in question to avoid constructs

RFR: JDK-8055190: Cleanup include and exclude of core-libs native libraries after source code restructure

Hello, Please review this build patch, cleaning up some in the native compilation of some core libraries. After the source code restructure into modules, the need for explicit exclude and include of source files was reduced. This patch moves some OS specific files to OS specific source dirs a

Re: [8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

Konstantin, can you hold off pushing this fix to jdk8u for the moment ? It's a P4 and could have behavioural consequences (something we try and avoid in update releases). I see JDK-8071458 was logged to track IPv6 scope specifications. Let's see how this soaks into JDK 9 over coming days and

[8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

Hello, Please approve the direct backport of the bug fix to 8u-dev Patch applies cleanly to JDK 8u. The bug:https://bugs.openjdk.java.net/browse/JDK-6933879 The webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.01/ JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/801eb37fc

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 23/01/2015 10:28, Chris Hegarty wrote: On 21.01.2015 16:06, Konstantin Shefov wrote: Hi, Chris I have done a pre-integration testing for this fix on Linux, Windows, Mac and Solaris x64 and sparc. I have run all regression tests for core libraries, and no new failures appeared. Can I push th

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 21.01.2015 16:06, Konstantin Shefov wrote: Hi, Chris I have done a pre-integration testing for this fix on Linux, Windows, Mac and Solaris x64 and sparc. I have run all regression tests for core libraries, and no new failures appeared. Can I push this change now or should I wait for an appro

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

Hi Max, Please see inline. On 01/23/2015 05:18 AM, Wang Weijun wrote: I have updated the webrev, updateJar() method does the following: >- creates a new jar file (destJarFilename) >- puts files which are specified in files parameter to destJarFilename >- copies files from srcJarFilename to dest

Re: RFR 8067748: (process) Child is terminated when parent's console is closed [win]

Thank you Alan! On 22.01.2015 21:12, Alan Bateman wrote: On 22/01/2015 14:37, Ivan Gerasimov wrote: : It's hard to create a test, which involves closing the console window and manipulating the detached child application. Would you please help review the fix? BUGURL: https://bugs.openjdk.jav