Re: 8026049: (bf) Intrinsify ByteBuffer.put{Int, Double, Float, ...} methods

2015-03-14 Thread Remi Forax
Hi Andrew, Looks good to me. RĂ©mi On 03/13/2015 07:47 PM, Andrew Haley wrote: I've tried to address all the points that have been made. I haven't changed the way the sub-words are read and written because the code I'm seeing is fairly nearly optimal right now and anything more complex runs the

Re: [9] RFR of 8073214: javadoc of Properties methods should specify NullPointerExceptions

2015-03-14 Thread Alan Bateman
On 13/03/2015 20:40, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8073214 Patch: http://cr.openjdk.java.net/~bpb/8073214/webrev.00/ Lines 316 and 342 in Properties.java are not strictly necessary but make it a little more fail-fas