Re: RFR 9: 8077350 Process API Updates Implementation Review

2015-04-10 Thread Martin Buchholz
On Fri, Apr 10, 2015 at 10:37 PM, Martin Buchholz wrote: > > +} else if (siginfo.si_code == CLD_KILLED || siginfo.si_code == > CLD_DUMPED) { > > Using siginfo probably won't work under load because multiple signals > arriving at the same time are coalesced into one, at least on Linux. >

Re: RFR 9: 8077350 Process API Updates Implementation Review

2015-04-10 Thread Martin Buchholz
Thanks for the huge effort. I did a superficial review and it seems pretty good. Of course, changing the Process good is high risk and some things will probably need fixup later. On Unix, you seem to be identifying ProcessHandles by their pid. What are you going to do about the problem of misid

Re: [9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

2015-04-10 Thread Brian Burkhalter
On Apr 4, 2015, at 12:53 PM, Alan Bateman wrote: > On 24/03/2015 19:20, Brian Burkhalter wrote: >> Please review at your convenience. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8075156 >> Patch: http://cr.openjdk.java.net/~bpb/8075156/webrev.00/ >> >> This is a sequel to

Re: [9] Review Request: 8076264 [macosx] Launching app on MacOSX requires enclosing class

2015-04-10 Thread Martin Buchholz
On Fri, Apr 10, 2015 at 12:08 PM, Kumar Srinivasan < kumar.x.sriniva...@oracle.com> wrote: > > On 4/10/2015 11:57 AM, Martin Buchholz wrote: > > > > On Fri, Apr 10, 2015 at 10:33 AM, Kumar Srinivasan < > kumar.x.sriniva...@oracle.com> wrote: >> >> I don't get it. Either providing this informati