Thanks for your clarifications Roger. I'm very much in favor of your
suggestion for naming the method "supportsNormalTermination".
Kind regards,
Anthony
On 11/04/2015 20:35, Roger Riggs wrote:
Hi Anthony,
Thanks for the review and comments.
On 4/11/2015 5:00 AM, Anthony Vanelverdinghe wrote
Hi Thomas,
Thanks for the comments.
On 4/11/2015 8:31 AM, Thomas Stüfe wrote:
Hi Roger,
I have a question about getChildren() and getAllChildren().
I assume the point of those functions is to implement point 4 of JEP
102 ("The ability to deal with process trees, in particular some means
to
Hi Anthony,
Thanks for the review and comments.
On 4/11/2015 5:00 AM, Anthony Vanelverdinghe wrote:
Hi Roger
In my opinion, the method "supportsDestroyForcibly" is unintuitive,
for the following 2 reasons:
- it's named "supportsXxx", where Xxx is the name of a method in the
same class. So
Hi Martin,
Thanks for the review.
On 4/11/2015 1:37 AM, Martin Buchholz wrote:
Thanks for the huge effort. I did a superficial review and it seems
pretty good. Of course, changing the Process good is high risk and
some things will probably need fixup later.
On Unix, you seem to be identify
p.s.
Note that using allChildren() to kill process trees has a second problem,
even without PID recycling: the PID list it returns may not be complete
once you come around to use it.
Imagine a process tree with some runaway process forking below you
constantly. You want to kill the complete proce
Hi Roger,
I have a question about getChildren() and getAllChildren().
I assume the point of those functions is to implement point 4 of JEP 102
("The ability to deal with process trees, in particular some means to
destroy a process tree."), by returning a collection of PIDs which are the
children
Hi Roger
In my opinion, the method "supportsDestroyForcibly" is unintuitive, for
the following 2 reasons:
- it's named "supportsXxx", where Xxx is the name of a method in the
same class. So as a user of this API, I would intuitively assume that
"supportsDestroyForcibly" is related to "destro