> Hi Srikanth,
>
> I would mention that Object is not annotated in the following statements:
> - AnnotatedWildcardType.getAnnotatedUpperBounds(): "Note that if no
> upper bound is explicitly declared, the upper bound is Object."
> - AnnotatedTypeVariable.getAnnotatedBounds(): "Note that if no boun
Given that the zip initialization is tricky, I agree that it's risky to
delay the loading of zip library for JDK 8u.
Volker - thanks for the instruction to reproduce ESE. Does your patch
address the ServiceLoader issue? Charset calling
sun.misc.Launcher.getBootstrapClassPath would still caus
On 06/09/2015 11:03 AM, Mandy Chung wrote:
Does my patch work fine on 8u?If it works fine, I prefer to get that simple
fix in 8u and take the time to have a better fix in 9 (jdk9 is still under
development and I have assumed that it's not a show stopper to you. Let me
know if it blocks yo
Does my patch work fine on 8u?If it works fine, I prefer to get that
simple fix in 8u and take the time to have a better fix in 9 (jdk9 is
still under development and I have assumed that it's not a show stopper
to you. Let me know if it blocks you).
A question to Sherman - do we have adeq
Hi Mandy,
thanks for looking into this.
Uunfortunately your fix only helps to fix "java -version" :(
Running even a minimal HelloWorld will still fail with the following
stack trace which is still caused by the same EmptyStackException:
Error: A JNI error has occurred, please check your installa
On 6/9/2015 11:47 PM, Xuelei Fan wrote:
> On 6/9/2015 11:31 PM, Konstantin Shefov wrote:
>> Xuelei, thanks for reviewing
>>
>> typo is corrected:
>> http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/
>>
> Why there are old "UnSupportedCiphersTest.java" files? If you have not
> committed the ch
On 6/9/2015 11:31 PM, Konstantin Shefov wrote:
> Xuelei, thanks for reviewing
>
> typo is corrected:
> http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/
>
Why there are old "UnSupportedCiphersTest.java" files? If you have not
committed the changeset, you can "hg forget" to undo a previous "
Xuelei, thanks for reviewing
typo is corrected:
http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/
-Konstantin
On 06/09/2015 06:07 PM, Xuelei Fan wrote:
On 6/9/2015 10:57 PM, Xuelei Fan wrote:
Looks fine to me. Nice port to TLS protocols.
A very minior comment about the class name.
TLSU
On 6/9/2015 10:57 PM, Xuelei Fan wrote:
> Looks fine to me. Nice port to TLS protocols.
>
> A very minior comment about the class name.
> TLSUnSupportedCiphersTest.java:
> replease "UnSupported" with "Unsupported".
>
typo: replace "UnSupported" with "Unsupported".
> Thanks,
> Xuelei
>
> On 6/8
Looks fine to me. Nice port to TLS protocols.
A very minior comment about the class name.
TLSUnSupportedCiphersTest.java:
replease "UnSupported" with "Unsupported".
Thanks,
Xuelei
On 6/8/2015 11:04 PM, Konstantin Shefov wrote:
> Hello,
>
> Please review distribution of some DTLS feature tests
On 6/8/2015 9:57 PM, Jan Lahoda wrote:
On 9.6.2015 01:31, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
langtools/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
old L171: case "1.9":
Here's an updated webrev, which fixes the typos that were pointed out by
reviewers:
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.02/
And here's a (much simpler) delta webrev which shows just these changes:
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-
On 2015-06-09 15:26, Claes Redestad wrote:
On 2015-06-09 15:12, Magnus Ihse Bursie wrote:
langtools/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
old L171: case "1.9":
new L171: case "9":
Should this logic support both versi
On 2015-06-09 15:12, Magnus Ihse Bursie wrote:
langtools/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
old L171: case "1.9":
new L171: case "9":
Should this logic support both versions? Will dropping
"1.9" here preven
On 6/9/15 7:12 AM, Magnus Ihse Bursie wrote:
Hi Daniel,
Thank you for your thorough review!
This was my (failing) attempt at a "fast pass" review... :-)
On 2015-06-09 01:31, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
Gener
There is one more bug associated with this problem:
https://bugs.openjdk.java.net/browse/JDK-8067005
I can change all 4 tests.
Your idea sounds good, because we may expect more iterations to run
before code cache overflows.
-Konstantin
On 06/09/2015 01:28 PM, Vladimir Ivanov wrote:
Konstant
Hi Daniel,
Thank you for your thorough review!
On 2015-06-09 01:31, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
General comment: Not all copyright years were updated.
General comment: It looks like support for the 'patch' value i
Konstantin, thanks for figuring that out.
I had a private discussion with Igor and we agreed that catching
"expected" exceptions (NSME and VME) is more robust than hand tuning
test limits to particular configurations.
The idea is to gracefully finish the test once code cache is full,
instead
HI Stefan,
On Jun 7, 2015, at 10:07 PM, Stefan Zobel wrote:
> I'm still trying to wrap my head around the test logic for the (par & !ord)
> && (op == WhileOp.Drop) case
> in the whileResultAsserter() method in WhileOpTest.
>
> Wouldn't it be possible that, for an unordered parallel stream, drop
19 matches
Mail list logo
