Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

Thank you Paul for your review! On 13.07.2015 12:57, Paul Sandoz wrote: On Jul 12, 2015, at 6:32 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Hello! There's a minor issue in the current implementation of Pattern.quote() with possible numeric overflow when calculating initial capacity

Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

On Jul 12, 2015, at 6:32 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Hello! There's a minor issue in the current implementation of Pattern.quote() with possible numeric overflow when calculating initial capacity of StringBuilder. With the fix, some slight optimizations were done

Re: Speed optimization of Spliterators.spliteratorUnknownSize for parallel case

Hi Tagir, Thanks for looking at this. Judging by the results i am guessing your measurements were performed on a 4-core system. My initial inclination for these scenarios is it is likely better for the developer to split the execution in two parts. The first part, low N and low Q, is to

RFR 8131052 Documentation of AbstractSpliterator refers to forEach rather than forEachRemaining

Hi Stefan, thanks. See below for a patch to the documentation of all abstract spliterators. Paul. diff -r a3175de2e354 src/java.base/share/classes/java/util/Spliterators.java --- a/src/java.base/share/classes/java/util/Spliterators.java Tue Jun 09 07:10:03 2015 +0100 +++

What happend to: '(Review ID: 9055455) - RFE: Intristics for asin, acos'

Hi all, I would like to know what happened to '(Review ID: 9055455) - RFE: Intristics for asin, acos'. I made report on http://bugreport.java.com/. Is it under evaluation or bugreport.java.com is only black hole as somebody complained? Thank you for info Martin

Fwd: Re: [PATCH] javax,script.ScriptEngineFactory Typos

Forwarding this contribution from Ahmed to core-libs-dev alias as the change is going to be in jdk/java.scripting/javax.script code. PS. I'll send out webrev after build, test. Thanks Ahmed, -Sundar Forwarded Message Subject:Re: [PATCH]

Re: RFR - 8027634: Support @argfiles for java command-line tool

Build changes look fine. /Magnus 10 jul 2015 kl. 05:50 skrev Henry Jen henry@oracle.com: Sigh, forgot the link to the webrev again. http://cr.openjdk.java.net/~henryjen/jdk9/8027634/webrev/ Cheers, Henry On Jul 9, 2015, at 8:48 PM, Henry Jen henry@oracle.com wrote: Hi,

[9] RFR 8129833: Need basic tests for rmic

Hi Daniel, please help to review the change for 8129833. Issue:https://bugs.openjdk.java.net/browse/JDK-8129833 Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try rmic with. It covers a problem of locating the class java.awt.Panel in jigsaw

Re[2]: Speed optimization of Spliterators.spliteratorUnknownSize for parallel case

Hello! Thank you for the detailed answer. PS Thanks for looking at this. Judging by the results i am guessing PS your measurements were performed on a 4-core system. Yes, quad-core, I mentioned it before. PS My initial inclination for these scenarios is it is likely better PS for the developer

Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

I agree that normalizedD looks like a typo (but it probably was not), but normalized is too ambiguous (there are too many different kinds of normalization) so a precise term like NFD should be used. Maybe we should add a reference to http://unicode.org/reports/tr15/ On Mon, Jul 13, 2015 at 4:29

Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

looks good. On 07/12/2015 09:32 AM, Ivan Gerasimov wrote: Hello! There's a minor issue in the current implementation of Pattern.quote() with possible numeric overflow when calculating initial capacity of StringBuilder. With the fix, some slight optimizations were done and a few typos were

Re: RFR [S] 6854417: TESTBUG: java/util/regex/RegExTest.java fails intermittently

On 07/12/2015 02:01 PM, Ivan Gerasimov wrote: Hello! RegExTest fails sometimes in checking Boyer-Moore search. This is because it was assumed that after insertion a pattern into a string at some position, we'll find it at the same position. That's not true if we insert 'aa' into 'xxaxx' at

RFR 9: JDK-8130877 : (process) java/lang/ProcessHandle/TreeTest test3 failure - Destroyed process.isAlive

Please review a testbug to correctly look for destroyed processes. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-isalive-8130877/ Issue: https://bugs.openjdk.java.net/browse/JDK-8130877 Thanks, Roger

Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

Thanks Martin! On 13.07.2015 21:26, Martin Buchholz wrote: I agree that normalizedD looks like a typo (but it probably was not), but normalized is too ambiguous (there are too many different kinds of normalization) so a precise term like NFD should be used. Maybe we should add a reference to

Re: RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

@see is mostly obsolete, now that we can use {@linkplain java.text.Normalizer.Form.NFD NFD} On Mon, Jul 13, 2015 at 4:51 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Thanks Martin! On 13.07.2015 21:26, Martin Buchholz wrote: I agree that normalizedD looks like a typo (but it

RFR: 8032446: Support Unicode 7.0.0 in JDK 9

Hello, Please review the fix for 8032446 to support Unicode 7 in JDK 9. https://bugs.openjdk.java.net/browse/JDK-8032446 http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ - Internal review for both open closed parts has been completed. - Changes in sun.text.* packages are mostly porting