Re: JDK 9 RFR of JDK-8131140: Mark some tests from WhileOpStatefulTest.java and WhileOpTest.java as serialization hostile

2015-07-15 Thread Amy Lu
Thank you Paul for review this. Yes, please help to push. Thanks, Amy On 7/15/15 6:55 PM, Paul Sandoz wrote: On Jul 14, 2015, at 10:53 AM, Amy Lu wrote: Stream tests WhileOpStatefulTest and WhileOpTest were newly introduced in JDK-8071597, some test cases should be marked as serialization-h

Re: RFR JDK-8130914: java/util/zip/TestExtraTime.java fails with "java.lang.RuntimeException: setTime should make getLastModifiedTime return the specified instant: 3078282244456 got: 3078282244455"

2015-07-15 Thread Claes Redestad
Code change looks OK to me, but perhaps there should be an explicit long conversion somewhere around the getYear() part ('d.getYear() - 1980 << 25L') of the expressions to deal properly with even larger values? Are there added tests missing from the updated TestExtraTime? I guess this is an int

RFR JDK-8130914: java/util/zip/TestExtraTime.java fails with "java.lang.RuntimeException: setTime should make getLastModifiedTime return the specified instant: 3078282244456 got: 3078282244455"

2015-07-15 Thread Xueming Shen
Hi, Please help review the change for JDK-8130914. issue: https://bugs.openjdk.java.net/browse/JDK-8130914 webrev: http://cr.openjdk.java.net/~sherman/8130914/ This is a "regression" triggered by https://bugs.openjdk.java.net/browse/JDK-8130914 http://cr.openjdk.java.net/~redestad/jdk9/8073497/

Re: RFR - 8027634: Support @argfiles for java command-line tool

2015-07-15 Thread Mandy Chung
> On Jul 10, 2015, at 11:48 AM, Henry Jen wrote: > > Hi, > > Please review proposed patch for JDK-8027634[1]. This patch is to enable java > support command line argument file like javac does. The implementation use > the same syntax rule, which is implemented in CommandLine.java[3] with > j

Re: [9] RFR 8129833: Need basic tests for rmic

2015-07-15 Thread FELIX YANG
On 7/15/2015 7:01 PM, Daniel Fuchs wrote: On 13/07/15 14:53, FELIX YANG wrote: Hi Daniel, please help to review the change for 8129833. Issue:https://bugs.openjdk.java.net/browse/JDK-8129833 Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try

Re: Speed optimization of Spliterators.spliteratorUnknownSize for parallel case

2015-07-15 Thread Paul Sandoz
On Jul 15, 2015, at 2:20 PM, Paul Sandoz wrote: >> By the way currently it's possible to create an IteratorSpliterator >> with estimated size: >> >> Spliterators.spliterator(iterator, estimatedSize, Spliterator.CONCURRENT); >> >> Of course it's a misuse of CONCURRENT flag, but it's not used >> o

Re: Speed optimization of Spliterators.spliteratorUnknownSize for parallel case

2015-07-15 Thread Paul Sandoz
Hi Tagir, On Jul 14, 2015, at 4:43 AM, Tagir F. Valeev wrote: > Hello! > > Thank you for the detailed answer. > > PS> Thanks for looking at this. Judging by the results i am guessing > PS> your measurements were performed on a 4-core system. > > Yes, quad-core, I mentioned it before. > > PS>

Re: RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

2015-07-15 Thread Michael Haupt
Hi Paul, Vladimir, thanks - I'll be back with perf numbers ASAP. Best, Michael > Am 15.07.2015 um 12:51 schrieb Paul Sandoz : > > > On Jul 15, 2015, at 10:23 AM, Michael Haupt wrote: > >> Dear all, >> >> please review and sponsor this change. >> RFE: https://bugs.openjdk.java.net/browse/JD

Re: [9] RFR 8129833: Need basic tests for rmic

2015-07-15 Thread Daniel Fuchs
On 13/07/15 14:53, FELIX YANG wrote: Hi Daniel, please help to review the change for 8129833. Issue:https://bugs.openjdk.java.net/browse/JDK-8129833 Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try rmic with. It covers a problem of locating t

Re: JDK 9 RFR of JDK-8131140: Mark some tests from WhileOpStatefulTest.java and WhileOpTest.java as serialization hostile

2015-07-15 Thread Paul Sandoz
On Jul 14, 2015, at 10:53 AM, Amy Lu wrote: > Stream tests WhileOpStatefulTest and WhileOpTest were newly introduced in > JDK-8071597, some test cases should be marked as serialization-hostile (such > tests will be ignored by lambda serialization testing framework). > I did it again! > Ple

Re: RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

2015-07-15 Thread Paul Sandoz
On Jul 15, 2015, at 10:23 AM, Michael Haupt wrote: > Dear all, > > please review and sponsor this change. > RFE: https://bugs.openjdk.java.net/browse/JDK-8062543 > Webrev: http://cr.openjdk.java.net/~mhaupt/8062543/webrev.00/ > > The change removes the no longer needed MethodHandleImpl.castRef

Re: RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

2015-07-15 Thread Vladimir Ivanov
Looks good. Have you verified there's no performance regression? I'd suggest to run some Octane benchmarks. Best regards, Vladimir Ivanov On 7/15/15 11:23 AM, Michael Haupt wrote: Dear all, please review and sponsor this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8062543 Webrev:

RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

2015-07-15 Thread Michael Haupt
Dear all, please review and sponsor this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8062543 Webrev: http://cr.openjdk.java.net/~mhaupt/8062543/webrev.00/ The change removes the no longer needed MethodHandleImpl.castReference method. Its uses are replaced with Class.cast. Tested with: