RFR v2 - 8027634: Support @argfiles for java command-line tool

Thanks Mandy and Magnus for looking into the patch, and feedbacks from Kumar Srinivasan and Michel Trudeau. We have an updated version to be reviewed at, http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v2/webrev/ This version changes the syntax a little bit as following, but pretty much stil

Re: StackOverflowError on HashMap.hashCode() due to self reference

Hi Louis, hanks! I thought I had seen it somewhere but I couldn't recall where. That's exactly what I need to answer the guys who asked me for a doc reference. Thanks, Kris On Friday, July 17, 2015, Louis Wasserman wrote: > The Javadoc of Map already specifies: > > > Note: great care must be e

StackOverflowError on HashMap.hashCode() due to self reference

Hi Vitaly, I can buy that argument. It wasn't hard for me to recognize it when I saw it in real world. But apparently whoever asked me about it couldn't wrap his head around it to understand why... Maybe it's a case for a Pitfalls book instead of for JavaDocs. Thanks, Kris On Friday, July 17,

Re: StackOverflowError on HashMap.hashCode() due to self reference

IMHO, this doesn't warrant any special wording -- if someone hits this, I think it's fairly evident what the issue is. You can get the same problem with adding an ArrayList to itself and calling hashCode(). On Fri, Jul 17, 2015 at 2:45 PM, Krystal Mok wrote: > Hi everyone, > > I'm sure somebody

StackOverflowError on HashMap.hashCode() due to self reference

Hi everyone, I'm sure somebody has seen this stack overflow before. My question is: is it expected (which should be documented to warn people not to do this), or is it considered a bug (which should be fixed)? Example: https://gist.github.com/rednaxelafx/930f8979473185cfc0a0 import java.util.*;

RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

Hi, I worked on refactoring the native ProcessHandleImpl implementation to enable more code sharing and make it easier to add support for new platforms (e.g. AIX) and I think I had a pretty nice version running. But unfortunately I've just realized that the recent changes to ProcessHandleImpl (i.e

Re: RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Hello, Yes, my general guidance is to make sure flaky tests are marked as "intermittent" in the test itself. This lets someone running the test easily check if the test is known to be unreliable *in that state of the sources*. There is a upfront overhead to collecting information about the c

Re: RFR JDK-8130914: java/util/zip/TestExtraTime.java fails with "java.lang.RuntimeException: setTime should make getLastModifiedTime return the specified instant: 3078282244456 got: 3078282244455"

On 7/17/15 8:45 AM, Xueming Shen wrote: On 7/17/15 1:04 AM, Peter Levart wrote: Hi Sherman, On 07/15/2015 09:10 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8130914. issue: https://bugs.openjdk.java.net/browse/JDK-8130914 webrev: http://cr.openjdk.java.net/~sherman/81309

Re: RFR JDK-8130914: java/util/zip/TestExtraTime.java fails with "java.lang.RuntimeException: setTime should make getLastModifiedTime return the specified instant: 3078282244456 got: 3078282244455"

On 7/17/15 1:04 AM, Peter Levart wrote: Hi Sherman, On 07/15/2015 09:10 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8130914. issue: https://bugs.openjdk.java.net/browse/JDK-8130914 webrev: http://cr.openjdk.java.net/~sherman/8130914/ This is a "regression" triggered by

Re: RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Hi Katja, Looks ok to me too. It has been a relatively manual process and I'm not aware of a mechanism how to sync test-key-bug. What I can do is to mark bugs I went through with for example 'key-intermittent' label to distinguish them form the new ones. That's another additional label, and

Re: RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Jaroslav, Thank you for the review! It has been a relatively manual process and I'm not aware of a mechanism how to sync test-key-bug. What I can do is to mark bugs I went through with for example 'key-intermittent' label to distinguish them form the new ones. Are there other suggestions?

RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8075658 webrev: http://cr.openjdk.java.net/~ykantser/8075658/webrev.00 Thanks, Katja

Re: RFR JDK-8130914: java/util/zip/TestExtraTime.java fails with "java.lang.RuntimeException: setTime should make getLastModifiedTime return the specified instant: 3078282244456 got: 3078282244455"

Hi Sherman, On 07/15/2015 09:10 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8130914. issue: https://bugs.openjdk.java.net/browse/JDK-8130914 webrev: http://cr.openjdk.java.net/~sherman/8130914/ This is a "regression" triggered by https://bugs.openjdk.java.net/browse/JDK-