Re: Stream.generate

On 07/21/2015 06:32 PM, Paul Sandoz wrote: Hi Remi, Can you log an issue? Thanks, Paul. Hi Paul, yes, https://bugs.openjdk.java.net/browse/JDK-8132097 regards, Rémi On 20 Jul 2015, at 19:08, Remi Forax wrote: Hi all, hi Paul, I've found that the signature of Stream.generate doesn't to

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

On 7/21/2015 9:51 AM, Daniel Fuchs wrote: Hi Joe, Looks good to me! nit: the two statics don't agree on style: 'private static final' vs 'private final static' Good catch! Fixed. Thanks! -Joe best regards, -- daniel On 20/07/15 23:47, huizhe wang wrote: Please review a change that

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

Hi Joe, Looks good to me! nit: the two statics don't agree on style: 'private static final' vs 'private final static' best regards, -- daniel On 20/07/15 23:47, huizhe wang wrote: Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/813190

Re: Stream.generate

Hi Remi, Can you log an issue? Thanks, Paul. On 20 Jul 2015, at 19:08, Remi Forax wrote: > Hi all, hi Paul, > I've found that the signature of Stream.generate doesn't to use a wildcard > hence some program are rejected even if there are valid, by example: > public static void main(String[] a

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

Thanks Roger! Joe On 7/21/2015 6:36 AM, Roger Riggs wrote: Hi Joe, Looks good. Roger On 7/20/2015 5:47 PM, huizhe wang wrote: Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/8131907/webrev/ Thanks, Joe

Re: RFR for 8068761 : Test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed with SocketTimeoutException

Hi Tristan, Looks ok, extending the timeout should work fine. Roger On 7/20/2015 6:20 PM, Tristan Yan wrote: Hi Please review small fix for test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java. webrev: http://cr.openjdk.java.net/~tyan/8068761/webrev/

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

Hi Joe, Looks good. Roger On 7/20/2015 5:47 PM, huizhe wang wrote: Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/8131907/webrev/ Thanks, Joe

Re: [9] RFR: 8130006: java/lang/invoke/MethodHandles/CatchExceptionTest Fails

On 20 Jul 2015, at 13:28, Konstantin Shefov wrote: > Hello, > > Please review a test bug fix. > An exception caused by code cache overflow should be re-thrown before > assertion check in the test. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8130006 > Webrev: http://cr.openjdk.java.net/

Re: [9] RFR: 8130006: java/lang/invoke/MethodHandles/CatchExceptionTest Fails

CC'ed more reviewers On 07/20/2015 02:28 PM, Konstantin Shefov wrote: Hello, Please review a test bug fix. An exception caused by code cache overflow should be re-thrown before assertion check in the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8130006 Webrev: http://cr.openjdk.java.n