Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

Hi, Joe and all Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8132660? This is already on our plan for a while, but I have to finish it now because these unit tests failed with latest Jigsaw build. However I made the changes based on 9-dev repo, I tested t

Spliterator documentation on Priority(Blocking)Queue

Hello! The PriorityQueue class iterator() returns elements in no particular order. This is explicitly stated in JavaDoc for iterator() method [1] as well as in class description [2]. However it's not mentioned mentioned that spliterator() method also traverses the queue in no particular order. Wel

Re: RFR(s): 8132800: clarify stream package documentation regarding sequential vs parallel modes

Hello, Stuart! On Tue, Aug 4, 2015 at 5:09 AM, Stuart Marks wrote: > Regarding Stream.concat, it may be that, today, changes to the > sequential/parallel execution mode aren't propagated to the streams being > concatenated. But is that something inherent to the specification of > concatenation,

Re: RFR(s): 8132800: clarify stream package documentation regarding sequential vs parallel modes

Hi Tagir, Interesting issues. Regarding Stream.concat, it may be that, today, changes to the sequential/parallel execution mode aren't propagated to the streams being concatenated. But is that something inherent to the specification of concatenation, or is it something that might change in th

Chair voting to approve 8041565: JMX ObjectName could be refactored to save memory

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Hi Alexander, I think Pavel's advice to run specdiff is useful. It's not too difficult to run and in this case it provides a useful cross-check for making a large number of markup changes. Contact me directly if you need help with specdiff. I've run specdiff over your webrev.01 and I've posted

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with "RuntimeException: Error: poll() returned null; expected ref object"

On Jul 30, 2015, at 10:22 PM, David Holmes wrote: > > Looks good! On Jul 31, 2015, at 5:10 AM, Daniel Fuchs wrote: > Thanks for taking care of this one! > > PS: you might want to add @bug 8132306 to >jdk/test/java/lang/ref/ReferenceEnqueue.java Done. On Jul 31, 2015, at 9:23 AM, Peter Le

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with "RuntimeException: Error: poll() returned null; expected ref object"

On Jul 31, 2015, at 9:23 AM, Peter Levart wrote: > > This looks good now. Thanks for taking both of the issues together. I wonder > if a similar racy test could be devised for the 2nd race. I doubt the > ReferenceEnqueue test was meant to catch invalid races specifically. It was > more a coinc

JEP 259: Stack-Walking API

New JEP Candidate: http://openjdk.java.net/jeps/259 - Mark

Re: RFR: JDK-8062849 -- Optimize EnumMap.equals

Looks reasonable to me. -Brent On 7/28/15 9:14 AM, Steve Drach wrote: Please review the following simple fix for the issue reported in https://bugs.openjdk.java.net/browse/JDK-8062849 . - # HG changeset patch # User sdrach # Da

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

Bhavesh, it would be good if jep 224 said what to do with the many legacy tags. Best practice seems to be to convert to {@code ...} if possible and appropriate, else to , , or , as given by http://www.w3schools.com/tags/tag_code.asp On Mon, Aug 3, 2015 at 10:21 AM, Alexander Stepanov < alexander

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

Sorry, at the moment I can say only that is deprecated in HTML5: http://www.html-5.com/changes/deprecated/ "Here is a list of deprecated HTML tags to avoid using" - that's was the main motivation. As I know, in future(?) the documentation should be HTML5-compliant: http://openjdk.java.net/j

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

I'm surprised is going away. Do you have a reference that explains the new jdk9 javadoc standards? On Mon, Aug 3, 2015 at 2:43 AM, Alexander Stepanov < alexander.v.stepa...@oracle.com> wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8132877/

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Hello Pavel > Hi Alexander, if I were you I would run specdiff Thanks; but sorry, I'm afraid I haven't enough time for the extra experiments just now... > It's very easy to go the all the way and lose oneself in there :) please accept my condolences :) Regards, Alexander On 8/3/2015 6:33 PM,

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

just in case, the updated webrev: http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/index.html On 8/3/2015 4:01 PM, Alexander Stepanov wrote: P.S. I have also to replace {@link ...} with just {@link ...} in a couple of places here (as in the previous RFR 8132468...) Regards, Alexander O

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

> > On 3 Aug 2015, at 16:07, Alexander Stepanov > wrote: > > Please see the updated webrev: > http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/ > > removed wrapping around the links (mostly PrintStream.java, > PrintWriter.java, File.java), plus other changes in File.java > > Thanks, >

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Michael, thanks for reviewing! Vladimir, could you take a look, please? -Konstantin On 08/02/2015 05:31 PM, Michael Haupt wrote: Hi Konstantin, Am 31.07.2015 um 18:37 schrieb Konstantin Shefov mailto:konstantin.she...@oracle.com>>: Please review a test improvement. Covered more cases for Me

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/ removed wrapping around the links (mostly PrintStream.java, PrintWriter.java, File.java), plus other changes in File.java Thanks, Alexander On 8/3/2015 3:40 PM, Alexander Stepanov wrote: Hello Daniel, T

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

P.S. I have also to replace {@link ...} with just {@link ...} in a couple of places here (as in the previous RFR 8132468...) Regards, Alexander On 8/3/2015 3:57 PM, Alexander Stepanov wrote: Thanks! On 8/3/2015 3:53 PM, Lance Andersen wrote: I think this looks ok also. I agree with Daniel t

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

Thanks! On 8/3/2015 3:53 PM, Lance Andersen wrote: I think this looks ok also. I agree with Daniel that we have additional clean-up opportunities throughout we can do to the javadocs, but keeping each change set more narrow helps reduce the chance of introducing additional errors Best La

Re: RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

I think this looks ok also. I agree with Daniel that we have additional clean-up opportunities throughout we can do to the javadocs, but keeping each change set more narrow helps reduce the chance of introducing additional errors Best Lance On Aug 3, 2015, at 5:43 AM, Alexander Stepanov w

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Hello Daniel, Thank you for the notes; > The is not needed around {@link } - as that should be the default formatting for {@link } Sorry, didn't know; I have to fix that. > Would that be easier to read as: Yes, probably that's better. Some old-style tags were saved just because of some ext

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

On 03/08/15 11:31, Alexander Stepanov wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132468/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132468 Just some cleanup for docs (replacing obsolete ""). Thanks, Alexander Hi Alexander, mos

RFR [9] 8132877: docs: replace tags (obsolete in html5) for java.naming

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132877/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132877 Just some cleanup for docs (replacing obsolete ""). Thanks, Alexander

RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132468/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132468 Just some cleanup for docs (replacing obsolete ""). Thanks, Alexander