Re: JDK 9 RFR of JDK-8079769: tools/pack200/PackTestZip64.java may timeout at preparing the large test file

Looks good. Kumar On 8/6/2015 7:06 AM, Amy Lu wrote: Please review the fix for test issue: tools/pack200/PackTestZip64.java may timeout at preparing the large test file This test tries to create a big jar file for testing by adding a large number (Short.MAX_VALUE * 2 + 2) of small files to t

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

On 8/12/15 8:10 AM, Volker Simonis wrote: On Wed, Aug 12, 2015 at 12:19 AM, Stuart Marks wrote: The proposed spec for commandLine() says, * If {@link #command command()} and {@link #arguments arguments()} return non-null * optionals, The preferred term is "non-empty" instead of non-null.

Re: RFR [9] 8133459: replace tags (obsolete in html5) in java.nio docs

Hello Lance, Thanks! Regards, Alexander On 8/12/2015 7:41 PM, Lance Andersen wrote: Hi Alexander, Nothing seems amiss in the changes and you indicated the specdiff shows no issues so you should be good to go Best Lance On Aug 12, 2015, at 11:46 AM, Alexander Stepanov

Re: RFR [9] 8133459: replace tags (obsolete in html5) in java.nio docs

Hi Alexander, Nothing seems amiss in the changes and you indicated the specdiff shows no issues so you should be good to go Best Lance On Aug 12, 2015, at 11:46 AM, Alexander Stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/813345

RFR [9] 8133459: replace tags (obsolete in html5) in java.nio docs

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133459/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8133459 Just a next portion of deprecated '' tags replaced (didn't touch all these multiple ' 's to avoid undesirable formatting chang

Re: RFR v4 - 8027634: Support @argfiles for java command-line tool

> On Aug 12, 2015, at 7:55 AM, Kumar Srinivasan > wrote: > > Henry, > > Generally looks good here are some comments, on my initial > pass, I am not fully done with args.c I will look at this some > more later today or tomorrow. > > 4.) > expectingNoDash is expectingMain right ? if so I would

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

Hi Stuart, thanks for verifying the changes one more time. On Wed, Aug 12, 2015 at 12:19 AM, Stuart Marks wrote: > .. and of course right after I sent my previous message, I ran across > something worth noting. > > The proposed spec for commandLine() says, > > * If {@link #command command()} and

Re: RFR v4 - 8027634: Support @argfiles for java command-line tool

Henry, Generally looks good here are some comments, on my initial pass, I am not fully done with args.c I will look at this some more later today or tomorrow. args.c: 1.) Can be folded 45 char *rv; 46 47 rv = (char *) JLI_MemAlloc(len + 1); char *rv = (char *) JLI_MemAlloc(len +

Possible long overflow in Collectors.averagingLong and LongStream.average

Hello! The following code prints -1 twice, while users would normally expect something like 9.223372036854776E18: double avg1 = Stream.of(Long.MAX_VALUE, Long.MAX_VALUE).collect( Collectors.averagingLong(Long::valueOf)); System.out.println(avg1); double avg2 = LongStream.of(Long.