Re: JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis

2015-08-13 Thread David Holmes
On 14/08/2015 7:42 AM, Joseph D. Darcy wrote: Hi David, On 8/13/2015 2:30 PM, David Holmes wrote: Joe, This is making it hard to clean up everything at once. I'm already delayed from pushing the fix because the "@key intermittent" change is not in hs-rt yet. If the test needs to be updated a

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-08-13 Thread Roger Riggs
Hi Volker, The internal reviews are complete and accepted. The code looks fine. Please push it. I"ll be going on vacation so if it breaks something, someone else will need to pick up the pieces or back it out. Many thanks for the work to refactor and cleanup the details. Roger On 8/12/1

Re: [9] RFR: 8133321: (tz) Support tzdata2015f

2015-08-13 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 8/13/2015 10:54 PM, Aleksej Efimov wrote: Hello, Please review latest tzdata (2015f) integration into JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015f/9/00 Testing shows no TZ related failures on all platforms. Thanks, Aleksej JBS: https://bugs.openjdk.

Re: JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis

2015-08-13 Thread Joseph D. Darcy
Hi David, On 8/13/2015 2:30 PM, David Holmes wrote: Joe, This is making it hard to clean up everything at once. I'm already delayed from pushing the fix because the "@key intermittent" change is not in hs-rt yet. If the test needs to be updated as part of the fix for JDK-8029453, presumabl

Re: JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis

2015-08-13 Thread David Holmes
Joe, This is making it hard to clean up everything at once. I'm already delayed from pushing the fix because the "@key intermittent" change is not in hs-rt yet. If this change also goes in then I again have to wait for it to arrive before I can reverse it. It will take a month for everything

JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis

2015-08-13 Thread joe darcy
Hello, Until a fix for JDK-8029453 is in place, the test TimeoutLockLoops.java should be placed on the problem list for Linux since it fails intermittently, but fairly frequently, on that OS: --- a/test/ProblemList.txtThu Aug 13 09:36:14 2015 -0700 +++ b/test/ProblemList.txtThu Aug 13

Re: RFR [9] 8133480: replace some tags (obsolete in html5) in core-libs docs

2015-08-13 Thread Lance Andersen
looks OK. Nothing obvious stands out. Best Lance On Aug 13, 2015, at 10:42 AM, Alexander Stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8133480/webrev.00 > for > https://bugs.openjdk.java.net/browse/JDK-8133480 > > Just another

Re: RFR v4 - 8027634: Support @argfiles for java command-line tool

2015-08-13 Thread Henry Jen
> On Aug 13, 2015, at 9:38 AM, Kumar Srinivasan > wrote: > > 3. void JLI_InitArgProcessing(jboolean isJava, jboolean disableArgFile) { >// No expansion for relaunch > > > The launcher might re-exec itself, this might happen under certain > circumstances on *nix, is the above logic to prev

Re: RFR v4 - 8027634: Support @argfiles for java command-line tool

2015-08-13 Thread Kumar Srinivasan
Henry, I am still not complete, but here are some more comments and specifics. args.c 1. -static int firstAppArgIndex = -1; +#define NOT_FOUND -1; +static int firstAppArgIndex = NOT_FOUND; 2. // Any @argument comes in here is an argument as is. // Expansion should had done before c

RFR [9] 8133480: replace some tags (obsolete in html5) in core-libs docs

2015-08-13 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133480/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133480 Just another portion of deprecated tags replaced with {@code }. A single misprint was fixed; no other changes indicated by specdiff. Tha

[9] RFR: 8133321: (tz) Support tzdata2015f

2015-08-13 Thread Aleksej Efimov
Hello, Please review latest tzdata (2015f) integration into JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015f/9/00 Testing shows no TZ related failures on all platforms. Thanks, Aleksej JBS: https://bugs.openjdk.java.net/browse/JDK-8133321