RFR v6 - 8027634: Support @argfiles for java command-line tool

2015-08-17 Thread Henry Jen
> On Aug 17, 2015, at 8:45 PM, Mandy Chung wrote: > > OK. firstAppArgIndex is not used in the parsing. It is set in args.c:127, and stop expansion on line 369. v6 is available at http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v6/webrev/ Changes based on Mandy’s comment, - add a new te

Re: RFR v5 - 8027634: Support @argfiles for java command-line tool

2015-08-17 Thread Mandy Chung
> On Aug 16, 2015, at 4:51 PM, Henry Jen wrote: > > >> args.c >> You have #define NOT_FOUND -1 but NOT_FOUND is not used else where. >> > > Used right under to initialize firstAppArgIndex, and should be used in > following statement you shown. Please change that. > >> void JLI_InitArgProc

Re: RFR v5 - 8027634: Support @argfiles for java command-line tool

2015-08-17 Thread Mandy Chung
On 08/17/2015 08:00 AM, Henry Jen wrote: On Aug 17, 2015, at 7:10 AM, Henry Jen wrote: I think I may be talking at a different thing, guess you meant the make JLI_List JLI_PreprocessArg(const char*) to void JLI_PreprocessArg(JLI_List, const char*) and pass in a list to hold all the argument

Re: RFR v5 - 8027634: Support @argfiles for java command-line tool

2015-08-17 Thread Henry Jen
On Aug 17, 2015, at 7:10 AM, Henry Jen wrote: > >> >> On Aug 16, 2015, at 4:51 PM, Henry Jen wrote: >> >> Thanks for reviewing, comment inline below, >> >>> On Aug 14, 2015, at 4:07 PM, Mandy Chung wrote: >>> >>> On Aug 14, 2015, at 1:10 PM, Henry Jen wrote: Hi,

Re: RFR v5 - 8027634: Support @argfiles for java command-line tool

2015-08-17 Thread Henry Jen
> On Aug 16, 2015, at 4:51 PM, Henry Jen wrote: > > Thanks for reviewing, comment inline below, > >> On Aug 14, 2015, at 4:07 PM, Mandy Chung wrote: >> >> >>> On Aug 14, 2015, at 1:10 PM, Henry Jen wrote: >>> >>> Hi, >>> >>> Another minor revision address comments, no real behavior change