JDK 9 RFR of JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg

2015-09-14 Thread Joseph D. Darcy
Hello, Please review the patch below for JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg The jtreg TEST.ROOT file in the HotSpot repository puts sun.arch.data.model on the list of properties which can be queried by an @requires clause in jtreg. This

Re: Space before comma

2015-09-14 Thread Roger Riggs
Hi Ahmed, Such a changeset doesn't add much value by itself. Have you looked for some small scale bug that would be interesting? Try looking for issues with a label like jdk-starter. [1] Pick something that seems obvious and you feel you can completely understand the issue, how to write a t

Re: RFR: 8033661: readConfiguration does not cleanly reinitialize the logging system

2015-09-14 Thread Daniel Fuchs
Hi Mandy, On 13/09/15 00:44, Mandy Chung wrote: Have you considered keeping the same method name, readConfiguration with the new remapper parameter? The downside is the difference that the reset is not invoked. It might not matter because as you add in @apiNote that the existing readConfigurat

Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-14 Thread Robert Muir
On Wed, Sep 9, 2015 at 11:46 AM, Peter Levart wrote: > > By wanting to truly release the resources you allocated, you are essentially > wanting to manage the resources yourself. If you are willing to track the > active mapped byte buffers manually yourself, then what about the following > idea: >

Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-14 Thread Mark Miller
It seems less than ideal to count on System.gc to do this as a library though. Now the user has to worry about what affect System.gc has on what JVM with what Garbage Collector and whether or not ExplicitGCInvokesConcurrent was turned on for the JVM, or... - Mark On Wed, Sep 9, 2015 at 11:46 AM

Fwd: Question about CachedRowSetImpl

2015-09-14 Thread Carolyn Kim
Hi, I have a question about CachedRowSetImpl. I'm trying to use its pagination function. But it seems like it does not work with populate method. I think I'm seeing the same issue that's described here: https://bugs.openjdk.java.net/browse/JDK-6382534?page=com.atlassian.jira.plugin.system.issuetab

Re: RFR: 8129957 - Deadlock in JNDI LDAP implementation when closing the LDAP context

2015-09-14 Thread Rob McKenna
Hi folks, So on further investigation it looks like we could get away with reducing the amount of locking in LdapClient. Here is a proposed fix followed by a description: http://cr.openjdk.java.net/~robm/8129957/webrev.02/ processConnectionClosure(): - Remove the synchronization from process

Space before comma

2015-09-14 Thread Ahmed Ashour
Hi all, I would like to prepare a patch for removing space before comma in .java files of 'jdk9/dev/jdk'.  Of course, there are places where spaces are needed for vertical alignment with previous/next lines. Would that add a value, or there is no need for such a patch? P.S. I signed the OCA Thank

Re: Collections.emptyList().spliterator() is not ORDERED

2015-09-14 Thread Paul Sandoz
On 7 Sep 2015, at 15:23, Paul Sandoz wrote: >> By the way, probably it's reasonable then for Arrays.asList to check >> the array length like: >> >> public static List asList(T... a) { >> if(a.length == 0) >> return Collections.emptyList(); >> return new ArrayList<>(a); >>

Re: RFR: 8033661: readConfiguration does not cleanly reinitialize the logging system

2015-09-14 Thread Daniel Fuchs
Hi Mandy, Thanks a lot for the feedback! On 13/09/15 00:44, Mandy Chung wrote: On Sep 9, 2015, at 9:55 AM, Daniel Fuchs wrote: Hi, Please find below a candidate fix for: 8033661: readConfiguration does not cleanly reinitialize the logging system https://bugs.openjdk.java.net/brow