Re: RFR (JAXP) - JDK-8077931: Develop tests for XML Catalog API

2015-10-25 Thread John Jiang
Hi Lance, Thanks for your review! Best regards. John Jiang On 2015/10/24 7:00, Lance Andersen wrote: looks ok On Oct 23, 2015, at 3:48 AM, John Jiang > wrote: Hi all, Please help review the tests for XML Catalog API: https://bugs.openjdk.java.net/browse/JDK-8077

Re: RFR (JAXP) - JDK-8077931: Develop tests for XML Catalog API

2015-10-25 Thread John Jiang
Hi Joe, Thanks for your review! Best regards, John Jiang On 2015/10/24 3:45, huizhe wang wrote: Looks good to me, John. Best regards, Joe On 10/23/2015 12:48 AM, John Jiang wrote: Hi all, Please help review the tests for XML Catalog API: https://bugs.openjdk.java.net/browse/JDK-8077931 The

Re: 8139891: Prepare Unsafe for true encapsulation

2015-10-25 Thread David Holmes
On 26/10/2015 11:49 AM, Alan Bateman wrote: On 26/10/2015 01:41, David Holmes wrote: If you are in agreement, is it best to move this first step on and push it into hs-rt. I can then follow up with the additional steps: hotspot test updates in hs-rt, and the library changes in jdk9/dev, in para

Re: 8139891: Prepare Unsafe for true encapsulation

2015-10-25 Thread Alan Bateman
On 26/10/2015 01:41, David Holmes wrote: If you are in agreement, is it best to move this first step on and push it into hs-rt. I can then follow up with the additional steps: hotspot test updates in hs-rt, and the library changes in jdk9/dev, in parallel. I would have expected all changes to

Re: 8139891: Prepare Unsafe for true encapsulation

2015-10-25 Thread David Holmes
Hi Chris, Updated webrev: http://cr.openjdk.java.net/~chegar/unsafe_phase1.01/ This all looks fine to me. If you are in agreement, is it best to move this first step on and push it into hs-rt. I can then follow up with the additional steps: hotspot test updates in hs-rt, and the library

Re: Collections.emptyList().spliterator() is not ORDERED

2015-10-25 Thread Tagir F. Valeev
Hello! >> PS> In this case we should fix Stream.concat to check if a >> PS> spliterator reporting SIZED is empty, which will allow us to optimize >> the concatenation [1]. >> PS> [1] https://bugs.openjdk.java.net/browse/JDK-8022805 I tried to fix this issue, but stuck into subtle behavior change

[PATCH] Re: Incomplete JavaDoc for Collections.synchronizedXYZ

2015-10-25 Thread Tagir F. Valeev
Hello! Here's the patch. I updated JavaDoc for synchronizedSet, synchronizedSortedSet, synchronizedNavigableSet, synchronizedList, synchronizedMap, synchronizedSortedMap and synchronizedNavigableMap. Hopefully my wording is correct (English is not my native language). With best regards, Tagir Val