Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Ping ... Would somebody find time for this one? Thanks M. On 26/10/15 13:59, Miroslav Kos wrote: Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary service

Re: Proposed API for JEP 259: Stack-Walking API

> On Nov 10, 2015, at 1:07 AM, Peter Levart wrote: > > Hi Mandy, > > On 11/10/2015 03:20 AM, Mandy Chung wrote: >> I have updated the APIs to incorporate all the feedback. Thank you all. >> Let me know if I miss any. >> >> Summary: >> 1. Change to use wildcard

Re: RFR: 8141678: sun.invoke.util.Wrapper eagerly initializes all integral type caches

Thanks for the correction, John! I completely overlooked MH type conversions and a note in MethodHandle.constant about widening primitive conversion when primitive constant if requested. Claes, the test looks good! Probably it is worth an RFE for additional test development in that area.

Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

A few of the proposed replacements of ?: with requireNonNullElse were unsuitable because in the particular context, null is an allowed replacement value. The webrev has been updated to revert changes: - two uses in jdk/src/java.base/share/classes/java/time/format/DateTimePrintContext.java

Re: RFR(L): JDK-8046936 : JEP 270: Reserved Stack Areas for Critical Sections

Hi David and Doug, Thank you for your feedback. I put some comments below. On 09/11/2015 08:12, David Holmes wrote: Hi Doug, On 9/11/2015 9:31 AM, Doug Lea wrote: On 11/06/2015 02:23 AM, David Holmes wrote: Before I look at the code, what is the status of the "Open Issues" referenced in

Re: RFR: 8141678: sun.invoke.util.Wrapper eagerly initializes all integral type caches

On Nov 10, 2015, at 10:53 AM, Vladimir Ivanov wrote: > > Regarding the fix, can we avoid touching primitive boxes and lazily cache the > values on Wrapper side? "static final @Stable Object[] zeros" + > Wrapper.zero() indexing that array by Wrapper.ordinal(). I

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> On 9 Nov 2015, at 21:53, Steve Drach wrote: > As to whether this is implementation vs. JAR URL spec then I assume it needs to be spec so that libraries can create URLs that will use runtime versioning when access the JAR. >>> >>> Yeah, i don’t

Re: RFR 9: 8132394 : (process) ProcessBuilder support for a pipeline of processes

> On 9 Nov 2015, at 19:07, Roger Riggs wrote: >> >> Why do you need to use a FileDescriptor rather than an int? AFAICT >> FileDescriptor is used as a box to the underlying descriptor that is >> accessed via shared secrets. > It is a cleaner encapsulation for the file

Re: Proposed API for JEP 259: Stack-Walking API

Hi Mandy, On 11/10/2015 03:20 AM, Mandy Chung wrote: I have updated the APIs to incorporate all the feedback. Thank you all. Let me know if I miss any. Summary: 1. Change to use wildcard walk(Function, ? extends T> function) 2. Removed the walk method taking IntUnaryOperator

Re: RFR: updated draft API for JEP 269 Convenience Collection Factories

Hi Stuart, I think that what matters are the methods that execute in tight loops. Some thousand array clones that would be performed while interpreting would be barely noticeable. I agree that JMH benchmarks presented here are not a representative for real-world tight loops. Especially

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

The modules.xml change and boot.modules change looks okay to me. Mandy > On Nov 10, 2015, at 4:30 PM, Ioi Lam wrote: > > A "final" webrev (before I go on vacation :-) > > http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/ > > There's a single line changed

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

A "final" webrev (before I go on vacation :-) http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/ There's a single line changed from the previous webrev: http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/root/modules.xml.sdiff.html The reason is to allow the use of

Re: RFR:JDK-8138664- ZonedDateTime parse error for any date using 'GMT0' ZoneID

Good fix, thanks Stephen On 9 November 2015 at 20:36, Roger Riggs wrote: > Hi Nadeesh, > > Thanks for fixing this issue. > > It looks fine, I can sponsor the change for you. > > Roger > > > > On 11/9/2015 4:12 AM, nadeesh tv wrote: >> >> Hi all, >> >> Please review a fix

RFR: JDK-8133206 - Higher native memory usage caused by upgrade to zlib 1.2.8

Please review the following fix to JDK-8133206: - bug: https://bugs.openjdk.java.net/browse/JDK-8133206 - webrev for jdk9: http://cr.openjdk.java.net/~akasko/jdk9/8133206/webrev.00/ This fix is a forward-port of the patch to jdk7u created by Nikolay Gorshkov: - webrev for jdk7u:

Re: RFR: 8142334: Improve lazy initialization of java.lang.invoke

> On 9 Nov 2015, at 20:48, Claes Redestad wrote: > > Hi Peter, > > nice catch: > > http://cr.openjdk.java.net/~redestad/8142334/webrev.02 > DirectMethodHandle — 682 private static @Stable NamedFunction[] FUNCTIONS = new NamedFunction[NF_LIMIT]; Invokers —

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

On 10/11/2015 09:06, Paul Sandoz wrote: : It’s more common to register a URLStreamHandlerFactory via URL.setURLStreamHandlerFactory. I suspect that is used more for supporting different URL schemes than for overriding the “jar” scheme. This is a very delicate area, override the “jar" scheme

Re: RFR 9: 8132394 : (process) ProcessBuilder support for a pipeline of processes

> On 9 Nov 2015, at 19:55, Roger Riggs wrote: > > Hi Paul, Alan, > > What are the chances that varargs will be updated at some point in the future > to use > Lists instead of arrays? It would be a bit of thrash to try to avoid varargs > if varargs > is likely to be

Re: RFR:JDK-8066571:UnsupportedTemporalTypeException is thrown not only in the case of unsupported temporal

Nice ti see this fixed thanks Stephen On 9 November 2015 at 21:34, Roger Riggs wrote: > Hi Naddesh, > > Thanks for fixing this issue. > > I can sponsor getting the fix pushed. > > Roger > > > > > On 11/9/2015 4:16 AM, nadeesh tv wrote: > > Hi all, > > Please review a fix

Re: Code Review for JEP 259: Stack-Walking API

Mandy, Native part looks good for me. javaClasses.cpp: 1. It might be good to create a helper inline function for int bci_version = stackFrame->int_field(bci_offset); int version = BackTrace::version_at(bci_version); 2. java_lang_StackFrameInfo::fill_methodInfo CHECK macro left

Re: JDK 9 RFR of JDK-8142370: Move java/util/concurrent/Phaser/Basic.java to tier 2

On 11/9/2015 7:56 PM, Martin Buchholz wrote: I approve this change. @key intermittent also added in CVS. We also observe this test to fail, but only very rarely. We do want to eventually address all the test failures, even the rare intermittent ones :-) Thanks, -Joe

Re: JDK 9 RFR of JDK-8142370: Move java/util/concurrent/Phaser/Basic.java to tier 2

There's been a big test improvement effort for jsr166 tests, but more remains. On Tue, Nov 10, 2015 at 6:46 PM, Joseph D. Darcy wrote: > On 11/9/2015 7:56 PM, Martin Buchholz wrote: > >> I approve this change. @key intermittent also added in CVS. We also >> observe this