JDK 9 RFR of JDK-8143583: Several tests don't work with latest jtreg due to non-existing files in @build

2015-11-22 Thread Amy Lu
Below tests failed with latest nightly jtreg due to non-existing files in @build com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java sun/tools/jmap/BasicJMapTest.java com/sun/jdi/DoubleAgentTest.java com/sun/jdi/SuspendNoFlagTest.java Please review this patch to fix the typo in @build

Re: JDK 9 RFR of JDK-8143583: Several tests don't work with latest jtreg due to non-existing files in @build

2015-11-22 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 23 nov. 2015, at 08:10, Amy Lu wrote: > > Below tests failed with latest nightly jtreg due to non-existing files in > @build > > com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java > sun/tools/jmap/BasicJMapTest.java >

Re: RFR(L): JDK-8046936 : JEP 270: Reserved Stack Areas for Critical Sections

2015-11-22 Thread Doug Lea
On 11/20/2015 12:40 PM, Karen Kinnear wrote: Totally appreciate the suggestion that the java.util.concurrent modifications be done by folks with more domain expertise. Would you have us incorporate the initial minimal set of j.u.c. updates or none at all? Sorry that I'm still in foot-drag

Re: RFR (S) 8136500: Integer/Long getChars and stringSize should be more idiomatic

2015-11-22 Thread Aleksey Shipilev
On 11/22/2015 01:55 AM, Ivan Gerasimov wrote: >>> Second, I think, the code of stringSize() might be better inlined, if it >>> was used only once. >> No-no! That's a helpful little fella. Not-yet-integrated Indify String >> Concat uses Integer/Long.stringSize. > > I didn't really propose to

Re: RFR (S) 8136500: Integer/Long getChars and stringSize should be more idiomatic

2015-11-22 Thread Fabian Lange
Hi Aleksey, > > It might be reasonable to reorganize the code a bit: > > > > int size = 0, i1 = i; > > if (i < 0) { > > if (i == Integer.MIN_VALUE) > > return "-2147483648"; > > size = 1; > > i1 = -i; > > } > > size += stringSize(i1); > > > >

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-11-22 Thread Kumar Srinivasan
Hi Martin, et. al., Sorry for not getting back earlier, I am very busy right now with my other large commitments for JDK9. I will sponsor this "enhancement/bug fix" sometime in the new year, meanwhile, there is the changeset [1] which is likely to cause merge conflicts, and perhaps logic