Re: Code (Pre-)Review for JEP 280: Indify String Concat

Thanks! The patch looks better, and having the code all in one place definitively helps. I think there is still something that you can do to improve the code - i.e. all strategies seem to do: * collect arguments (on a JCAssignOp and on a JCBinary) * build indy node Currently you have switches

Re: Code (Pre-)Review for JEP 280: Indify String Concat

Hi Maurizio, Thanks for the reviews! Updated webrevs: http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.02/ http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.03/ On 11/26/2015 02:40 PM, Maurizio Cimadamore wrote: > types.boxedClass(syms.voidType).type; > > Note that j.l.Void

Re: Code (Pre-)Review for JEP 280: Indify String Concat

Hi Aleksey, > http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.02/ src/java.base/share/classes/java/lang/Integer.java src/java.base/share/classes/java/lang/Long.java I miss JavaDocs for the returned value of the methods #getChars(int, int, byte[]) and #getCharsUTF16(int, int, byte[]). And

RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

Hi, This is a request for an optimistic review to fork the sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables so that we can evolve the latter e.g. for VarHandles unsafe work http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/

RFR: JDK-8142936:Additional java.time.Duration methods

Hi all, Please review a fix for Bug Id - https://bugs.openjdk.java.net/browse/JDK-8142936 -Enhance Duration by adding toNanosPart() , toMillisPart(),toSecondsPart(),toMinutesPart(),toHoursPart(),toDaysPart() methods . - Had to rename

Re: Code (Pre-)Review for JEP 280: Indify String Concat

Hi Alex, some comments on the langtools code below: * please remove the new voidClassType constant from Symtab - and use this idiom instead: types.boxedClass(syms.voidType).type; Note that j.l.Void is always created (see call to synthetizeBoxTypeIfMissing(voidType) - but there are (or used

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

On 26.11.2015 12:48, Jaroslav Bachorik wrote: On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/2015 10:06 AM, Mandy Chung wrote: >> >>> On Nov 24, 2015, at 3:45 PM, Peter Levart wrote: >>>

Re: RFR(m): JEP 269 initial API and skeleton implementation (JDK-8139232)

Hi Stuart, - Mail original - > De: "Stuart Marks" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Mercredi 25 Novembre 2015 01:07:16 > Objet: Re: RFR(m): JEP 269 initial API and skeleton implementation >

Re: Code (Pre-)Review for JEP 280: Indify String Concat

Hi Andrej, Thanks for the review, I'll send the updated webrevs once I address Maurizio's review comments. On 11/26/2015 11:42 AM, Andrej Golovnin wrote: >> http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.02/ > > src/java.base/share/classes/java/lang/Integer.java >

Re: Code (Pre-)Review for JEP 280: Indify String Concat

On 26/11/15 11:40, Maurizio Cimadamore wrote: * The code for initializing options in Gen is what we would normally model with an enum. I.e. you need something like: enum StringConcatMode { INLINE, INDY_PLAIN, INDY_CONSTANTS; } And then put some logic inside the enum class to parse

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

On 11/26/2015 12:55 PM, Paul Sandoz wrote: > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ Both JDK and Hotspot changes look good to me. > https://bugs.openjdk.java.net/browse/JDK-8143628 C1

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/2015 10:06 AM, Mandy Chung wrote: >> >>> On Nov 24, 2015, at 3:45 PM, Peter Levart wrote: >>> >>> >>> >>> On 11/24/2015 05:49 PM, Jaroslav

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

> On 26 Nov 2015, at 13:00, Aleksey Shipilev > wrote: > > On 11/26/2015 12:55 PM, Paul Sandoz wrote: >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ > > Both

Re: Code (Pre-)Review for JEP 280: Indify String Concat

Hi Aleksey, > http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.02/ test/tools/javac/T5024091/T5024091.java src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/StringConcat.java The files do not have the copyright header. And I have one stupid question to

Re: Reference.reachabilityFence

Hi Paul, Just a note on the test logic... 71 boolean finalized = false; 72 for (int c = 0; c < MAIN_ITERS; c++) { 73 finalized |= nonFenced(LOOP_ITERS); 74 } ...no need to loop to the end (MAIN_ITERS) after the outcome is already settled: