Re: RFR: 8071507: (ref) Clear phantom reference as soft and weak references do

2015-12-05 Thread Peter Levart
On 12/05/2015 05:28 PM, Mandy Chung wrote: On Dec 5, 2015, at 3:12 AM, Peter Levart wrote: On 12/04/2015 10:58 PM, Mandy Chung wrote: "It is possible to create a phantom reference with a null queue, but such a reference is completely useless: Its get method will always return null and, si

Re: RFR 9: 8138696 : java.lang.ref.Cleaner - an easy to use alternative to finalization

2015-12-05 Thread Roger Riggs
Hi Mandy, Thanks for the comments, Updated the artifacts: [1]http://cr.openjdk.java.net/~rriggs/webrev-cleaner-8138696/ [2]http://cr.openjdk.java.net/~rriggs/cleaner-doc/index.html On 12/04/2015 08:35 PM, Mandy Chung wrote: On Dec 4, 2015, at 8:56 AM, Roger Riggs wrote: [1] http://cr.ope

Re: RFR: 8071507: (ref) Clear phantom reference as soft and weak references do

2015-12-05 Thread Mandy Chung
> On Dec 5, 2015, at 3:12 AM, Peter Levart wrote: > > > > On 12/04/2015 10:58 PM, Mandy Chung wrote: >> "It is possible to create a phantom reference with a null queue, but such a >> reference is completely useless: Its get method will always return null and, >> since it does not have a queu

Re: RFR(L): JDK-8046936 : JEP 270: Reserved Stack Areas for Critical Sections

2015-12-05 Thread Doug Lea
On 12/03/2015 12:53 AM, David Holmes wrote: On 3/12/2015 12:56 AM, Doug Lea wrote: In the absence of any of: tail-recursion support, reliable cleanup, or growable stacks, it seems reasonable to choose larger default stack sizes so that these long but finite chains of completions are far less lik

Re: RFR 8144675: Add a filtering collector

2015-12-05 Thread Paul Sandoz
> On 4 Dec 2015, at 23:05, Brian Goetz wrote: > > This seems reasonable; mapping() already exists for use in this space (as a > combinator for the downstream collector of groupingBy and friends), > filtering() is also reasonable in this context. > Agreed, i like it, and will review it more c

Re: RFR: 8071507: (ref) Clear phantom reference as soft and weak references do

2015-12-05 Thread Peter Levart
On 12/04/2015 10:58 PM, Mandy Chung wrote: "It is possible to create a phantom reference with a null queue, but such a reference is completely useless: Its get method will always return null and, since it does not have a queue, it will never be enqueued.” The puzzling part to me is why Phant

Re: JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

2015-12-05 Thread Daniel Fuchs
HI Hamlin, If I understand well any line, comment, etc, added to the test in the future is likely to make the tests fail because the line numbers will no longer match. I have seen other tests (I think they where compiler tests) which exhibited such a characteristic, but those had a big warning i