On 2015-12-04 19:16, Kim Barrett wrote:
On Dec 4, 2015, at 2:16 AM, Per Liden wrote:
On 2015-12-02 19:37, Kim Barrett wrote:
Please review this change to PhantomReference processing, changing the
GC-based notification to automatically clear the referent.
[…]
CR:
https://bugs.openjdk.java.n
Hi Daniel,
Thanks for reviewing and suggestions, 1> add big warning to warn
maintainer that the tests were dependent on line numbers.; 2> verify
line numbers by parsing the source code. I think your second suggestion
is great! :-), but to keep the logic simple and straight, I prefer your
firs
Hi,
Please review the updated webrevs
http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.01/
http://cr.openjdk.java.net/~sundar/8143404/top/webrev.01/
http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/
Thanks,
-Sundar
On 12/4/2015 12:12 PM, Mandy Chung wrote:
Right. Run this
Hi,
I'd like to wait for the review, but I have a trivial question:
Which @since is preferred, 1.9 or 9?
For ex, at Optional#or and stream, @since 9 is used.
On the other hand, at Collectors#flatMap, @since 1.9 is used.
Regards,
shinyafox(Shinya Yoshida)
2015-12-05 22:18 GMT+09:00 Paul Sandoz
On 6/12/2015 2:23 AM, Doug Lea wrote:
On 12/03/2015 12:53 AM, David Holmes wrote:
On 3/12/2015 12:56 AM, Doug Lea wrote:
In the absence of any of: tail-recursion support, reliable cleanup,
or growable stacks, it seems reasonable to choose larger default
stack sizes so that these long but finite
Hi Roger,
Sorry to be late here but was trying not to get involved :)
It is already implicit that ThreadFactory.newThread should return
unstarted threads - that is what a new Thread is - so I don't think
IllegalThreadStateException needs to be documented here as it is
documenting behaviour of
Hi Chris,
On 5/12/2015 7:00 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8144677
http://cr.openjdk.java.net/~cjplummer/8144677/webrev.01/webrev/
Tested with JPRT with:
• "-testset hotspot"
• "-testset svc"
• "-testset chris" fr
Hello!
Currently Pattern.splitAsStream JavaDoc says [1]:
* If the input sequence is mutable, it must remain constant during the
* execution of the terminal stream operation. Otherwise, the result of the
* terminal stream operation is undefined.
However in reality the sequence must remain co
Hi Alberto,
Further to this, all of these have been proposed in one form or another
previously during Project Coin during Java 7's development. I suggest you
have a look at the old coin-dev archives (http://mail.openjdk.java.net/
pipermail/coin-dev/) to see why they weren't taken on board (or wer
