Re: [PING] PoC for JDK-4347142: Need method to set Password protection to Zip entries

2015-12-19 Thread Xueming Shen
You Yasumasa, It is no longer necessary to touch the native code (zip_util.c/h) after the native ZipFile implementation has been moved up to the java level. Those native code are for vm access only now, which I dont think care about the password support at all. But before getting into the

Re: RFR 4823133: RandomAccessFile.length() is not thread-safe

2015-12-19 Thread Dmitry Samersoff
Vyom, I did some tests and the problem mentioned below is not relevant to Java. I can't reproduce it with Java testcase. Sorry for a noise. -Dmitry On 2015-12-18 23:42, vyom wrote: > Hi Dmitry, > > thanks for the review can you please explain little bit more, as per my > testing and

RFR: 8145680: Remove unnecessary explicit initialization of volatile variables in java.base

2015-12-19 Thread Claes Redestad
Hi, initializing volatile fields to their default value has a well-known performance penalty, and removing these should typically be safe. This patch addresses java.base. There are however some corner cases that we need to check for, see examples and discussion in

RFR:JDK-8145166 : Duration.toString violates specification

2015-12-19 Thread nadeesh tv
Hi all, Please review Bug Id - https://bugs.openjdk.java.net/browse/JDK-8145166 Issue - Duration.toString violates specification for Durations which have value in the range -59 to -60, -119 to -120 seconds etc. webrev -