On 5/02/2016 2:24 PM, Mandy Chung wrote:
On Feb 4, 2016, at 5:05 PM, David Holmes wrote:
Java hasn't needed a public signal handling API for the last 20 years. It's only getting
one now because modularity is forcing us to cut-off sun.misc.Signal from the few
use-cases that do need it. And w
I fully agree that moving the arguments checking up to Java makes more
sense, and I've prepared new webrevs which do exactly that, including
changes to address the other feedback from David, John and others:
hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8141491/webrev.04/hotspot/webrev
On 05/02/2016 18:55, Xueming Shen wrote:
Hi
Please help codereview the change to build the jdk9 runtime to use the
system zlib on
Solaris and Linux platforms by default.
Issue: https://bugs.openjdk.java.net/browse/JDK-8031767
Webrev: http://cr.openjdk.java.net/~sherman/8031767/webrev/
I'm hap
Hi
Please help codereview the change to build the jdk9 runtime to use the
system zlib on
Solaris and Linux platforms by default.
Issue: https://bugs.openjdk.java.net/browse/JDK-8031767
Webrev: http://cr.openjdk.java.net/~sherman/8031767/webrev/
Background info:
Compression is heavily used in
Hi all
Please review the fix for bug: https://bugs.openjdk.java.net/browse/JDK-8135259
Bug Description: Attempts to resolve a host unknown to the DNS server cause an
UnknownHostException stating "unknown error" instead of "Name or service not
known".
Webrev: http://cr.openjdk.java.net/
Thanks, John.
On 2/4/16 9:52 PM, John Rose wrote:
Looks good. Except I don't recall how is_inline interacts, if at all, with
customization. It's not clear what is being gated, and which optimizations get
let through.
Inlining through MH::invokeBasic doesn't happen when there's @DontInline
on
Proposed fix looks good.
Quoting John: "The use of erased types (any ref => Object) in the MH
runtime is an artifact of bootstrapping difficulties, early in the
project. I hope it is not necessary any more."
Best regards,
Vladimir Ivanov
On 2/5/16 4:29 PM, Paul Sandoz wrote:
Hi Shilpi,
In
Looks fine to me Mark.
Regards,
Sean.
On 29/01/16 01:10, Mark Sheppard wrote:
Hi,
based on feedback from reviews the current version of this fix can
be found at
http://cr.openjdk.java.net/~msheppar/8144144/webrev.05/
please oblige and review
regards
Mark
On 22/01/2016 11:14, Seán Coffe
Hi Shilpi,
In principle this change is ok, however these methods are kind of special
because they are called by code generated from LambdaForms with erased types.
IIUC the casts can serve as belts-and-braces checks just in case that generated
code passes something that is not of the correct typ
> On 29 Jan 2016, at 12:43, shilpi rastogi wrote:
>
> Hi All,
>
> Please review the updated patch-
>
> http://cr.openjdk.java.net/~srastogi/8138578/webrev.01/
>
> I verified Lookup.unreflectSpecial() also throws
> java.lang.IllegalAccessException so updated the JavaDoc.
>
+1
Paul.
Hi,
Nice use of C++ templates :-)
Overall looks good.
I too would prefer if we could move the argument checking out, perhaps even to
the point of requiring callers do that rather than providing another method,
for example for Buffer i think the arguments are known to be valid? I think in
eith
On Fri, Feb 5, 2016 at 3:00 AM, Stuart Marks
wrote:
>
>
> On 2/4/16 5:05 PM, David Holmes wrote:
>
>> The initial task was to provide a replacement for sun.misc.Signal.
>>> Sun.misc.Signal provides to Java the same set of
>>> signals the VM is able to handle and exposes via the JVM_findSignal,
>>
12 matches
Mail list logo
