JDK 9 RFR of JDK-8151785: Doc typo in src/../java/util/stream/PipelineHelper.java

2016-03-13 Thread Hamlin Li
Please help to review the tiny doc typo fix for bug https://bugs.openjdk.java.net/browse/JDK-8151785 it should be "copyInto(wrapSink(sink), spliterator);", but it is "intoWrapped(wrapSink(sink), spliterator);", there is no method called intoWrapped. diff -r 25e8c082d7ef

Re: RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

2016-03-13 Thread joe darcy
Approved; thanks, -Joe On 3/13/2016 4:16 PM, Michael Haupt wrote: Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael

Re: RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

2016-03-13 Thread joe darcy
Approved; thanks, -Joe On 3/13/2016 4:16 PM, Michael Haupt wrote: Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael

Re: RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

2016-03-13 Thread joe darcy
Approved; thanks, -Joe On 3/13/2016 4:16 PM, Michael Haupt wrote: Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael

RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

2016-03-13 Thread Michael Haupt
Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael -- Dr. Michael Haupt | Principal Member of

Re: JDK 9 RFR of JDK-8149896: Remove unnecessary values in FloatConsts and DoubleConsts

2016-03-13 Thread joe darcy
On 2/16/2016 8:58 AM, Mike Duigou wrote: From: joe darcy Hello, The the FloatConsts and DoubleConsts classes, while moved to an internal package recently (JDK-8145990), contain constants now available via the public API. All such uses of the redundant values should be