Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Hi Alan and Amy, thanks for figuring this out. Updated to suggested practice. New webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.01/ Felix On 2016/4/11 14:46, Alan Bateman wrote: On 11/04/2016 06:04, Felix Yang wrote: Amy, thanks. I'm not sure which practices are suggeste

RE: JDK 9 Build 111 seems to miss some locale data, Lucene tests fail with Farsi and Thai language

Hi Alan, I can confirm, the problem is fixed in build 113. Thanks! Uwe - Uwe Schindler uschind...@apache.org ASF Member, Apache Lucene PMC / Committer Bremen, Germany http://lucene.apache.org/ From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Sunday, March 27, 201

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

On 11/04/2016 06:04, Felix Yang wrote: Amy, thanks. I'm not sure which practices are suggested. By searching the existing tests, I found lots of test with 2+ @modules, so I chose to add another @modules. Personally, both ways look clear and transparent for me. We've tried to use one @modul

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Amy, thanks. I'm not sure which practices are suggested. By searching the existing tests, I found lots of test with 2+ @modules, so I chose to add another @modules. Personally, both ways look clear and transparent for me. Thanks, Felix On 2016/4/11 12:49, Amy Lu wrote: On 4/11/16 11:47 A

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

On 4/11/16 11:47 AM, Felix Yang wrote: Hi there, please review the following bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8153928 Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/ You might want to do some cleanup to avoid using two @modules tags? BTW. I'm not openj

RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Hi there, please review the following bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8153928 Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/ After changes in JDK-8153737 , it introduced new dependency of java.base/jdk

Re: RFR: JDK-8152115 (proxy) Examine performance of dynamic proxy creation

> On Apr 10, 2016, at 11:59 AM, Peter Levart wrote: > > So here's updated webrev: > > http://cr.openjdk.java.net/~plevart/jdk9-dev/Proxy.caching/webrev.06/ Looks good to me. thanks Mandy

Re: RFR: JDK-8152115 (proxy) Examine performance of dynamic proxy creation

Hi Mandy, On 04/08/2016 09:45 PM, Mandy Chung wrote: On Apr 8, 2016, at 3:41 AM, Peter Levart wrote: Hi, With Mandy we have prepared the following patch to restore performance of java.lanf.reflect.Proxy class caching that has regressed with introduction of additional checks that have to be

Re: RFR: 8149450: LdapCtx.processReturnCode() throwing Null Pointer Exception

Looks fine to me. Thanks, Xuelei On 4/10/2016 9:41 PM, Sean Coffey wrote: > Looking to fix this issue. Better checks for the referrrals field. > > bugID : https://bugs.openjdk.java.net/browse/JDK-8149450 > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8149450.jdk9/webrev/ > > regards, > S

RFR: 8149450: LdapCtx.processReturnCode() throwing Null Pointer Exception

Looking to fix this issue. Better checks for the referrrals field. bugID : https://bugs.openjdk.java.net/browse/JDK-8149450 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8149450.jdk9/webrev/ regards, Sean.