Re: RFR(xs): 8059361: Properties.stringPropertyNames() returns a set inconsistent with the assertions from the spec

On May 26, 2016, at 3:49 PM, Stuart Marks wrote: > > > > On 5/26/16 2:28 PM, Mandy Chung wrote: >>> -return h.keySet(); >>> +return Set.of(h.keySet().toArray(new String[0])); >>>} >> >> The patch looks fine. It’d be good to add a test case. >> >>

Re: RFR 8157996: Unneeded import in lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java

http://cr.openjdk.java.net/~shurailine/8157996/webrev.01/ Thank you. Shura > On May 26, 2016, at 3:29 PM, Alexandre (Shura) Iline > wrote: > > >> On May 26, 2016, at 3:16 PM, Mandy Chung wrote: >> >> >>> On May 26, 2016, at 2:30 PM,

Re: RFR 8157996: Unneeded import in lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java

> On May 26, 2016, at 2:30 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please take a look on an obvious fix: > http://cr.openjdk.java.net/~shurailine/8157996/webrev.00/ > > There was an unneeded import statement which was getting in the way when > running

RFR 8157996: Unneeded import in lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java

Hi. Please take a look on an obvious fix: http://cr.openjdk.java.net/~shurailine/8157996/webrev.00/ There was an unneeded import statement which was getting in the way when running tests with limited module availability. Also in a couple of places I have added try with resources. Shura

Re: RFR(xs): 8059361: Properties.stringPropertyNames() returns a set inconsistent with the assertions from the spec

On 5/25/16 5:27 PM, Mandy Chung wrote: On May 25, 2016, at 5:11 PM, Stuart Marks wrote: On 5/25/16 4:58 PM, Mandy Chung wrote: Have you considered fixing this method to return a unmodifiable set and make this spec in JDK 9? It’s a small change. I did think about

Re: JDK 9 RFR of JDK-6961865: javadoc for Boolean.valueOf(String) with null argument not clearly specified

On 05/26/2016 10:02 PM, joe darcy wrote: > JDK-6961865: javadoc for Boolean.valueOf(String) with null argument > not clearly specified > > http://cr.openjdk.java.net/~darcy/6961865.0/ +1 Thanks, -Aleksey

JDK 9 RFR of JDK-6961865: javadoc for Boolean.valueOf(String) with null argument not clearly specified

Hello, Please review these spec clarifications for java.lang.Boolean: JDK-6961865: javadoc for Boolean.valueOf(String) with null argument not clearly specified http://cr.openjdk.java.net/~darcy/6961865.0/ Thanks, -Joe

RE: Fwd: Files.walk() is unusable because of AccessDeniedException

Let’s not forget that in the use case where there is an installed security manager, the API clearly states how those access checks are supported. The results of access checks are communicated by the security manager using unchecked exceptions. As a result the Files::walk implementation has to

Re: RFR: JDK-8157850 Jar tests should pass through VM options

Thanks for feedback guys. I've updated review http://cr.openjdk.java.net/~anazarov/8157850/webrev.02/ Please sponsor this patch if you are OK. My use case is to run tests with different -Xms and -Xmx options. Mostly due to I need to increase heap size to gather code coverage by jcov.

Re: [9] RFR: Static build of libzip is missing JNI_OnLoad_zip entry point

+1 On 5/24/16 4:47 PM, Naoto Sato wrote: Hello, The previous attempt to fix this one failed in the installer build, as it does not recognize the added macro. I've updated the fix to add extra check for static build (yeah, this is redundant with the real jni_util.h, but effectively avoid

RFR: 8151876: (tz) Support tzdata2016d

HI all, Please review the latest TZDATA integration (tzdata2016d) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8151876 Webrev: http://cr.openjdk.java.net/~rpatil/8151876/webrev.00/ Patch Contains: 1. IANA tzdata2016d integration into JDK. [It also includes tzdata2016b and

Re: (@modules documentation)

On 26/05/2016 10:52, Seán Coffey wrote: Was our OpenJDK documentation ever updated to highlight the @modules change for JDK 9 ? Could we edit the developer's guide[1] to highlight the @modules tag [2]. The current doc states that an @bug tag should be supplied. It would help to document

Re: Files.walk() is unusable because of AccessDeniedException

Hi, Jumping in a bit late to this thread… To achieve this with parity to the non-Stream walk method we would need to implement a FileTreeSpliterator that accepts a FileVistor for the purposes of specialised filtering. You can do this with an Iterator-based implementation from which a

(@modules documentation)Re: RFR JDK-8147539: (zipfs) ZipPath should throw ProviderMismatchException when invoking register()

Was our OpenJDK documentation ever updated to highlight the @modules change for JDK 9 ? Could we edit the developer's guide[1] to highlight the @modules tag [2]. The current doc states that an @bug tag should be supplied. It would help to document why/when an @modules tag would be required

RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

Hi all, Please review BugId : https://bugs.openjdk.java.net/browse/JDK-8066806 Issue: java.time.format.DateTimeFormatter cannot parse an offset with single digit hour webrev: http://cr.openjdk.java.net/~ntv/8066806/webrev.03/ Solution: Added the suggested patterns but the parsing logic