This is an interesting problem.
> > for (; i < hi; ++i) {
> > @SuppressWarnings("unchecked")
> > E e = lst.get(i);
> > action.accept(e);
> > checkForComodification(mc);
> > }
> > return;
>
> For better performance ArrayList.spliterator() does not check for
> comodi
The CheckDisplayNames.java change is different from what I suggested and
doesn't make sense. But we no longer need the test. I'd suggest
CheckDisplayNames.java be removed. Otherwise, the fix looks OK to me.
Masayoshi
On 5/31/2016 3:03 AM, Ramanand Patil wrote:
Hi Masayoshi and All,
Here is
On 31/05/2016 03:59, Mandy Chung wrote:
SelectVersion is called for launching any application. It processes -splash
option separately from the launcher argument processing. To hit this bug, it
will need to launch with the new module-system option together with -splash. I
have verified wit
Thanks for your feedback!
While I look into other feedback, one quick reply to this:
> I wonder if it's really necessary to go down to the List.spliterator().
> Probably it would be ok to leave
List.spliterator() as is, but redefine AbstractList.spliterator() only (so only
implementations deriv
Thanks Paul,
updated accordingly.
http://cr.openjdk.java.net/~sherman/8061777/webrev
-sherman
On 5/30/16 2:31 AM, Paul Sandoz wrote:
Hi Sherman,
Do you consider modifying the new ZipPath constructor you added to accept a
boolean value for UTF-8 encoding?
If so you can more clearly document
Hello!
(disclaimer: I'm not an official reviewer)
> ((AbstractList) lst).modCount;
Raw-type casts should be replaced with AbstractList to avoid
warning.
> public RandomAccessSpliterator trySplit()
Covariant return type seems to be unnecessary here as this spliterator
is not public and covarian
Hi Paul,
Thank you very much for your feedback, and apologize for the delay in
response..
I have incorporated your comments in the attached patch. Please kindly take a
look and let me know if you have further feedback.
- Modified @implSpec to add a description in case the list implements
Ran
> On May 27, 2016, at 9:54 PM, Alan Bateman wrote:
>
> On 28/05/2016 05:29, Mandy Chung wrote:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152721/webrev.00/
>>
>> The launcher does not handle the new options with whitespace separated
>> arguments properly. This patch applies that cons
On 27/05/2016 2:20 AM, Andrey Nazarov wrote:
Thanks for feedback guys.
I've updated review http://cr.openjdk.java.net/~anazarov/8157850/webrev.02/
Using test.tool.vm.opts seems reasonable for jar and javac.
Please sponsor this patch if you are OK.
Sorry not my area.
Thanks,
David
My use
On 30/05/16 13:44, Yasumasa Suenaga wrote:
> We had aimed to handle *traditional* zip encryption at first.
> However, we also want to handle *strong* zip encryption. (e.g. AES)
OpenJDK does not control the format of a zip file. To make
such a change we'd have to negotiate with the other users of
Hi Masayoshi and All,
Here is the updated Webrev:
http://cr.openjdk.java.net/~rpatil/8151876/webrev.01/
As suggested by Masayoshi, I have kept the existing names unchanged.
Also, this patch contains extra test case fixes for
1. java/util/TimeZone/CheckDisplayNames.java
2.
Hi Mandy,
Looks good to me.
Best Regards,
Aleksej
On 25/05/16 22:48, Mandy Chung wrote:
On May 25, 2016, at 12:45 PM, Alan Bateman wrote:
On 25/05/2016 20:29, Mandy Chung wrote:
wsgen and wsimport tools use the utility classes in java.xml.bind module to
localize messages. Resource bundles
Any updates, guys?
--Andrey
On 26.05.2016 19:20, Andrey Nazarov wrote:
Thanks for feedback guys.
I've updated review
http://cr.openjdk.java.net/~anazarov/8157850/webrev.02/
Please sponsor this patch if you are OK.
My use case is to run tests with different -Xms and -Xmx options.
Mostly d
Hi Shilpi,
You have found the right place but i am not sure your fix is entirely correct.
(Tip: if you use -Xlog:exceptions=info you can observe the IAE exception when
the annotation is processed)
In your test you have:
@Target(value = ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
@
Hi Mark,
I also agree to you.
We had aimed to handle *traditional* zip encryption at first.
However, we also want to handle *strong* zip encryption. (e.g. AES)
As discussion in this mail thread, I'm sure that Java developers
need this feature. So I want to move forward with this proposal.
For e
Hi Sherman,
Do you consider modifying the new ZipPath constructor you added to accept a
boolean value for UTF-8 encoding?
If so you can more clearly document the behaviour and avoid duplication of the
operators in ZipFileSystem e.g.:
return new ZipPath(this, first, zc.isUTF8());
Paul.
> On
This is sad, but I agree. Reviewed.
-Chris.
On 30/05/16 08:18, Felix Yang wrote:
Hi all,
please review the change to mark following tests with keyword
'intermittent'. These tests have been observed to fail intermittently
for a while.
test/java/net/httpclient/SplitResponse.java
test/java/net
On 05/30/2016 10:33 AM, Amy Lu wrote:
> tools/pack200/BandIntegrity.java
>
> This test was failing intermittently (JDK-8154049). Mentioned issues
> have been resolved and no open bug (no failure reported) till now.
>
> This patch is to remove @key intermittent from the test.
>
> bug: https://bug
Hi, Kumar
So far this test is in ProblemList.txt:
tools/pack200/Pack200Test.java 8059906,8151901 generic-all
Will it be removed from ProblemList.txt in this fix?
Thanks,
Amy
On 3/22/16 3:49 AM, Kumar Srinivasan wrote:
Hi John,
This patch contains fixes for two bugs:
8151901: test/tools/pack2
tools/pack200/BandIntegrity.java
This test was failing intermittently (JDK-8154049). Mentioned issues
have been resolved and no open bug (no failure reported) till now.
This patch is to remove @key intermittent from the test.
bug: https://bugs.openjdk.java.net/browse/JDK-8154980
webrev: http:
Hi all,
please review the change to mark following tests with keyword
'intermittent'. These tests have been observed to fail intermittently
for a while.
test/java/net/httpclient/SplitResponse.java
test/java/net/httpclient/http2/BasicTest.java
test/java/net/httpclient/http2/ErrorTest.java
tes
21 matches
Mail list logo
